From: "\"zhilizhao(赵志立)\"" <quinkblack@foxmail.com> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Subject: Re: [FFmpeg-devel] [PATCH RFC] avformat/hls: check IV size inside EXT-X-KEY Date: Wed, 13 Apr 2022 20:32:37 +0800 Message-ID: <tencent_1D342019CDB2CFF0D57F273438A796764D07@qq.com> (raw) In-Reply-To: <164985079952.21047.6948837515637292729@lain.red.khirnov.net> > On Apr 13, 2022, at 7:53 PM, Anton Khirnov <anton@khirnov.net> wrote: > > Quoting Zhao Zhili (2022-04-12 10:27:50) >> IV should always be 128 bits. If the IV attribute was truncated >> inside EXT-X-KEY, padding on the left which is the same as when >> using sequence number as IV. >> --- >> I'm not sure which method is better: do padding or just return >> AVERROR_INVALIDDATA? > > I would say return error, unless there are known buggy producers of > incomplete IVs that we want to support. Make sense. Actually it’s a story about shoot myself in the foot. I created a buggy manifest, and the bug is hidden by the default padding on the tail. So the vide only works with ffmpeg/ffplay. Let’s hope I’m the only one make such mistake. Will send a patch to return error in this case. > > -- > Anton Khirnov > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-04-13 12:32 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-12 8:27 Zhao Zhili 2022-04-12 8:32 ` Steven Liu 2022-04-13 11:53 ` Anton Khirnov 2022-04-13 12:32 ` "zhilizhao(赵志立)" [this message] 2022-04-13 13:02 ` [FFmpeg-devel] [PATCH v2] " Zhao Zhili
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=tencent_1D342019CDB2CFF0D57F273438A796764D07@qq.com \ --to=quinkblack@foxmail.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git