From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8D188465B3 for ; Mon, 22 May 2023 08:44:21 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3E31E68C127; Mon, 22 May 2023 11:44:18 +0300 (EEST) Received: from out203-205-221-240.mail.qq.com (out203-205-221-240.mail.qq.com [203.205.221.240]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EE40F68BEC1 for ; Mon, 22 May 2023 11:44:10 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1684745048; bh=Qv+cFVlHe3BrLGVNRuRc3UeogExTa4FGo6pBYhY3Ec0=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=tAdSX3ZUogmmgNJCtVre+1M4BVGLzYU/PVlV2YdP7SEkGn3BDfdWt9igmfMvGJIMU jgFoXBFBd1cGO9DNbCl357hsEtIiv1BB8eccD3sA0jYghQwq0y1h6SKnW4a9xDQf1y H87m59lO6H3LrU5Zlux+bL3Qp2LMIj3HQJuJgbpc= Received: from smtpclient.apple ([119.147.10.196]) by newxmesmtplogicsvrszb1-0.qq.com (NewEsmtp) with SMTP id B072CCD9; Mon, 22 May 2023 16:44:07 +0800 X-QQ-mid: xmsmtpt1684745047t6y9o5unq Message-ID: X-QQ-XMAILINFO: N4CzT1PKe+qFvuGJVGDIEDEiMvpU8ns1L3ATiTvvp/74DRuFeeOS72XlosIaod yd9ARG7AyK0y24rD3dMjzyIV6k9Y6kEFXru/j81Y26r5DYtEjCoZhAYm5kmmtp+q2fboCEKqGXUc iMZIt2q/zOXe60UiYJOyUJ0rpR8J/xZxmSLFTiBpjAIaXGY87tt8XLjtKQFDoMQ63JDXfKXXH/iu K5WOD+wZhxt/1VHBxzsbINf6JPbM8RTZnZk3wbaHiY77WEOzML6BDYwdboheGYWM60owWLrYU0+S 8FFeGsr30wH7J1AAUAgXVb0AMpPoWHGivsenLFxPe+78+4/uWSpo4M3H1bshXfa+lVqna1g2lhqB 3oOv29EFwJ8oagubOJE4E4vhSgj+ROOiSuTVAO/vmxCvxET++e9IdzFDnhEZ0bRX1gwytXFqmRTU i9t+GWvjDON2+90oWWgvwfizzBsxS2Wpvi56732FccXrYSKMu64kIuIwlpLmhZkzc4pA+6IuG4kX fxBpYNaLT7/SHfQAbCM9sFzUcRg44GofJJN6/LFG3geddMZhL9oj/7UftCpbo76rXCMhUduXYOSu 1+DiRxbC64L0bBMKmpfcr+g+e2dUHH9WWRzZAVrC/d9uFjNbwnrLJwNtvSWYB6+FXIJ9eQ4tDEbg A74jZJg9who5cOylRoqkq7Nq+hoArKHfM9Pj8t1ihanacZ4g0YW8shKTHPi02rP8Ug/n+i7dUO9b cXsk37+Azejaa+S0KBTnFWeTXn079fIwmIILrWmXqVQ/wJ66QBEL/f9TopwAyBzdrNUiWaGRBjGa Va1VDD/2f4PhwkLSjPgmiK4UmuK71nyuzlnukQT4Iy1xClS/t1dCpSN2eSW8/2fnwLTKlY/cweua F4xwjdSv/pkzJReIbfuaLMNhsFHZ8vls+btCOWFE4zDT9G1IqFrxSyAQLURbLXv/h1SmOgHl7AWx E90uNmIlh0fd+EC+J+5dAZzUtEGCPjFfhqTMnZ7dbo2dRM7vNf7P642/2kzKkgD70q51sOLrPcG+ UXPKlV/7H050hc37X+ Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) From: =?utf-8?B?InpoaWxpemhhbyjotbXlv5fnq4spIg==?= In-Reply-To: Date: Mon, 22 May 2023 16:44:07 +0800 X-OQ-MSGID: <32C4197A-80EB-43C9-90F9-5409BBD08F40@foxmail.com> References: To: FFmpeg development discussions and patches X-Mailer: Apple Mail (2.3696.120.41.1.1) Subject: Re: [FFmpeg-devel] [PATCH] avcodec/mediacodecdec: add low latency decoding X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: =?utf-8?B?5b6Q56aP6ZqG?= <839789740@qq.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On May 22, 2023, at 14:52, xufuji456 <839789740@qq.com> wrote: > > The low-latency decoding mode has available in Android api 30. > See https://developer.android.google.cn/reference/android/media/MediaCodec?hl=en#PARAMETER_KEY_LOW_LATENCY > > Signed-off-by: xufuji456 <839789740@qq.com> > --- > libavcodec/mediacodecdec.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/mediacodecdec.c b/libavcodec/mediacodecdec.c > index 21464900d1..52c30e1173 100644 > --- a/libavcodec/mediacodecdec.c > +++ b/libavcodec/mediacodecdec.c > @@ -395,6 +395,12 @@ static av_cold int mediacodec_decode_init(AVCodecContext *avctx) > ff_AMediaFormat_setInt32(format, "width", avctx->width); > ff_AMediaFormat_setInt32(format, "height", avctx->height); > > + sdk_int = ff_Build_SDK_INT(avctx); > + // low-latency mode: available in Android api 30 > + if (sdk_int >= 30 && (avctx->flags & AV_CODEC_FLAG_LOW_DELAY)) { > + ff_AMediaFormat_setInt32(format, "low-latency", 1); > + } > + Please remove the check on api level. ff_Build_SDK_INT() can fail, and set an unknown option for api level < 30 should be fine. > s->ctx = av_mallocz(sizeof(*s->ctx)); > if (!s->ctx) { > av_log(avctx, AV_LOG_ERROR, "Failed to allocate MediaCodecDecContext\n"); > @@ -414,7 +420,6 @@ static av_cold int mediacodec_decode_init(AVCodecContext *avctx) > "MediaCodec started successfully: codec = %s, ret = %d\n", > s->ctx->codec_name, ret); > > - sdk_int = ff_Build_SDK_INT(avctx); > /* ff_Build_SDK_INT can fail when target API < 24 and JVM isn't available. > * If we don't check sdk_int > 0, the workaround might be enabled by > * mistake. > -- > 2.32.0 (Apple Git-132) > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".