From: Zhao Zhili <quinkblack-at-foxmail.com@ffmpeg.org> To: ffmpeg-devel@ffmpeg.org Cc: Zhao Zhili <zhilizhao@tencent.com> Subject: [FFmpeg-devel] [PATCH] avcodec/ffv1_parser: Rename close to ffv1_close Date: Wed, 19 Feb 2025 20:33:27 +0800 Message-ID: <tencent_12CFD8D5542708388C16294D68203FCDA007@qq.com> (raw) From: Zhao Zhili <zhilizhao@tencent.com> This fixed wasm checkasm failure $ wasm-tools validate tests/checkasm/checkasm error: wasisdk://v25.0/build/sysroot/wasi-libc-wasm32-wasip1-threads/libc-top-half/musl/src/stdio/__stdio_close.c:24:9 function `__stdio_close` failed to validate Caused by: 0: func 4581 failed to validate 1: type mismatch: expected i32 but nothing on stack (at offset 0x43b770) Since close is declared as static function, it's more like a bug in wasi sdk, but we can workaround it easily. --- libavcodec/ffv1_parser.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/ffv1_parser.c b/libavcodec/ffv1_parser.c index f36a5dfdbd..bf61e88a2e 100644 --- a/libavcodec/ffv1_parser.c +++ b/libavcodec/ffv1_parser.c @@ -70,7 +70,7 @@ static int parse(AVCodecParserContext *s, return buf_size; } -static void close(AVCodecParserContext *s) +static void ffv1_close(AVCodecParserContext *s) { FFV1ParseContext *p = s->priv_data; @@ -82,5 +82,5 @@ const AVCodecParser ff_ffv1_parser = { .codec_ids = { AV_CODEC_ID_FFV1 }, .priv_data_size = sizeof(FFV1ParseContext), .parser_parse = parse, - .parser_close = close, + .parser_close = ffv1_close, }; -- 2.46.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
reply other threads:[~2025-02-19 12:33 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=tencent_12CFD8D5542708388C16294D68203FCDA007@qq.com \ --to=quinkblack-at-foxmail.com@ffmpeg.org \ --cc=ffmpeg-devel@ffmpeg.org \ --cc=zhilizhao@tencent.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git