From: "\"zhilizhao(赵志立)\"" <quinkblack@foxmail.com> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Subject: Re: [FFmpeg-devel] [PATCH 2/3] avcodec/videotoolboxenc: remove AUTO_PROFILE define Date: Sun, 25 Jun 2023 14:48:32 +0800 Message-ID: <tencent_11CF3E03579B9D64E1FC5A42354D81A83509@qq.com> (raw) In-Reply-To: <10de2b9a9f39a7cc12eb914e739fb483d37dfc78.camel@haerdin.se> > On Jun 24, 2023, at 17:21, Tomas Härdin <git@haerdin.se> wrote: > > fre 2023-06-09 klockan 19:14 +0800 skrev Zhao Zhili: >> From: Zhao Zhili <zhilizhao@tencent.com> >> >> Use FF_PROFILE_UNKNOWN as auto mode. > > Won't this break code that relies on AUTO_PROFILE? On the other hand If you mean that setting profile via the integer number is broken, I had the same consideration. Rick said "Only the string representation of the profiles are documented. The mapping from integer to profile isn’t.” I agree on this simple case. http://ffmpeg.org/pipermail/ffmpeg-devel/2023-May/310074.html > zero refers to profiles that actually exist such as profile0 for vp9, > so the old behavior is kinda bad. > > /Tomas > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-06-25 6:48 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <20230609111455.17989-1-quinkblack@foxmail.com> 2023-06-09 11:14 ` Zhao Zhili 2023-06-24 9:21 ` Tomas Härdin 2023-06-25 6:48 ` "zhilizhao(赵志立)" [this message] 2023-06-09 11:14 ` [FFmpeg-devel] [PATCH 3/3] avcodec/videotoolboxenc: inherit profile from AVCodecContext Zhao Zhili
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=tencent_11CF3E03579B9D64E1FC5A42354D81A83509@qq.com \ --to=quinkblack@foxmail.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git