From: Zhao Zhili <quinkblack@foxmail.com> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Subject: Re: [FFmpeg-devel] [PATCH 2/2] avutil/executor: Fix stack overflow due to recursive call Date: Mon, 8 Jul 2024 23:32:00 +0800 Message-ID: <tencent_0F40229AA09FF5AB254E1E700F2DCD9A5908@qq.com> (raw) In-Reply-To: <32130928-d5a6-4d50-be0a-4d6d4fa417cb@rothenpieler.org> > On Jul 8, 2024, at 22:07, Timo Rothenpieler <timo@rothenpieler.org> wrote: > > On 08.07.2024 09:43, Zhao Zhili wrote: >> From: Zhao Zhili <zhilizhao@tencent.com> >> av_executor_execute run the task directly when thread is disabled. >> The task can schedule a new task by call av_executor_execute. This >> forms an implicit recursive call. This patch removed the recursive >> call. >> --- >> libavutil/executor.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> diff --git a/libavutil/executor.c b/libavutil/executor.c >> index 89058fab2f..c145c51be9 100644 >> --- a/libavutil/executor.c >> +++ b/libavutil/executor.c >> @@ -58,6 +58,7 @@ struct AVExecutor { >> int die; >> AVTask *tasks; >> + int stack_depth; >> }; >> static AVTask* remove_task(AVTask **prev, AVTask *t) >> @@ -207,8 +208,12 @@ void av_executor_execute(AVExecutor *e, AVTask *t) >> } >> if (!e->thread_count || !HAVE_THREADS) { >> + if (e->stack_depth > 0) >> + return; >> + e->stack_depth++; >> // We are running in a single-threaded environment, so we must handle all tasks ourselves >> while (run_one_task(e, e->local_contexts)) >> /* nothing */; >> + e->stack_depth--; > > Won't this put the above line into the "nothing" while-loop? > Is that intended? If so, the indentation should be adjusted accordingly. > If not, the while-loop should gain empty {}. The comment specify it’s a while loop with empty body. Maybe it’s not obvious in the email client. > >> } >> } > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-07-08 15:32 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-07-08 7:43 Zhao Zhili 2024-07-08 14:07 ` Timo Rothenpieler 2024-07-08 15:32 ` Zhao Zhili [this message] 2024-07-08 22:35 ` Timo Rothenpieler 2024-07-09 11:36 ` Nuo Mi 2024-07-10 9:05 ` Anton Khirnov 2024-07-11 12:21 ` Nuo Mi 2024-07-11 12:32 ` Nuo Mi [not found] <20240708074021.13413-1-quinkblack@foxmail.com> 2024-07-08 7:40 ` Zhao Zhili
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=tencent_0F40229AA09FF5AB254E1E700F2DCD9A5908@qq.com \ --to=quinkblack@foxmail.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git