From: Zhao Zhili <quinkblack@foxmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] fate/screen: workaround test failure on mac M1
Date: Sun, 8 Oct 2023 21:22:45 +0800
Message-ID: <tencent_0F202C4D884FD9D50BA73CB897960A4D5F07@qq.com> (raw)
In-Reply-To: <tencent_8133E4137375DFC90B0EBF25453304C84505@qq.com>
> On Oct 8, 2023, at 21:17, Zhao Zhili <quinkblack@foxmail.com> wrote:
>
> From: Zhao Zhili <zhilizhao@tencent.com>
>
> The last frame is corrupted. It has different results on different
> platform.
> ---
> tests/fate/screen.mak | 3 ++-
> tests/ref/fate/zmbv-8bit | 1 -
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/fate/screen.mak b/tests/fate/screen.mak
> index bd6d228544..1c92935d23 100644
> --- a/tests/fate/screen.mak
> +++ b/tests/fate/screen.mak
> @@ -117,7 +117,8 @@ FATE_SCREEN += $(FATE_VMNC-yes)
> fate-vmnc: $(FATE_VMNC-yes)
>
> FATE_ZMBV += fate-zmbv-8bit
> -fate-zmbv-8bit: CMD = framecrc -i $(TARGET_SAMPLES)/zmbv/wc2_001-partial.avi -an -pix_fmt rgb24 -vf scale
> +# The last frame is corrupted.
> +fate-zmbv-8bit: CMD = framecrc -i $(TARGET_SAMPLES)/zmbv/wc2_001-partial.avi -an -frames:v 275 -pix_fmt rgb24 -vf scale
>
> FATE_ZMBV += fate-zmbv-15bit
> fate-zmbv-15bit: CMD = framecrc -i $(TARGET_SAMPLES)/zmbv/zmbv_15bit.avi -pix_fmt rgb24 -t 25 -vf scale
> diff --git a/tests/ref/fate/zmbv-8bit b/tests/ref/fate/zmbv-8bit
> index 7c2fab691f..9a7c96cb32 100644
> --- a/tests/ref/fate/zmbv-8bit
> +++ b/tests/ref/fate/zmbv-8bit
> @@ -278,4 +278,3 @@
> 0, 272, 272, 1, 192000, 0xd08e49d1
> 0, 273, 273, 1, 192000, 0xd08e49d1
> 0, 274, 274, 1, 192000, 0xd08e49d1
> -0, 275, 275, 1, 192000, 0x1f34135f
> --
> 2.42.0
Another method is drop the corrupted frame by decoder. It sounds better, but I’m afraid it may break some use cases.
https://ffmpeg.org/pipermail/ffmpeg-devel/2023-October/315557.html
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-10-08 13:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-08 13:17 Zhao Zhili
2023-10-08 13:22 ` Zhao Zhili [this message]
2023-10-16 12:29 ` Zhao Zhili
2023-10-16 17:40 ` Andreas Rheinhardt
2023-10-16 17:52 ` Zhao Zhili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_0F202C4D884FD9D50BA73CB897960A4D5F07@qq.com \
--to=quinkblack@foxmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git