From: 1035567130@qq.com
To: ffmpeg-devel@ffmpeg.org
Cc: Wang Yaqiang <wangyaqiang03@kuaishou.com>
Subject: [FFmpeg-devel] [PATCH v2] libavformat/img2dec: fix unable to find svg format when the svg resources start with "<svg" or "<!---"
Date: Thu, 9 Mar 2023 17:29:12 +0800
Message-ID: <tencent_0EDC47942748A370D70D3EB321BF645F1507@qq.com> (raw)
In-Reply-To: <tencent_5FEB93A291A4AB1D5FCD5042F2AA4AC5E306@qq.com>
From: Wang Yaqiang <wangyaqiang03@kuaishou.com>
svg is xml, but <?xml is not required,
it can start with <svg and can have multiple empty lines,
or start with <!--- include some comments,
but must first line if start with <?xml.
Signed-off-by: Wang Yaqiang <wangyaqiang03@kuaishou.com>
---
libavformat/img2dec.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c
index 5a63d7c81d..3488600400 100644
--- a/libavformat/img2dec.c
+++ b/libavformat/img2dec.c
@@ -964,8 +964,13 @@ static int svg_probe(const AVProbeData *p)
{
const uint8_t *b = p->buf;
const uint8_t *end = p->buf + p->buf_size;
-
- if (memcmp(p->buf, "<?xml", 5))
+ while (b && b < end && av_isspace(*b)) b++;
+ if (b >= end - 5)
+ return 0;
+ if (!memcmp(b, "<svg", 4)) {
+ return AVPROBE_SCORE_EXTENSION + 1;
+ }
+ if (memcmp(p->buf, "<?xml", 5) && memcmp(b, "<!--", 4))
return 0;
while (b < end) {
int inc = ff_subtitles_next_line(b);
--
2.39.2
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-03-09 9:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 12:34 [FFmpeg-devel] [PATCH] libavformat/img2dec: fix unable to find svg format when the svg resources start with "<svg" 1035567130
2023-03-08 23:37 ` Marton Balint
2023-03-09 9:12 ` wangyaqiang
2023-03-09 9:29 ` 1035567130 [this message]
2023-03-09 20:24 ` [FFmpeg-devel] [PATCH v2] libavformat/img2dec: fix unable to find svg format when the svg resources start with "<svg" or "<!---" Marton Balint
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_0EDC47942748A370D70D3EB321BF645F1507@qq.com \
--to=1035567130@qq.com \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=wangyaqiang03@kuaishou.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git