From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 277344D05C for <ffmpegdev@gitmailbox.com>; Mon, 17 Mar 2025 16:15:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 83603687C20; Mon, 17 Mar 2025 18:15:01 +0200 (EET) Received: from out162-62-57-252.mail.qq.com (out162-62-57-252.mail.qq.com [162.62.57.252]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BE7CF687BB2 for <ffmpeg-devel@ffmpeg.org>; Mon, 17 Mar 2025 18:14:53 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1742228089; bh=Th1oztrhnZ70aqjEi9WidY4vPTvgumCuc4tpy3Al1T4=; h=From:Subject:Date:References:To:In-Reply-To; b=OiAto14hIYfhWsunE8TEM+nCKlk2uoOfHlgynf37H+np16HeBb4cGF7JL7B/HlMxQ /7hNvMuvcVnw7l1LMypzgHUKbt85MV1fyjOv/bZp1p73RJOUrlPx7FXqRmr/DUcZUb tuqlaBWBwLx2q5LZ6bnaXtKbcoBcdPrayN8cWCbo= Received: from smtpclient.apple ([240e:3b7:3277:36f0:b89f:b602:8699:29bb]) by newxmesmtplogicsvrszgpua8-1.qq.com (NewEsmtp) with SMTP id 3AD3FE38; Tue, 18 Mar 2025 00:14:45 +0800 X-QQ-mid: xmsmtpt1742228085tuv09c6df Message-ID: <tencent_0E1CE84713EE936335C82901CEBDC547D305@qq.com> X-QQ-XMAILINFO: NrehM+cBVv5bD4Lw5acHworR3QYsFv+f5SfLnyP3rlB9SKVikuL10CwTUv3mO0 kTMd86vFXHWiZqrUKaW+4uLb7rFRE2nDzGFoZFwwcdLXo4li7OL0ADpNRKdGEise6EaWN5NtHzLl aLvvbZzgPMtXjLimfzwmp54t8I2F6MqX3IZNA48pkrO0MVJv0u3IipreweyUtXJ8P5YQTNVfXGEP X749BskN9jFaC0fGJDbK3QjsDhAQgIx7lBAMS5L0lS80UsPffH6b9AH7oZTm/edT9LXMj5JAqcqb pLJ6IXnl/Y0jYlJALMBt8HfFqgfA2NlDURi6NbHBSQg/1r9dPMaGCBcUhUAv0kKZAonlNcx2qbDk /T0ikfB0M4ZK++XMuguIfzYJKaMj4RtrrKQFswHwdngQAhbh5LhwiGBOd3YqEIWzU//ddhqb7+Fj 2ZzpXGdl+O1a6K5Wv9vHEdLdrfq1S3EOSLf9w6+Fa9FiyvwZrAMX0U2u7k3d/CXjvsirxWen1uYk nld7Gewe29ofJ14Tz6gKjjsppJOZBLMz4T1Gj5ETmMcvG6Qa1ezVcTyn1T21k1ZBo9fAKaPZWqRg PFDC+MgV85aOfFcV1zP4VIvi9q94SzYi0z5twj6iAMziJ7kBp25/cHzS3qioDCgyCFtOn0W2G4BH 8o9cyJaOlt3aAYwcg0wJw6WZu0xU8q4q7E8AWmPBg1mDvRVqrB/TazqWPZx7IJ+46ou0hm0UyBZ+ z15tvWUHoS8qvU6HED3YIxosgdbt4qxa2QbhsUMg4QU4yxIsp+IdXJrnW8WkiI1MIvbjf/bLkubP FMvyB0eC4zuwrySl7V26vjcm6Gpl44qw0TY5zO8mKiKZD9qmbSWJcEE47kZ26fxrY+UYMjha/0YD /Zkdmkv7bg9fpIaWeBThEYczzBKCfMDdsQ/lbCeSofI5LmStWFajmg1uL1eIUPE3FlI/wllfQOxE 8TFBlY404UqlC2UY4b3A== X-QQ-XMRINFO: MSVp+SPm3vtS1Vd6Y4Mggwc= From: Zhao Zhili <quinkblack-at-foxmail.com@ffmpeg.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3818.100.11.1.3\)) Date: Tue, 18 Mar 2025 00:14:32 +0800 References: <20250317151914.19384-1-ffmpeg@gyani.pro> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> In-Reply-To: <20250317151914.19384-1-ffmpeg@gyani.pro> X-OQ-MSGID: <D411F6BF-098D-4F48-B346-E26839056284@foxmail.com> X-Mailer: Apple Mail (2.3818.100.11.1.3) Subject: Re: [FFmpeg-devel] [PATCH] ffbuild: use response files only if ar accepts them X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/tencent_0E1CE84713EE936335C82901CEBDC547D305@qq.com/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> > On Mar 17, 2025, at 23:16, Gyan Doshi <ffmpeg@gyani.pro> wrote: > > This is to not break linking with toolchains that don't support reading > args from a 'response file'. > --- > I've assumed that ld on a system will have same support as ar. > > configure | 7 +++++++ > ffbuild/library.mak | 8 ++++++++ > 2 files changed, 15 insertions(+) > > diff --git a/configure b/configure > index f6964c4ee1..d84e32196d 100755 > --- a/configure > +++ b/configure > @@ -5230,6 +5230,12 @@ else > ar_o='$@' > fi > > +if $ar 2>&1 | grep -qi "@.*file"; then > + ar_objs="true" > +else > + ar_objs="" > +fi Works for me. > + > add_cflags $extra_cflags > add_cxxflags $extra_cxxflags > add_objcflags $extra_objcflags > @@ -8133,6 +8139,7 @@ DEPX86ASM=$x86asmexe > DEPX86ASMFLAGS=\$(X86ASMFLAGS) > AR=$ar > ARFLAGS=$arflags > +AR_OBJS=$ar_objs > AR_O=$ar_o > AR_CMD=$ar > NM_CMD=$nm > diff --git a/ffbuild/library.mak b/ffbuild/library.mak > index 72e3872157..7e1871b74c 100644 > --- a/ffbuild/library.mak > +++ b/ffbuild/library.mak > @@ -35,8 +35,12 @@ OBJS += $(SHLIBOBJS) > endif > $(SUBDIR)$(LIBNAME): $(OBJS) $(STLIBOBJS) > $(RM) $@ > +ifeq ($(AR_OBJS),true) > $(Q)echo $^ > $@.objs > $(AR) $(ARFLAGS) $(AR_O) @$@.objs > +else > + $(AR) $(ARFLAGS) $(AR_O) $^ > +endif > $(RANLIB) $@ > -$(RM) $@.objs > > @@ -68,8 +72,12 @@ $(SUBDIR)$(SLIBNAME): $(SUBDIR)$(SLIBNAME_WITH_MAJOR) > > $(SUBDIR)$(SLIBNAME_WITH_MAJOR): $(OBJS) $(SHLIBOBJS) $(SLIBOBJS) $(SUBDIR)lib$(NAME).ver > $(SLIB_CREATE_DEF_CMD) > +ifeq ($(AR_OBJS),true) > $(Q)echo $$(filter %.o,$$^) > $$@.objs > $$(LD) $(SHFLAGS) $(LDFLAGS) $(LDSOFLAGS) $$(LD_O) @$$@.objs $(FFEXTRALIBS) > +else > + $$(LD) $(SHFLAGS) $(LDFLAGS) $(LDSOFLAGS) $$(LD_O) $$(filter %.o,$$^) $(FFEXTRALIBS) > +endif > $(SLIB_EXTRA_CMD) > -$(RM) $$@.objs > > -- > 2.46.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".