From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 89A264F2B9 for ; Mon, 16 Jun 2025 07:39:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 8767A68DAC1; Mon, 16 Jun 2025 10:39:35 +0300 (EEST) Received: from out162-62-57-252.mail.qq.com (out162-62-57-252.mail.qq.com [162.62.57.252]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 8E4D868D997 for ; Mon, 16 Jun 2025 10:39:26 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1750059553; bh=RIUYoqG04d76Fgs5aSZd2hPDvanMDF7R20CCJb14pmM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=l94G+ucbLk4+atGOgsAHzpq43LHF8645L+T8oMbTgYczetRqLbOpqWrmdSz/Oty9W 0llVdIK+0UfkmiXerlT9SRs9N3FhFDC0I/6NTLFE/oMuDL6I5ToTUs5LnupmIvdRa8 tD0Ot6I1YqSHau0eTRvDQgBbEnfafT71XnL5xV4A= Received: from localhost.localdomain ([119.147.10.242]) by newxmesmtplogicsvrsza29-0.qq.com (NewEsmtp) with SMTP id 9CC0EC44; Mon, 16 Jun 2025 15:39:12 +0800 X-QQ-mid: xmsmtpt1750059552t241nu8jo Message-ID: X-QQ-XMAILINFO: OGpH2ycfin5hMungS+g4nYyUoDnq73j0sKujAWalrP9hhG5sKO0LAp6WDqkSSp IMSjnTMHtwBQh55wE64FNlBH61uF8C/s8Lc/F2iIY3YWNJeexXkhkTiH+DPOH3uArpcSqW9iGK8e JC0LiukjxIKCp4+m9uI3BjuK5ZTZUeGUNMvmNMQG9HUNh07eLIG6n7HOKajKM8wuAQv8D1bn/X55 1zF5pvDnaFzt96M13EHXqBRpkaEMOyPhrK1rUEjBsQH3D/nNpBC8sMDsoMLP2OqAUekiiSXkIGHW ytad4zMl7AM8KAhIWHnrEw0mCILD/KOFhctE1idGspU9at622C6b0RdM7h77hsMHRPhUtJykFcOn uS3lPzeakn1Tx69UIHxGeubWuCOqwlJd9unm5DIxAYH6en/x39Zv0JHq2TOnm3DYSc29oXoPMeDR Zbx2WxjJdX6iEtV0LkNA8Mm8bMKq11hCI3x0Xhhw20GYVZZRQl0hsHOtgtt9Ca1i/h4AEymEw+NN vWmv6VeI7c0dIwkgAsFL6IMRzwBw+tGrOVauz6xiGi2jrwWPsNlTqZsiPNtFQrtZGlGS2E5VUOnx JfO9wkF3vd3Xz1xNqque4sT/LjWCAoodiM9kex2WyvG1rVzGsC31ooNMkFjw75QAHrMrB5uSsPj0 x2pkKFNNlC+NFTTqydowjC2/W8fLFu8QDGrj0qXLega1xyjQFx1ucra0KL+riSgkebhC/FfKJkmj 1sEwY//krE7oT6L9/842U0yDdmx7kduBQbx4K5rgi2/+CPyDkxKLXQEgCSpp4iWECHNA+D0DEp9E a73HSMKh+O5OVCNTB6NDZdI94QL5Iqr8lGgBHBjILQilpoTwZLEsux4pCRzVNCY8A6k7uIOM1ULa SR7cE0zyNzO9iH/3taE3jRGdPbWZrQ2Gcv8B6X8TtMHKfodUzvs9xseqNvCgxZurul1ukQE9KHZB v2jyb8TVlUeE9qrtXOSiI7RvilygjNdS9loyDLZVWEiBI24T8HIZGiowu2YMQ7Q2UbY5X/2oA= X-QQ-XMRINFO: M/715EihBoGSf6IYSX1iLFg= From: Zhao Zhili To: ffmpeg-devel@ffmpeg.org Date: Mon, 16 Jun 2025 15:39:13 +0800 X-OQ-MSGID: <20250616073913.296463-1-quinkblack@foxmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <9b96e57-4e79-96da-69a9-eba9a3a8c9b0@martin.st> References: <9b96e57-4e79-96da-69a9-eba9a3a8c9b0@martin.st> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v2] checkasm/h264dsp: Fix stack overflow in check_idct_dequant X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Zhao Zhili Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: From: Zhao Zhili --- tests/checkasm/h264dsp.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/tests/checkasm/h264dsp.c b/tests/checkasm/h264dsp.c index f5f9650224..ca4a44ee3b 100644 --- a/tests/checkasm/h264dsp.c +++ b/tests/checkasm/h264dsp.c @@ -328,25 +328,32 @@ static void check_idct_multiple(void) static void check_idct_dequant(void) { static const int depths[5] = { 8, 9, 10, 12, 14 }; - LOCAL_ALIGNED_16(int16_t, src, [16]); - /* Ensure dst buffers are large enough to hold dctcoefs of all bit-depths. */ + /* Ensure buffers are large enough to hold dctcoefs of all bit-depths. */ + LOCAL_ALIGNED_16(uint8_t, src_buf, [16 * sizeof(int32_t)]); LOCAL_ALIGNED_16(uint8_t, dst0, [16 * 16 * sizeof(int32_t)]); LOCAL_ALIGNED_16(uint8_t, dst1, [16 * 16 * sizeof(int32_t)]); + int16_t *src = (int16_t *)src_buf; int16_t *dst_ref = (int16_t *)dst0; int16_t *dst_new = (int16_t *)dst1; H264DSPContext h; int bit_depth, i, qmul; declare_func_emms(AV_CPU_FLAG_MMX | AV_CPU_FLAG_SSE2, void, int16_t *output, int16_t *input, int qmul); - for (int j = 0; j < 16; j++) - src[j] = (rnd() % 512) - 256; - qmul = rnd() % 4096; for (i = 0; i < FF_ARRAY_ELEMS(depths); i++) { bit_depth = depths[i]; ff_h264dsp_init(&h, bit_depth, 1); + if (bit_depth == 8) { + for (int j = 0; j < 16; j++) + src[j] = (rnd() % 512) - 256; + } else { + int32_t *p = (int32_t *)src_buf; + for (int j = 0; j < 16; j++) + p[j] = (rnd() % (1 << (bit_depth + 1))) - (1 << bit_depth); + } + memset(dst0, 0, 16 * 16 * SIZEOF_COEF); memset(dst1, 0, 16 * 16 * SIZEOF_COEF); -- 2.25.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".