From: Zhao Zhili <quinkblack@foxmail.com>
To: "Tomas Härdin" <git@haerdin.se>,
"FFmpeg development discussions and patches"
<ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/6] avformat/movenc: add PCM in mp4 support
Date: Sat, 25 Feb 2023 02:29:18 +0800
Message-ID: <tencent_08A0E0505B7234ED81E234013E1F57879C09@qq.com> (raw)
In-Reply-To: <b965fe4b0501393f3df144de43c90dc8478b2cb4.camel@haerdin.se>
On Fri, 2023-02-24 at 10:41 +0100, Tomas Härdin wrote:
> fre 2023-02-24 klockan 20:25 +0800 skrev Zhao Zhili:
> > +static int is_mp4_pcm_codec(enum AVCodecID codec)
> > +{
> > + static const enum AVCodecID codec_list[] = {
> > + AV_CODEC_ID_PCM_S16BE,
> > + AV_CODEC_ID_PCM_S16LE,
> > + AV_CODEC_ID_PCM_S24BE,
> > + AV_CODEC_ID_PCM_S24LE,
> > + AV_CODEC_ID_PCM_S32BE,
> > + AV_CODEC_ID_PCM_S32LE,
> > +
> > + AV_CODEC_ID_PCM_F32BE,
> > + AV_CODEC_ID_PCM_F32LE,
> > + AV_CODEC_ID_PCM_F64BE,
> > + AV_CODEC_ID_PCM_F64LE,
> > + };
> > +
> > + for (int i = 0; i < FF_ARRAY_ELEMS(codec_list); i++) {
> > + if (codec == codec_list[i])
> > + return 1;
> > + }
>
> A switch() with multiple case statements in a row would be more
> concise.
Fixed in v2.
>
> The rest looks OK
>
> /Tomas
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-02-24 18:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230224122523.143571-1-quinkblack@foxmail.com>
2023-02-24 12:25 ` Zhao Zhili
2023-02-24 9:41 ` Tomas Härdin
2023-02-24 18:29 ` Zhao Zhili [this message]
2023-02-24 12:25 ` [FFmpeg-devel] [PATCH 2/6] avformat/mov: fix ISO/IEC 23003-5 support Zhao Zhili
2023-02-24 9:41 ` Tomas Härdin
2023-02-24 12:25 ` [FFmpeg-devel] [PATCH 3/6] avformat/isom_tags: remove ipcm from movaudio_tags Zhao Zhili
2023-02-24 9:42 ` Tomas Härdin
2023-02-24 12:25 ` [FFmpeg-devel] [PATCH 4/6] avformat/mov: parse ISO-14496-12 ChannelLayout Zhao Zhili
2023-02-24 9:42 ` Tomas Härdin
2023-02-24 18:37 ` Zhao Zhili
2023-02-24 13:49 ` Jan Ekström
2023-02-25 4:31 ` Zhao Zhili
2023-10-31 3:15 ` Zhao Zhili
2023-10-31 3:15 ` Zhao Zhili
2023-02-24 12:25 ` [FFmpeg-devel] [PATCH 5/6] avformat/movenc: write ChannelLayout box for PCM Zhao Zhili
2023-02-24 9:42 ` Tomas Härdin
2023-02-24 12:25 ` [FFmpeg-devel] [PATCH 6/6] fate/mov: add PCM in mp4 test Zhao Zhili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_08A0E0505B7234ED81E234013E1F57879C09@qq.com \
--to=quinkblack@foxmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=git@haerdin.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git