* [FFmpeg-devel] [PATCH v3] avformat/tls_openssl: fix warnings when openssl is lower version
@ 2025-06-15 15:15 Jack Lau via ffmpeg-devel
2025-06-15 15:54 ` Andreas Rheinhardt
0 siblings, 1 reply; 5+ messages in thread
From: Jack Lau via ffmpeg-devel @ 2025-06-15 15:15 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Jack Lau
[-- Attachment #1: Type: message/rfc822, Size: 4088 bytes --]
From: Jack Lau <jacklau1222@qq.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Jack Lau <jacklau1222@qq.com>
Subject: [PATCH v3] avformat/tls_openssl: fix warnings when openssl is lower version
Date: Sun, 15 Jun 2025 23:15:45 +0800
Message-ID: <tencent_FD0450645A5F2FDE27EF230EB38D7C546308@qq.com>
api doc: https://docs.openssl.org/1.0.2/man3/BIO_s_mem
In higher versions (openssl 1.0.2 and higher),
the function signature is BIO *BIO_new_mem_buf(const void *buf, int len),
so passing a const string doesn't cause an warnings.
However, in lower versions of OpenSSL,
the function signature becomes BIO *BIO_new_mem_buf(void *buf, int len),
which leads to warnings.
OpenSSL guarantees that it will not modify the string,
so it's safe to cast the pem_str to (void *) to avoid this warning.
Signed-off-by: Jack Lau <jacklau1222@qq.com>
---
libavformat/tls_openssl.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
index 86e8935fee..2a3905891d 100644
--- a/libavformat/tls_openssl.c
+++ b/libavformat/tls_openssl.c
@@ -415,7 +415,11 @@ error:
*/
static EVP_PKEY *pkey_from_pem_string(const char *pem_str, int is_priv)
{
+#if OPENSSL_VERSION_NUMBER < 0x10002000L /* OpenSSL 1.0.2 */
+ BIO *mem = BIO_new_mem_buf((void *)pem_str, -1);
+#else
BIO *mem = BIO_new_mem_buf(pem_str, -1);
+#endif
if (!mem) {
av_log(NULL, AV_LOG_ERROR, "BIO_new_mem_buf failed\n");
return NULL;
@@ -445,7 +449,11 @@ static EVP_PKEY *pkey_from_pem_string(const char *pem_str, int is_priv)
*/
static X509 *cert_from_pem_string(const char *pem_str)
{
+#if OPENSSL_VERSION_NUMBER < 0x10002000L /* OpenSSL 1.0.2 */
+ BIO *mem = BIO_new_mem_buf((void *)pem_str, -1);
+#else
BIO *mem = BIO_new_mem_buf(pem_str, -1);
+#endif
if (!mem) {
av_log(NULL, AV_LOG_ERROR, "BIO_new_mem_buf failed\n");
return NULL;
--
2.49.0
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [FFmpeg-devel] [PATCH v3] avformat/tls_openssl: fix warnings when openssl is lower version
2025-06-15 15:15 [FFmpeg-devel] [PATCH v3] avformat/tls_openssl: fix warnings when openssl is lower version Jack Lau via ffmpeg-devel
@ 2025-06-15 15:54 ` Andreas Rheinhardt
2025-06-17 14:07 ` Jack Lau
0 siblings, 1 reply; 5+ messages in thread
From: Andreas Rheinhardt @ 2025-06-15 15:54 UTC (permalink / raw)
To: ffmpeg-devel
Jack Lau via ffmpeg-devel:
> diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
> index 86e8935fee..2a3905891d 100644
> --- a/libavformat/tls_openssl.c
> +++ b/libavformat/tls_openssl.c
> @@ -415,7 +415,11 @@ error:
> */
> static EVP_PKEY *pkey_from_pem_string(const char *pem_str, int is_priv)
> {
> +#if OPENSSL_VERSION_NUMBER < 0x10002000L /* OpenSSL 1.0.2 */
> + BIO *mem = BIO_new_mem_buf((void *)pem_str, -1);
> +#else
> BIO *mem = BIO_new_mem_buf(pem_str, -1);
> +#endif
> if (!mem) {
> av_log(NULL, AV_LOG_ERROR, "BIO_new_mem_buf failed\n");
> return NULL;
> @@ -445,7 +449,11 @@ static EVP_PKEY *pkey_from_pem_string(const char *pem_str, int is_priv)
> */
> static X509 *cert_from_pem_string(const char *pem_str)
> {
> +#if OPENSSL_VERSION_NUMBER < 0x10002000L /* OpenSSL 1.0.2 */
> + BIO *mem = BIO_new_mem_buf((void *)pem_str, -1);
> +#else
> BIO *mem = BIO_new_mem_buf(pem_str, -1);
> +#endif
> if (!mem) {
> av_log(NULL, AV_LOG_ERROR, "BIO_new_mem_buf failed\n");
> return NULL;
That's what I had in mind.
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [FFmpeg-devel] [PATCH v3] avformat/tls_openssl: fix warnings when openssl is lower version
2025-06-15 15:54 ` Andreas Rheinhardt
@ 2025-06-17 14:07 ` Jack Lau
2025-06-21 2:18 ` Jack Lau
0 siblings, 1 reply; 5+ messages in thread
From: Jack Lau @ 2025-06-17 14:07 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: Andreas Rheinhardt
> On Jun 15, 2025, at 23:54, Andreas Rheinhardt <andreas.rheinhardt@outlook.com> wrote:
>
> Jack Lau via ffmpeg-devel:
>> diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
>> index 86e8935fee..2a3905891d 100644
>> --- a/libavformat/tls_openssl.c
>> +++ b/libavformat/tls_openssl.c
>> @@ -415,7 +415,11 @@ error:
>> */
>> static EVP_PKEY *pkey_from_pem_string(const char *pem_str, int is_priv)
>> {
>> +#if OPENSSL_VERSION_NUMBER < 0x10002000L /* OpenSSL 1.0.2 */
>> + BIO *mem = BIO_new_mem_buf((void *)pem_str, -1);
>> +#else
>> BIO *mem = BIO_new_mem_buf(pem_str, -1);
>> +#endif
>> if (!mem) {
>> av_log(NULL, AV_LOG_ERROR, "BIO_new_mem_buf failed\n");
>> return NULL;
>> @@ -445,7 +449,11 @@ static EVP_PKEY *pkey_from_pem_string(const char *pem_str, int is_priv)
>> */
>> static X509 *cert_from_pem_string(const char *pem_str)
>> {
>> +#if OPENSSL_VERSION_NUMBER < 0x10002000L /* OpenSSL 1.0.2 */
>> + BIO *mem = BIO_new_mem_buf((void *)pem_str, -1);
>> +#else
>> BIO *mem = BIO_new_mem_buf(pem_str, -1);
>> +#endif
>> if (!mem) {
>> av_log(NULL, AV_LOG_ERROR, "BIO_new_mem_buf failed\n");
>> return NULL;
>
> That's what I had in mind.
Thanks for your review!
If everything looks good, could you help merge this please?
>
> - Andreas
Best regards
Jack
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [FFmpeg-devel] [PATCH v3] avformat/tls_openssl: fix warnings when openssl is lower version
2025-06-17 14:07 ` Jack Lau
@ 2025-06-21 2:18 ` Jack Lau
2025-06-21 4:59 ` Zhao Zhili
0 siblings, 1 reply; 5+ messages in thread
From: Jack Lau @ 2025-06-21 2:18 UTC (permalink / raw)
To: FFmpeg development discussions and patches
> On Jun 17, 2025, at 22:07, Jack Lau <jacklau1222gm@gmail.com> wrote:
>
>
>
>> On Jun 15, 2025, at 23:54, Andreas Rheinhardt <andreas.rheinhardt@outlook.com> wrote:
>>
>> Jack Lau via ffmpeg-devel:
>>> diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
>>> index 86e8935fee..2a3905891d 100644
>>> --- a/libavformat/tls_openssl.c
>>> +++ b/libavformat/tls_openssl.c
>>> @@ -415,7 +415,11 @@ error:
>>> */
>>> static EVP_PKEY *pkey_from_pem_string(const char *pem_str, int is_priv)
>>> {
>>> +#if OPENSSL_VERSION_NUMBER < 0x10002000L /* OpenSSL 1.0.2 */
>>> + BIO *mem = BIO_new_mem_buf((void *)pem_str, -1);
>>> +#else
>>> BIO *mem = BIO_new_mem_buf(pem_str, -1);
>>> +#endif
>>> if (!mem) {
>>> av_log(NULL, AV_LOG_ERROR, "BIO_new_mem_buf failed\n");
>>> return NULL;
>>> @@ -445,7 +449,11 @@ static EVP_PKEY *pkey_from_pem_string(const char *pem_str, int is_priv)
>>> */
>>> static X509 *cert_from_pem_string(const char *pem_str)
>>> {
>>> +#if OPENSSL_VERSION_NUMBER < 0x10002000L /* OpenSSL 1.0.2 */
>>> + BIO *mem = BIO_new_mem_buf((void *)pem_str, -1);
>>> +#else
>>> BIO *mem = BIO_new_mem_buf(pem_str, -1);
>>> +#endif
>>> if (!mem) {
>>> av_log(NULL, AV_LOG_ERROR, "BIO_new_mem_buf failed\n");
>>> return NULL;
>>
>> That's what I had in mind.
> Thanks for your review!
> If everything looks good, could you help merge this please?
>>
>> - Andreas
> Best regards
> Jack
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org <mailto:ffmpeg-devel@ffmpeg.org>
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org <mailto:ffmpeg-devel-request@ffmpeg.org> with subject "unsubscribe”.
PING.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [FFmpeg-devel] [PATCH v3] avformat/tls_openssl: fix warnings when openssl is lower version
2025-06-21 2:18 ` Jack Lau
@ 2025-06-21 4:59 ` Zhao Zhili
0 siblings, 0 replies; 5+ messages in thread
From: Zhao Zhili @ 2025-06-21 4:59 UTC (permalink / raw)
To: FFmpeg development discussions and patches
> On Jun 21, 2025, at 10:18, Jack Lau <jacklau1222gm-at-gmail.com@ffmpeg.org> wrote:
>
>
>
>> On Jun 17, 2025, at 22:07, Jack Lau <jacklau1222gm@gmail.com <mailto:jacklau1222gm@gmail.com>> wrote:
>>
>>
>>
>>> On Jun 15, 2025, at 23:54, Andreas Rheinhardt <andreas.rheinhardt@outlook.com> wrote:
>>>
>>> Jack Lau via ffmpeg-devel:
>>>> diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
>>>> index 86e8935fee..2a3905891d 100644
>>>> --- a/libavformat/tls_openssl.c
>>>> +++ b/libavformat/tls_openssl.c
>>>> @@ -415,7 +415,11 @@ error:
>>>> */
>>>> static EVP_PKEY *pkey_from_pem_string(const char *pem_str, int is_priv)
>>>> {
>>>> +#if OPENSSL_VERSION_NUMBER < 0x10002000L /* OpenSSL 1.0.2 */
>>>> + BIO *mem = BIO_new_mem_buf((void *)pem_str, -1);
>>>> +#else
>>>> BIO *mem = BIO_new_mem_buf(pem_str, -1);
>>>> +#endif
>>>> if (!mem) {
>>>> av_log(NULL, AV_LOG_ERROR, "BIO_new_mem_buf failed\n");
>>>> return NULL;
>>>> @@ -445,7 +449,11 @@ static EVP_PKEY *pkey_from_pem_string(const char *pem_str, int is_priv)
>>>> */
>>>> static X509 *cert_from_pem_string(const char *pem_str)
>>>> {
>>>> +#if OPENSSL_VERSION_NUMBER < 0x10002000L /* OpenSSL 1.0.2 */
>>>> + BIO *mem = BIO_new_mem_buf((void *)pem_str, -1);
>>>> +#else
>>>> BIO *mem = BIO_new_mem_buf(pem_str, -1);
>>>> +#endif
>>>> if (!mem) {
>>>> av_log(NULL, AV_LOG_ERROR, "BIO_new_mem_buf failed\n");
>>>> return NULL;
>>>
>>> That's what I had in mind.
>> Thanks for your review!
>> If everything looks good, could you help merge this please?
>>>
>>> - Andreas
>> Best regards
>> Jack
>>>
>>> _______________________________________________
>>> ffmpeg-devel mailing list
>>> ffmpeg-devel@ffmpeg.org <mailto:ffmpeg-devel@ffmpeg.org> <mailto:ffmpeg-devel@ffmpeg.org>
>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>>
>>> To unsubscribe, visit link above, or email
>>> ffmpeg-devel-request@ffmpeg.org <mailto:ffmpeg-devel-request@ffmpeg.org> <mailto:ffmpeg-devel-request@ffmpeg.org> with subject "unsubscribe”.
> PING.
Applied, thanks.
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org <mailto:ffmpeg-devel@ffmpeg.org>
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org <mailto:ffmpeg-devel-request@ffmpeg.org> with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-06-21 5:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-06-15 15:15 [FFmpeg-devel] [PATCH v3] avformat/tls_openssl: fix warnings when openssl is lower version Jack Lau via ffmpeg-devel
2025-06-15 15:54 ` Andreas Rheinhardt
2025-06-17 14:07 ` Jack Lau
2025-06-21 2:18 ` Jack Lau
2025-06-21 4:59 ` Zhao Zhili
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git