From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 10F0E4C179 for ; Wed, 30 Jul 2025 08:24:33 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 0833368BA65; Wed, 30 Jul 2025 11:24:29 +0300 (EEST) Received: from out162-62-57-49.mail.qq.com (out162-62-57-49.mail.qq.com [162.62.57.49]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id E86B068B4E4 for ; Wed, 30 Jul 2025 11:24:21 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1753863858; bh=Tql9IIXf/4JycasGLjbEVermNSaJUlHItFWujsgs9iw=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=zRhqsHhmU8X89HuO+Ea5cwinpgFICWxxoc9CZEdhyy9tc6la8lG0PIanx5Y5xqp7w z1QGEs56oreGNJ1Y1zsTswR7CEd4HZyr7f9QBnXdERJ0D7y0lLvMIj2MkDEH0opl5g NoJGJu0WyHi/Gg0fNJPn7KViBm+Hz6s3KQ1RweC0= Received: from smtpclient.apple ([119.147.10.242]) by newxmesmtplogicsvrszc13-0.qq.com (NewEsmtp) with SMTP id 48D130DB; Wed, 30 Jul 2025 16:18:13 +0800 X-QQ-mid: xmsmtpt1753863493thqi1u9wy Message-ID: X-QQ-XMAILINFO: MTEqvtFah3ZeJOFh+wuVvpNXxZKn0sUqB/s+DJeIJZyFitukX3JAE5o+F6z0Ze GkzePVw9YsxapgcMNPH03jEII65jSVM5WnvzcYdL5teQT+fsv+IjUOYf2aYEnUsZ38CulLMgQG8m HrZk0BdQ9WTC1kQ8lHKtnNpd1ymLg27/4ml5HgD695M5FOGMkjOSzbMWkSAkkaSL2ZlIJM6y0n7R xhXeqhiGVXY3SdqKWv02J6GpYVm9yjId/WojCY20h1LI6prnFWbbpSqXcxwYL/tyEbBJNxX4o8OK p9ENyHARkAO29fgfa4n38V1MFuDAniAS+gIgVaYQ2cDhDQvzFriVClAMtONI0zX1NIWvFiYaLim8 8XrhiEdUoz5pVcFX6DUNtF5b1ILM1hhOaUVJ+buukX7C2+xQEFq9MLjve+qNzBlNxskyIH1WE979 57725F0Z7XH28WuiJJsNq5xpDcoLee/JuLDJF8Sr4DDB2RHGtHsC8Rptxs/idam5+GPBnwIu+Pse gaodG6hfXTSOdk2LGNpQN1yjnmk0JRnHyS8lh7WZPuFMn+niN6N/WfHe9tjtokVAMjQd52XCGOVZ sUVX4UrjVqrC8fAOxIodfyo1qRoAvOI8GNYwzm0bHihMGP32kp32bzCmzjh9wfTKhbxjFTS/8kDe oYxVIl4OzTqkLM13Q5KCtkZKHZ3xhDY8W33gL6OPg78tnHV2dVGL4HE1g2+bSk0rcKUeBZOjrE/j LyCjwRVP8zFSSvh9NFAefzG5pek0YKnaCypP9KxweJius/iK2OjQvMoz7mel0H6tiMGhhNlKL1S5 9LlewJK5O1+oSdBXf+TKkVcWyjHbUgmI6AF+ZBhn6f7GrdkY0x9vT8F2+jcxpVgoBI10OUn05XKK J680NRwlNRUPuLOC+nJWIMEPkpMXUZ3rnKoAMKO+PPIT2MbE4grdJI8IXng1aewkpwgdXvJxUw6P KkvQ6Xba5KrKwKD545qFMkh4NwSbNSDOYwqANymkLasZXMDa1wuHqRUQTu6+dDcl9kbKH/GLk9/L rXLgX8M8Hrb0XhOAZflKfiLkxkDD8heLcNQrpCVn9k184+eCxm X-QQ-XMRINFO: OD9hHCdaPRBwq3WW+NvGbIU= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.500.181.1.5\)) From: Zhao Zhili In-Reply-To: <20250730034324.2651040-1-caifan0425@163.com> Date: Wed, 30 Jul 2025 16:18:02 +0800 X-OQ-MSGID: <101A16E2-016A-4C42-8533-D7C81DADA0F8@foxmail.com> References: <20250730034324.2651040-1-caifan0425@163.com> To: FFmpeg development discussions and patches X-Mailer: Apple Mail (2.3826.500.181.1.5) Subject: Re: [FFmpeg-devel] =?utf-8?q?=5BPATCH_1/1=5D_libavformat/img2enc=2Ec?= =?utf-8?q?=3A_rm_warning_=E2=80=98=2Etmp=E2=80=99_directive_output_may_be?= =?utf-8?q?_truncated?= X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Cai Fan Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Jul 30, 2025, at 11:43, Cai Fan wrote: > > Signed-off-by: Cai Fan > --- > libavformat/img2enc.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/libavformat/img2enc.c b/libavformat/img2enc.c > index 41638d92b8..f7d983ec54 100644 > --- a/libavformat/img2enc.c > +++ b/libavformat/img2enc.c > @@ -180,6 +180,11 @@ static int write_packet(AVFormatContext *s, AVPacket *pkt) > } > for (i = 0; i < 4; i++) { > av_dict_copy(&options, img->protocol_opts, 0); > + if (strlen(filename) + 5 >= sizeof(img->tmp[i])) { > + av_log(s, AV_LOG_ERROR, "Filename too long: %s\n", filename); > + ret = AVERROR(EINVAL); > + goto fail; > + } > snprintf(img->tmp[i], sizeof(img->tmp[i]), "%s.tmp", filename); The return value of snprintf can be used to detect truncation. Use strlen before snprintf makes no sense. > av_strlcpy(img->target[i], filename, sizeof(img->target[i])); > if (s->io_open(s, &pb[i], img->use_rename ? img->tmp[i] : filename, AVIO_FLAG_WRITE, &options) < 0) { > -- > 2.34.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".