From: Zhao Zhili <quinkblack@foxmail.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Zhao Zhili <zhilizhao@tencent.com>
Subject: [FFmpeg-devel] [PATCH 4/6] avcodec/filter_units_bsf: add skip frame support
Date: Thu, 18 May 2023 05:23:41 +0800
Message-ID: <tencent_072737B8FB1624CD76A0114D984FB5D57707@qq.com> (raw)
In-Reply-To: <20230517212343.1874354-1-quinkblack@foxmail.com>
From: Zhao Zhili <zhilizhao@tencent.com>
---
libavcodec/filter_units_bsf.c | 42 +++++++++++++++++++++++++++++++++--
libavcodec/version.h | 2 +-
2 files changed, 41 insertions(+), 3 deletions(-)
diff --git a/libavcodec/filter_units_bsf.c b/libavcodec/filter_units_bsf.c
index 38756baf42..e4c2cadbd5 100644
--- a/libavcodec/filter_units_bsf.c
+++ b/libavcodec/filter_units_bsf.c
@@ -34,6 +34,8 @@ typedef struct FilterUnitsContext {
const char *pass_types;
const char *remove_types;
+ enum AVDiscard discard;
+ int discard_flags;
enum {
NOOP,
@@ -109,7 +111,7 @@ static int filter_units_filter(AVBSFContext *bsf, AVPacket *pkt)
if (err < 0)
return err;
- if (ctx->mode == NOOP)
+ if (ctx->mode == NOOP && ctx->discard <= AVDISCARD_DEFAULT)
return 0;
err = ff_cbs_read_packet(ctx->cbc, frag, pkt);
@@ -118,6 +120,8 @@ static int filter_units_filter(AVBSFContext *bsf, AVPacket *pkt)
goto fail;
}
+ ff_cbs_discard_units(ctx->cbc, frag, ctx->discard, ctx->discard_flags);
+ if (ctx->mode != NOOP) {
for (i = frag->nb_units - 1; i >= 0; i--) {
for (j = 0; j < ctx->nb_types; j++) {
if (frag->units[i].type == ctx->type_list[j])
@@ -127,6 +131,7 @@ static int filter_units_filter(AVBSFContext *bsf, AVPacket *pkt)
: j >= ctx->nb_types)
ff_cbs_delete_unit(frag, i);
}
+ }
if (frag->nb_units == 0) {
// Don't return packets with nothing in them.
@@ -175,7 +180,7 @@ static int filter_units_init(AVBSFContext *bsf)
av_log(bsf, AV_LOG_ERROR, "Failed to parse remove_types.\n");
return err;
}
- } else {
+ } else if (ctx->discard == AVDISCARD_NONE) {
return 0;
}
@@ -183,9 +188,11 @@ static int filter_units_init(AVBSFContext *bsf)
if (err < 0)
return err;
+ if (ctx->discard == AVDISCARD_NONE) {
// Don't actually decompose anything, we only want the unit data.
ctx->cbc->decompose_unit_types = ctx->type_list;
ctx->cbc->nb_decompose_unit_types = 0;
+ }
if (bsf->par_in->extradata) {
CodedBitstreamFragment *frag = &ctx->fragment;
@@ -225,6 +232,37 @@ static const AVOption filter_units_options[] = {
OFFSET(remove_types), AV_OPT_TYPE_STRING,
{ .str = NULL }, .flags = FLAGS },
+ { "discard", "Remove the selected frames",
+ OFFSET(discard), AV_OPT_TYPE_INT,
+ { .i64 = AVDISCARD_NONE }, INT_MIN, INT_MAX, FLAGS, "discard"},
+ { "none" , "discard none",
+ 0, AV_OPT_TYPE_CONST,
+ { .i64 = AVDISCARD_NONE }, INT_MIN, INT_MAX, FLAGS, "discard"},
+ { "default" , "discard none, but can be changed after dynamically",
+ 0, AV_OPT_TYPE_CONST,
+ { .i64 = AVDISCARD_DEFAULT }, INT_MIN, INT_MAX, FLAGS, "discard"},
+ { "nonref", "discard all non-reference frames",
+ 0, AV_OPT_TYPE_CONST,
+ { .i64 = AVDISCARD_NONREF }, INT_MIN, INT_MAX, FLAGS, "discard"},
+ { "bidir", "discard all bidirectional frames",
+ 0, AV_OPT_TYPE_CONST,
+ { .i64 = AVDISCARD_BIDIR }, INT_MIN, INT_MAX, FLAGS, "discard"},
+ { "nonintra", "discard all frames except I frames",
+ 0, AV_OPT_TYPE_CONST,
+ { .i64 = AVDISCARD_NONINTRA }, INT_MIN, INT_MAX, FLAGS, "discard"},
+ { "nonkey", "discard all frames except keyframes",
+ 0, AV_OPT_TYPE_CONST,
+ { .i64 = AVDISCARD_NONKEY }, INT_MIN, INT_MAX, FLAGS, "discard"},
+ { "all", "discard all frames",
+ 0, AV_OPT_TYPE_CONST,
+ { .i64 = AVDISCARD_ALL }, INT_MIN, INT_MAX, FLAGS, "discard"},
+
+ { "discard_flags", "flags to control the discard frame behavior",
+ OFFSET(discard_flags), AV_OPT_TYPE_FLAGS,
+ { .i64 = DISCARD_FLAG_NONE }, INT_MIN, INT_MAX, FLAGS, "discard_flags"},
+ { "keep_non_vcl", "non-vcl units even if the picture has been dropped",
+ 0, AV_OPT_TYPE_CONST,
+ { .i64 = DISCARD_FLAG_KEEP_NON_VCL }, INT_MIN, INT_MAX, FLAGS, "discard_flags"},
{ NULL }
};
diff --git a/libavcodec/version.h b/libavcodec/version.h
index 7531c6c42a..c20072197d 100644
--- a/libavcodec/version.h
+++ b/libavcodec/version.h
@@ -30,7 +30,7 @@
#include "version_major.h"
#define LIBAVCODEC_VERSION_MINOR 14
-#define LIBAVCODEC_VERSION_MICRO 100
+#define LIBAVCODEC_VERSION_MICRO 101
#define LIBAVCODEC_VERSION_INT AV_VERSION_INT(LIBAVCODEC_VERSION_MAJOR, \
LIBAVCODEC_VERSION_MINOR, \
--
2.25.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-05-17 13:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230517212343.1874354-1-quinkblack@foxmail.com>
2023-05-17 21:23 ` [FFmpeg-devel] [PATCH 2/6] avcodec/cbs_h2645: add discarded_unit implementation for H.264 Zhao Zhili
2023-05-17 21:23 ` [FFmpeg-devel] [PATCH 3/6] avcodec/cbs_h2645: add discard_unit implementation for H.265 Zhao Zhili
2023-05-17 21:23 ` Zhao Zhili [this message]
2023-05-17 21:23 ` [FFmpeg-devel] [PATCH 5/6] avcodec/filter_units_bsf: reindent after previous commit Zhao Zhili
2023-05-17 21:23 ` [FFmpeg-devel] [PATCH 6/6] fate/cbs: add tests for discard_units Zhao Zhili
2023-05-18 13:33 ` Zhao Zhili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_072737B8FB1624CD76A0114D984FB5D57707@qq.com \
--to=quinkblack@foxmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=zhilizhao@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git