Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: =?gb18030?B?0Oy4o8Kh?= <839789740@qq.com>
To: =?gb18030?B?RkZtcGVnIGRldmVsb3BtZW50IGRpc2N1c3Npb25zIGFuZCBwYXRjaGVz?=
	<ffmpeg-devel@ffmpeg.org>
Cc: =?gb18030?B?InpoaWxpemhhbyjV1Na+waIpIg==?=
	<quinkblack@foxmail.com>,
	=?gb18030?B?UmljayBLZXJu?= <kernrj@gmail.com>
Subject: [FFmpeg-devel] =?gb18030?b?u9i4tKO6ICBbUEFUQ0hdIGF2Y29kZWMvdmlk?= =?gb18030?q?eotoolboxenc=3A_replace_VT=5FH264Profile_with_avctx_profile?=
Date: Mon, 22 May 2023 12:17:07 +0800
Message-ID: <tencent_0638FB27C68811009C367B2C0F68D94A4805@qq.com> (raw)
In-Reply-To: <tencent_64E4D50A2753389F16444D0D206ACDC14F07@qq.com>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb18030", Size: 28932 bytes --]

It's my mistake that forget to remove H264_PROF_AUTO. I will fix that.
Any other suggestions about the profile_options? Thanks.


------------------&nbsp;ԭʼÓʼþ&nbsp;------------------
·¢¼þÈË:                                                                                                                        ""zhilizhao(ÕÔÖ¾Á¢)""                                                                                    <quinkblack@foxmail.com&gt;;
·¢ËÍʱ¼ä:&nbsp;2023Äê5ÔÂ22ÈÕ(ÐÇÆÚÒ») ÖÐÎç11:11
ÊÕ¼þÈË:&nbsp;"FFmpeg development discussions and patches"<ffmpeg-devel@ffmpeg.org&gt;;
³­ËÍ:&nbsp;"Ð츣¡"<839789740@qq.com&gt;;"Rick Kern"<kernrj@gmail.com&gt;;
Ö÷Ìâ:&nbsp;Re: [FFmpeg-devel] [PATCH] avcodec/videotoolboxenc: replace VT_H264Profile with avctx profile





&gt; On May 22, 2023, at 11:05, zhilizhao(ÕÔÖ¾Á¢) <quinkblack@foxmail.com&gt; wrote:
&gt; 
&gt;&gt; On May 21, 2023, at 22:41, xufuji456 <839789740@qq.com&gt; wrote:
&gt;&gt; 
&gt;&gt; For compatibility with constrained_baseline in the future,
&gt;&gt; replace VT_H264Profile/VT_HEVCProfile with avctx-&gt;profile.
&gt;&gt; 
&gt;&gt; Signed-off-by: xufuji456 <839789740@qq.com&gt;
&gt;&gt; ---
&gt;&gt; libavcodec/videotoolboxenc.c | 55 +++++++++++-------------------------
&gt;&gt; 1 file changed, 16 insertions(+), 39 deletions(-)
&gt;&gt; 
&gt;&gt; diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
&gt;&gt; index b017c90c36..4966ab36ae 100644
&gt;&gt; --- a/libavcodec/videotoolboxenc.c
&gt;&gt; +++ b/libavcodec/videotoolboxenc.c
&gt;&gt; @@ -190,28 +190,12 @@ static void loadVTEncSymbols(void){
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; "EnableLowLatencyRateControl");
&gt;&gt; }
&gt;&gt; 
&gt;&gt; -typedef enum VT_H264Profile {
&gt;&gt; -&nbsp;&nbsp;&nbsp; H264_PROF_AUTO,
&gt;&gt; -&nbsp;&nbsp;&nbsp; H264_PROF_BASELINE,
&gt;&gt; -&nbsp;&nbsp;&nbsp; H264_PROF_MAIN,
&gt;&gt; -&nbsp;&nbsp;&nbsp; H264_PROF_HIGH,
&gt;&gt; -&nbsp;&nbsp;&nbsp; H264_PROF_EXTENDED,
&gt;&gt; -&nbsp;&nbsp;&nbsp; H264_PROF_COUNT
&gt;&gt; -} VT_H264Profile;
&gt;&gt; -
&gt;&gt; typedef enum VTH264Entropy{
&gt;&gt;&nbsp;&nbsp;&nbsp; VT_ENTROPY_NOT_SET,
&gt;&gt;&nbsp;&nbsp;&nbsp; VT_CAVLC,
&gt;&gt;&nbsp;&nbsp;&nbsp; VT_CABAC
&gt;&gt; } VTH264Entropy;
&gt;&gt; 
&gt;&gt; -typedef enum VT_HEVCProfile {
&gt;&gt; -&nbsp;&nbsp;&nbsp; HEVC_PROF_AUTO,
&gt;&gt; -&nbsp;&nbsp;&nbsp; HEVC_PROF_MAIN,
&gt;&gt; -&nbsp;&nbsp;&nbsp; HEVC_PROF_MAIN10,
&gt;&gt; -&nbsp;&nbsp;&nbsp; HEVC_PROF_COUNT
&gt;&gt; -} VT_HEVCProfile;
&gt;&gt; -
&gt;&gt; static const uint8_t start_code[] = { 0, 0, 0, 1 };
&gt;&gt; 
&gt;&gt; typedef struct ExtraSEI {
&gt;&gt; @@ -730,18 +714,13 @@ static bool get_vt_h264_profile_level(AVCodecContext *avctx,
&gt;&gt;&nbsp;&nbsp;&nbsp; VTEncContext *vtctx = avctx-&gt;priv_data;
&gt;&gt;&nbsp;&nbsp;&nbsp; int64_t profile = vtctx-&gt;profile;
&gt;&gt; 
&gt;&gt; -&nbsp;&nbsp;&nbsp; if (profile == H264_PROF_AUTO &amp;&amp; vtctx-&gt;level) {
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; //Need to pick a profile if level is not auto-selected.
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; profile = vtctx-&gt;has_b_frames ? H264_PROF_MAIN : H264_PROF_BASELINE;
&gt;&gt; -&nbsp;&nbsp;&nbsp; }
&gt;&gt; -
&gt;&gt;&nbsp;&nbsp;&nbsp; *profile_level_val = NULL;
&gt;&gt; 
&gt;&gt;&nbsp;&nbsp;&nbsp; switch (profile) {
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case H264_PROF_AUTO:
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; return true;

Isn¡¯t it failed to build since H264_PROF_AUTO isn¡¯t defined?

&gt;&gt; 
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case H264_PROF_BASELINE:
&gt;&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case FF_PROFILE_H264_BASELINE:
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; switch (vtctx-&gt;level) {
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case&nbsp; 0: *profile_level_val =
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; compat_keys.kVTProfileLevel_H264_Baseline_AutoLevel; break;
&gt;&gt; @@ -763,7 +742,7 @@ static bool get_vt_h264_profile_level(AVCodecContext *avctx,
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; break;
&gt;&gt; 
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case H264_PROF_MAIN:
&gt;&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case FF_PROFILE_H264_MAIN:
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; switch (vtctx-&gt;level) {
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case&nbsp; 0: *profile_level_val =
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; compat_keys.kVTProfileLevel_H264_Main_AutoLevel; break;
&gt;&gt; @@ -782,7 +761,7 @@ static bool get_vt_h264_profile_level(AVCodecContext *avctx,
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; break;
&gt;&gt; 
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case H264_PROF_HIGH:
&gt;&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case FF_PROFILE_H264_HIGH:
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; switch (vtctx-&gt;level) {
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case&nbsp; 0: *profile_level_val =
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; compat_keys.kVTProfileLevel_H264_High_AutoLevel; break;
&gt;&gt; @@ -805,7 +784,7 @@ static bool get_vt_h264_profile_level(AVCodecContext *avctx,
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; compat_keys.kVTProfileLevel_H264_High_5_2;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; break;
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; break;
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case H264_PROF_EXTENDED:
&gt;&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case FF_PROFILE_H264_EXTENDED:
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; switch (vtctx-&gt;level) {
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case&nbsp; 0: *profile_level_val =
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; compat_keys.kVTProfileLevel_H264_Extended_AutoLevel; break;
&gt;&gt; @@ -838,13 +817,11 @@ static bool get_vt_hevc_profile_level(AVCodecContext *avctx,
&gt;&gt;&nbsp;&nbsp;&nbsp; *profile_level_val = NULL;
&gt;&gt; 
&gt;&gt;&nbsp;&nbsp;&nbsp; switch (profile) {
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case HEVC_PROF_AUTO:
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; return true;
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case HEVC_PROF_MAIN:
&gt;&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case FF_PROFILE_HEVC_MAIN:
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; *profile_level_val =
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; compat_keys.kVTProfileLevel_HEVC_Main_AutoLevel;
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; break;
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case HEVC_PROF_MAIN10:
&gt;&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case FF_PROFILE_HEVC_MAIN_10:
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; *profile_level_val =
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; compat_keys.kVTProfileLevel_HEVC_Main10_AutoLevel;
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; break;
&gt;&gt; @@ -1515,12 +1492,12 @@ static int vtenc_configure_encoder(AVCodecContext *avctx)
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; vtctx-&gt;get_param_set_func = CMVideoFormatDescriptionGetH264ParameterSetAtIndex;
&gt;&gt; 
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; vtctx-&gt;has_b_frames = avctx-&gt;max_b_frames &gt; 0;
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if(vtctx-&gt;has_b_frames &amp;&amp; vtctx-&gt;profile == H264_PROF_BASELINE){
&gt;&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if(vtctx-&gt;has_b_frames &amp;&amp; vtctx-&gt;profile == FF_PROFILE_H264_BASELINE) {
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; av_log(avctx, AV_LOG_WARNING, "Cannot use B-frames with baseline profile. Output will not contain B-frames.\n");
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; vtctx-&gt;has_b_frames = 0;
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }
&gt;&gt; 
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if (vtctx-&gt;entropy == VT_CABAC &amp;&amp; vtctx-&gt;profile == H264_PROF_BASELINE) {
&gt;&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if (vtctx-&gt;entropy == VT_CABAC &amp;&amp; vtctx-&gt;profile == FF_PROFILE_H264_BASELINE) {
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; av_log(avctx, AV_LOG_WARNING, "CABAC entropy requires 'main' or 'high' profile, but baseline was requested. Encode will not use CABAC entropy.\n");
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; vtctx-&gt;entropy = VT_ENTROPY_NOT_SET;
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }
&gt;&gt; @@ -2756,11 +2733,11 @@ static const enum AVPixelFormat prores_pix_fmts[] = {
&gt;&gt; 
&gt;&gt; #define OFFSET(x) offsetof(VTEncContext, x)
&gt;&gt; static const AVOption h264_options[] = {
&gt;&gt; -&nbsp;&nbsp;&nbsp; { "profile", "Profile", OFFSET(profile), AV_OPT_TYPE_INT64, { .i64 = H264_PROF_AUTO }, H264_PROF_AUTO, H264_PROF_COUNT, VE, "profile" },
&gt;&gt; -&nbsp;&nbsp;&nbsp; { "baseline", "Baseline Profile", 0, AV_OPT_TYPE_CONST, { .i64 = H264_PROF_BASELINE }, INT_MIN, INT_MAX, VE, "profile" },
&gt;&gt; -&nbsp;&nbsp;&nbsp; { "main",&nbsp;&nbsp;&nbsp;&nbsp; "Main Profile",&nbsp;&nbsp;&nbsp;&nbsp; 0, AV_OPT_TYPE_CONST, { .i64 = H264_PROF_MAIN&nbsp;&nbsp;&nbsp;&nbsp; }, INT_MIN, INT_MAX, VE, "profile" },
&gt;&gt; -&nbsp;&nbsp;&nbsp; { "high",&nbsp;&nbsp;&nbsp;&nbsp; "High Profile",&nbsp;&nbsp;&nbsp;&nbsp; 0, AV_OPT_TYPE_CONST, { .i64 = H264_PROF_HIGH&nbsp;&nbsp;&nbsp;&nbsp; }, INT_MIN, INT_MAX, VE, "profile" },
&gt;&gt; -&nbsp;&nbsp;&nbsp; { "extended", "Extend Profile",&nbsp;&nbsp; 0, AV_OPT_TYPE_CONST, { .i64 = H264_PROF_EXTENDED }, INT_MIN, INT_MAX, VE, "profile" },
&gt;&gt; +&nbsp;&nbsp;&nbsp; { "profile", "Profile", OFFSET(profile), AV_OPT_TYPE_INT64, { .i64 = FF_PROFILE_H264_BASELINE }, FF_PROFILE_H264_BASELINE, FF_PROFILE_H264_HIGH, VE, "profile" },
&gt;&gt; +&nbsp;&nbsp;&nbsp; { "baseline", "Baseline Profile", 0, AV_OPT_TYPE_CONST, { .i64 = FF_PROFILE_H264_BASELINE }, INT_MIN, INT_MAX, VE, "profile" },
&gt;&gt; +&nbsp;&nbsp;&nbsp; { "main",&nbsp;&nbsp;&nbsp;&nbsp; "Main Profile",&nbsp;&nbsp;&nbsp;&nbsp; 0, AV_OPT_TYPE_CONST, { .i64 = FF_PROFILE_H264_MAIN&nbsp;&nbsp;&nbsp;&nbsp; }, INT_MIN, INT_MAX, VE, "profile" },
&gt;&gt; +&nbsp;&nbsp;&nbsp; { "extended", "Extend Profile",&nbsp;&nbsp; 0, AV_OPT_TYPE_CONST, { .i64 = FF_PROFILE_H264_EXTENDED }, INT_MIN, INT_MAX, VE, "profile" },
&gt;&gt; +&nbsp;&nbsp;&nbsp; { "high",&nbsp;&nbsp;&nbsp;&nbsp; "High Profile",&nbsp;&nbsp;&nbsp;&nbsp; 0, AV_OPT_TYPE_CONST, { .i64 = FF_PROFILE_H264_HIGH&nbsp;&nbsp;&nbsp;&nbsp; }, INT_MIN, INT_MAX, VE, "profile" },
&gt; 
&gt; Firstly, it breaks use case which set the option by number like -profile 1.
&gt; 
&gt; Secondly, it changes the default profile to baseline. I don¡¯t think it¡¯s a
&gt; good idea.
&gt; 
&gt;&gt; 
&gt;&gt;&nbsp;&nbsp;&nbsp; { "level", "Level", OFFSET(level), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 52, VE, "level" },
&gt;&gt;&nbsp;&nbsp;&nbsp; { "1.3", "Level 1.3, only available with Baseline Profile", 0, AV_OPT_TYPE_CONST, { .i64 = 13 }, INT_MIN, INT_MAX, VE, "level" },
&gt;&gt; @@ -2811,9 +2788,9 @@ const FFCodec ff_h264_videotoolbox_encoder = {
&gt;&gt; };
&gt;&gt; 
&gt;&gt; static const AVOption hevc_options[] = {
&gt;&gt; -&nbsp;&nbsp;&nbsp; { "profile", "Profile", OFFSET(profile), AV_OPT_TYPE_INT64, { .i64 = HEVC_PROF_AUTO }, HEVC_PROF_AUTO, HEVC_PROF_COUNT, VE, "profile" },
&gt;&gt; -&nbsp;&nbsp;&nbsp; { "main",&nbsp;&nbsp;&nbsp;&nbsp; "Main Profile",&nbsp;&nbsp;&nbsp;&nbsp; 0, AV_OPT_TYPE_CONST, { .i64 = HEVC_PROF_MAIN&nbsp;&nbsp; }, INT_MIN, INT_MAX, VE, "profile" },
&gt;&gt; -&nbsp;&nbsp;&nbsp; { "main10",&nbsp;&nbsp; "Main10 Profile",&nbsp;&nbsp; 0, AV_OPT_TYPE_CONST, { .i64 = HEVC_PROF_MAIN10 }, INT_MIN, INT_MAX, VE, "profile" },
&gt;&gt; +&nbsp;&nbsp;&nbsp; { "profile", "Profile", OFFSET(profile), AV_OPT_TYPE_INT64, { .i64 = FF_PROFILE_HEVC_MAIN }, FF_PROFILE_HEVC_MAIN, FF_PROFILE_HEVC_MAIN_10, VE, "profile" },
&gt;&gt; +&nbsp;&nbsp;&nbsp; { "main",&nbsp;&nbsp;&nbsp;&nbsp; "Main Profile",&nbsp;&nbsp;&nbsp;&nbsp; 0, AV_OPT_TYPE_CONST, { .i64 = FF_PROFILE_HEVC_MAIN&nbsp;&nbsp;&nbsp; }, INT_MIN, INT_MAX, VE, "profile" },
&gt;&gt; +&nbsp;&nbsp;&nbsp; { "main10",&nbsp;&nbsp; "Main10 Profile",&nbsp;&nbsp; 0, AV_OPT_TYPE_CONST, { .i64 = FF_PROFILE_HEVC_MAIN_10 }, INT_MIN, INT_MAX, VE, "profile" },
&gt;&gt; 
&gt;&gt;&nbsp;&nbsp;&nbsp; { "alpha_quality", "Compression quality for the alpha channel", OFFSET(alpha_quality), AV_OPT_TYPE_DOUBLE, { .dbl = 0.0 }, 0.0, 1.0, VE },
&gt;&gt; 
&gt;&gt; -- 
&gt;&gt; 2.32.0 (Apple Git-132)
&gt;&gt; 
&gt;&gt; _______________________________________________
&gt;&gt; ffmpeg-devel mailing list
&gt;&gt; ffmpeg-devel@ffmpeg.org
&gt;&gt; https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
&gt;&gt; 
&gt;&gt; To unsubscribe, visit link above, or email
&gt;&gt; ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
&gt; 
&gt;&gt; On May 21, 2023, at 22:41, xufuji456 <839789740@qq.com&gt; wrote:
&gt;&gt; 
&gt;&gt; For compatibility with constrained_baseline in the future,
&gt;&gt; replace VT_H264Profile/VT_HEVCProfile with avctx-&gt;profile.
&gt;&gt; 
&gt;&gt; Signed-off-by: xufuji456 <839789740@qq.com&gt;
&gt;&gt; ---
&gt;&gt; libavcodec/videotoolboxenc.c | 55 +++++++++++-------------------------
&gt;&gt; 1 file changed, 16 insertions(+), 39 deletions(-)
&gt;&gt; 
&gt;&gt; diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
&gt;&gt; index b017c90c36..4966ab36ae 100644
&gt;&gt; --- a/libavcodec/videotoolboxenc.c
&gt;&gt; +++ b/libavcodec/videotoolboxenc.c
&gt;&gt; @@ -190,28 +190,12 @@ static void loadVTEncSymbols(void){
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; "EnableLowLatencyRateControl");
&gt;&gt; }
&gt;&gt; 
&gt;&gt; -typedef enum VT_H264Profile {
&gt;&gt; -&nbsp;&nbsp;&nbsp; H264_PROF_AUTO,
&gt;&gt; -&nbsp;&nbsp;&nbsp; H264_PROF_BASELINE,
&gt;&gt; -&nbsp;&nbsp;&nbsp; H264_PROF_MAIN,
&gt;&gt; -&nbsp;&nbsp;&nbsp; H264_PROF_HIGH,
&gt;&gt; -&nbsp;&nbsp;&nbsp; H264_PROF_EXTENDED,
&gt;&gt; -&nbsp;&nbsp;&nbsp; H264_PROF_COUNT
&gt;&gt; -} VT_H264Profile;
&gt;&gt; -
&gt;&gt; typedef enum VTH264Entropy{
&gt;&gt;&nbsp;&nbsp;&nbsp; VT_ENTROPY_NOT_SET,
&gt;&gt;&nbsp;&nbsp;&nbsp; VT_CAVLC,
&gt;&gt;&nbsp;&nbsp;&nbsp; VT_CABAC
&gt;&gt; } VTH264Entropy;
&gt;&gt; 
&gt;&gt; -typedef enum VT_HEVCProfile {
&gt;&gt; -&nbsp;&nbsp;&nbsp; HEVC_PROF_AUTO,
&gt;&gt; -&nbsp;&nbsp;&nbsp; HEVC_PROF_MAIN,
&gt;&gt; -&nbsp;&nbsp;&nbsp; HEVC_PROF_MAIN10,
&gt;&gt; -&nbsp;&nbsp;&nbsp; HEVC_PROF_COUNT
&gt;&gt; -} VT_HEVCProfile;
&gt;&gt; -
&gt;&gt; static const uint8_t start_code[] = { 0, 0, 0, 1 };
&gt;&gt; 
&gt;&gt; typedef struct ExtraSEI {
&gt;&gt; @@ -730,18 +714,13 @@ static bool get_vt_h264_profile_level(AVCodecContext *avctx,
&gt;&gt;&nbsp;&nbsp;&nbsp; VTEncContext *vtctx = avctx-&gt;priv_data;
&gt;&gt;&nbsp;&nbsp;&nbsp; int64_t profile = vtctx-&gt;profile;
&gt;&gt; 
&gt;&gt; -&nbsp;&nbsp;&nbsp; if (profile == H264_PROF_AUTO &amp;&amp; vtctx-&gt;level) {
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; //Need to pick a profile if level is not auto-selected.
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; profile = vtctx-&gt;has_b_frames ? H264_PROF_MAIN : H264_PROF_BASELINE;
&gt;&gt; -&nbsp;&nbsp;&nbsp; }
&gt;&gt; -
&gt;&gt;&nbsp;&nbsp;&nbsp; *profile_level_val = NULL;
&gt;&gt; 
&gt;&gt;&nbsp;&nbsp;&nbsp; switch (profile) {
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case H264_PROF_AUTO:
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; return true;
&gt;&gt; 
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case H264_PROF_BASELINE:
&gt;&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case FF_PROFILE_H264_BASELINE:
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; switch (vtctx-&gt;level) {
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case&nbsp; 0: *profile_level_val =
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; compat_keys.kVTProfileLevel_H264_Baseline_AutoLevel; break;
&gt;&gt; @@ -763,7 +742,7 @@ static bool get_vt_h264_profile_level(AVCodecContext *avctx,
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; break;
&gt;&gt; 
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case H264_PROF_MAIN:
&gt;&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case FF_PROFILE_H264_MAIN:
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; switch (vtctx-&gt;level) {
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case&nbsp; 0: *profile_level_val =
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; compat_keys.kVTProfileLevel_H264_Main_AutoLevel; break;
&gt;&gt; @@ -782,7 +761,7 @@ static bool get_vt_h264_profile_level(AVCodecContext *avctx,
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; break;
&gt;&gt; 
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case H264_PROF_HIGH:
&gt;&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case FF_PROFILE_H264_HIGH:
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; switch (vtctx-&gt;level) {
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case&nbsp; 0: *profile_level_val =
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; compat_keys.kVTProfileLevel_H264_High_AutoLevel; break;
&gt;&gt; @@ -805,7 +784,7 @@ static bool get_vt_h264_profile_level(AVCodecContext *avctx,
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; compat_keys.kVTProfileLevel_H264_High_5_2;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; break;
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; break;
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case H264_PROF_EXTENDED:
&gt;&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case FF_PROFILE_H264_EXTENDED:
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; switch (vtctx-&gt;level) {
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case&nbsp; 0: *profile_level_val =
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; compat_keys.kVTProfileLevel_H264_Extended_AutoLevel; break;
&gt;&gt; @@ -838,13 +817,11 @@ static bool get_vt_hevc_profile_level(AVCodecContext *avctx,
&gt;&gt;&nbsp;&nbsp;&nbsp; *profile_level_val = NULL;
&gt;&gt; 
&gt;&gt;&nbsp;&nbsp;&nbsp; switch (profile) {
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case HEVC_PROF_AUTO:
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; return true;
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case HEVC_PROF_MAIN:
&gt;&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case FF_PROFILE_HEVC_MAIN:
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; *profile_level_val =
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; compat_keys.kVTProfileLevel_HEVC_Main_AutoLevel;
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; break;
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case HEVC_PROF_MAIN10:
&gt;&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case FF_PROFILE_HEVC_MAIN_10:
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; *profile_level_val =
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; compat_keys.kVTProfileLevel_HEVC_Main10_AutoLevel;
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; break;
&gt;&gt; @@ -1515,12 +1492,12 @@ static int vtenc_configure_encoder(AVCodecContext *avctx)
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; vtctx-&gt;get_param_set_func = CMVideoFormatDescriptionGetH264ParameterSetAtIndex;
&gt;&gt; 
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; vtctx-&gt;has_b_frames = avctx-&gt;max_b_frames &gt; 0;
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if(vtctx-&gt;has_b_frames &amp;&amp; vtctx-&gt;profile == H264_PROF_BASELINE){
&gt;&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if(vtctx-&gt;has_b_frames &amp;&amp; vtctx-&gt;profile == FF_PROFILE_H264_BASELINE) {
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; av_log(avctx, AV_LOG_WARNING, "Cannot use B-frames with baseline profile. Output will not contain B-frames.\n");
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; vtctx-&gt;has_b_frames = 0;
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }
&gt;&gt; 
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if (vtctx-&gt;entropy == VT_CABAC &amp;&amp; vtctx-&gt;profile == H264_PROF_BASELINE) {
&gt;&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if (vtctx-&gt;entropy == VT_CABAC &amp;&amp; vtctx-&gt;profile == FF_PROFILE_H264_BASELINE) {
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; av_log(avctx, AV_LOG_WARNING, "CABAC entropy requires 'main' or 'high' profile, but baseline was requested. Encode will not use CABAC entropy.\n");
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; vtctx-&gt;entropy = VT_ENTROPY_NOT_SET;
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }
&gt;&gt; @@ -2756,11 +2733,11 @@ static const enum AVPixelFormat prores_pix_fmts[] = {
&gt;&gt; 
&gt;&gt; #define OFFSET(x) offsetof(VTEncContext, x)
&gt;&gt; static const AVOption h264_options[] = {
&gt;&gt; -&nbsp;&nbsp;&nbsp; { "profile", "Profile", OFFSET(profile), AV_OPT_TYPE_INT64, { .i64 = H264_PROF_AUTO }, H264_PROF_AUTO, H264_PROF_COUNT, VE, "profile" },
&gt;&gt; -&nbsp;&nbsp;&nbsp; { "baseline", "Baseline Profile", 0, AV_OPT_TYPE_CONST, { .i64 = H264_PROF_BASELINE }, INT_MIN, INT_MAX, VE, "profile" },
&gt;&gt; -&nbsp;&nbsp;&nbsp; { "main",&nbsp;&nbsp;&nbsp;&nbsp; "Main Profile",&nbsp;&nbsp;&nbsp;&nbsp; 0, AV_OPT_TYPE_CONST, { .i64 = H264_PROF_MAIN&nbsp;&nbsp;&nbsp;&nbsp; }, INT_MIN, INT_MAX, VE, "profile" },
&gt;&gt; -&nbsp;&nbsp;&nbsp; { "high",&nbsp;&nbsp;&nbsp;&nbsp; "High Profile",&nbsp;&nbsp;&nbsp;&nbsp; 0, AV_OPT_TYPE_CONST, { .i64 = H264_PROF_HIGH&nbsp;&nbsp;&nbsp;&nbsp; }, INT_MIN, INT_MAX, VE, "profile" },
&gt;&gt; -&nbsp;&nbsp;&nbsp; { "extended", "Extend Profile",&nbsp;&nbsp; 0, AV_OPT_TYPE_CONST, { .i64 = H264_PROF_EXTENDED }, INT_MIN, INT_MAX, VE, "profile" },
&gt;&gt; +&nbsp;&nbsp;&nbsp; { "profile", "Profile", OFFSET(profile), AV_OPT_TYPE_INT64, { .i64 = FF_PROFILE_H264_BASELINE }, FF_PROFILE_H264_BASELINE, FF_PROFILE_H264_HIGH, VE, "profile" },
&gt;&gt; +&nbsp;&nbsp;&nbsp; { "baseline", "Baseline Profile", 0, AV_OPT_TYPE_CONST, { .i64 = FF_PROFILE_H264_BASELINE }, INT_MIN, INT_MAX, VE, "profile" },
&gt;&gt; +&nbsp;&nbsp;&nbsp; { "main",&nbsp;&nbsp;&nbsp;&nbsp; "Main Profile",&nbsp;&nbsp;&nbsp;&nbsp; 0, AV_OPT_TYPE_CONST, { .i64 = FF_PROFILE_H264_MAIN&nbsp;&nbsp;&nbsp;&nbsp; }, INT_MIN, INT_MAX, VE, "profile" },
&gt;&gt; +&nbsp;&nbsp;&nbsp; { "extended", "Extend Profile",&nbsp;&nbsp; 0, AV_OPT_TYPE_CONST, { .i64 = FF_PROFILE_H264_EXTENDED }, INT_MIN, INT_MAX, VE, "profile" },
&gt;&gt; +&nbsp;&nbsp;&nbsp; { "high",&nbsp;&nbsp;&nbsp;&nbsp; "High Profile",&nbsp;&nbsp;&nbsp;&nbsp; 0, AV_OPT_TYPE_CONST, { .i64 = FF_PROFILE_H264_HIGH&nbsp;&nbsp;&nbsp;&nbsp; }, INT_MIN, INT_MAX, VE, "profile" },
&gt; 
&gt; Firstly, it breaks use case which set the option by number like -profile 1.
&gt; 
&gt; Secondly, it changes the default profile to baseline. I don¡¯t think it¡¯s a
&gt; good idea.
&gt; 
&gt;&gt; 
&gt;&gt;&nbsp;&nbsp;&nbsp; { "level", "Level", OFFSET(level), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 52, VE, "level" },
&gt;&gt;&nbsp;&nbsp;&nbsp; { "1.3", "Level 1.3, only available with Baseline Profile", 0, AV_OPT_TYPE_CONST, { .i64 = 13 }, INT_MIN, INT_MAX, VE, "level" },
&gt;&gt; @@ -2811,9 +2788,9 @@ const FFCodec ff_h264_videotoolbox_encoder = {
&gt;&gt; };
&gt;&gt; 
&gt;&gt; static const AVOption hevc_options[] = {
&gt;&gt; -&nbsp;&nbsp;&nbsp; { "profile", "Profile", OFFSET(profile), AV_OPT_TYPE_INT64, { .i64 = HEVC_PROF_AUTO }, HEVC_PROF_AUTO, HEVC_PROF_COUNT, VE, "profile" },
&gt;&gt; -&nbsp;&nbsp;&nbsp; { "main",&nbsp;&nbsp;&nbsp;&nbsp; "Main Profile",&nbsp;&nbsp;&nbsp;&nbsp; 0, AV_OPT_TYPE_CONST, { .i64 = HEVC_PROF_MAIN&nbsp;&nbsp; }, INT_MIN, INT_MAX, VE, "profile" },
&gt;&gt; -&nbsp;&nbsp;&nbsp; { "main10",&nbsp;&nbsp; "Main10 Profile",&nbsp;&nbsp; 0, AV_OPT_TYPE_CONST, { .i64 = HEVC_PROF_MAIN10 }, INT_MIN, INT_MAX, VE, "profile" },
&gt;&gt; +&nbsp;&nbsp;&nbsp; { "profile", "Profile", OFFSET(profile), AV_OPT_TYPE_INT64, { .i64 = FF_PROFILE_HEVC_MAIN }, FF_PROFILE_HEVC_MAIN, FF_PROFILE_HEVC_MAIN_10, VE, "profile" },
&gt;&gt; +&nbsp;&nbsp;&nbsp; { "main",&nbsp;&nbsp;&nbsp;&nbsp; "Main Profile",&nbsp;&nbsp;&nbsp;&nbsp; 0, AV_OPT_TYPE_CONST, { .i64 = FF_PROFILE_HEVC_MAIN&nbsp;&nbsp;&nbsp; }, INT_MIN, INT_MAX, VE, "profile" },
&gt;&gt; +&nbsp;&nbsp;&nbsp; { "main10",&nbsp;&nbsp; "Main10 Profile",&nbsp;&nbsp; 0, AV_OPT_TYPE_CONST, { .i64 = FF_PROFILE_HEVC_MAIN_10 }, INT_MIN, INT_MAX, VE, "profile" },
&gt;&gt; 
&gt;&gt;&nbsp;&nbsp;&nbsp; { "alpha_quality", "Compression quality for the alpha channel", OFFSET(alpha_quality), AV_OPT_TYPE_DOUBLE, { .dbl = 0.0 }, 0.0, 1.0, VE },
&gt;&gt; 
&gt;&gt; -- 
&gt;&gt; 2.32.0 (Apple Git-132)
&gt;&gt; 
&gt;&gt; _______________________________________________
&gt;&gt; ffmpeg-devel mailing list
&gt;&gt; ffmpeg-devel@ffmpeg.org
&gt;&gt; https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
&gt;&gt; 
&gt;&gt; To unsubscribe, visit link above, or email
&gt;&gt; ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2023-05-22  4:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-21 14:41 [FFmpeg-devel] [PATCH] avcodec/videotoolboxenc: replace VT_H264Profile with avctx profile xufuji456
2023-05-22  3:05 ` "zhilizhao(赵志立)"
2023-05-22  3:11   ` "zhilizhao(赵志立)"
2023-05-22  4:17     ` =?gb18030?B?0Oy4o8Kh?= [this message]
2023-05-24 13:37       ` Rick Kern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_0638FB27C68811009C367B2C0F68D94A4805@qq.com \
    --to=839789740@qq.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    --cc=kernrj@gmail.com \
    --cc=quinkblack@foxmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git