From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id DED6F4846B
	for <ffmpegdev@gitmailbox.com>; Tue,  5 Dec 2023 09:43:13 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E05B168CEF6;
	Tue,  5 Dec 2023 11:43:11 +0200 (EET)
Received: from out162-62-57-210.mail.qq.com (out162-62-57-210.mail.qq.com
 [162.62.57.210])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2B9D868CB92
 for <ffmpeg-devel@ffmpeg.org>; Tue,  5 Dec 2023 11:43:04 +0200 (EET)
X-QQ-FEAT: oHWrrGTW1dDc6WqWDAkbuvNXljmAAGFi
X-QQ-SSF: 00000000000000F0000000000000
X-QQ-XMRINFO: NyFYKkN4Ny6FSmKK/uo/jdU=
X-QQ-XMAILINFO: OYvn7wz5E5RNNHPegjd5Y72WuadAxx/vFDVYKO6TgxZv/ol0rEaWv+PDpXMTVT
 6ttP1xQAOeaedaeWnybSyPvNjfgiK0DfjVyTzZDtHzhhO2n3CXEt8/LRvuAmXb5U29q9MjuyyxDYA
 vahWPQqv19RFFtlNIEBIrCaOzKHXgtoKMLct5zBC0K52FKAXTfDtOM0+vqkbC1UQDKY03zXSLxQzk
 dD9W6WiZEAbfdinq3CSzDphOuCZI1dEV3BOVfwmygbceIVc90LVWgIcQ2jIVcy/+AzKB+cx/BkbpW
 XqrtWdRH9b5nKAbOU9tjnEbkbR81mlug7tt0Wc3FcnB7YL6Dye5ROs/j08ACDODmopBfOAccyOcUG
 2DpbcOy9WmjxxuohKmRs5F2brbwQ3XV9F9OK+fPg4B15V/fGPH4xshT0p7Pn3FUdvzmwZWIkMoDbC
 waRUE4Itvit3Ho7VUQKidVE6EVbcQ5fDw80IX5T6TfTTa3hbdyqwTbiBgiauNFVVXqWRxMZHPpZJh
 0OfRS8YBkyXQ8yngfSGJ9v8plPnyNLmvkQIx2nFjZpGbqcSSkBoo7tcWpLWJCmx9RUcogByYCDFeU
 AqGpedUdM512FuSqTDCywh7sExygpGvzkw4l9FkoI1Zld3oqd++qOUbBhUEHq6WpvZnIeR4VnghjF
 /FNH7QpBMuCAmh9OBnpm82lW6Nocdbu2U4ShsOp06stSZ4yRKXVoTe7ki4dvccEwQhYBrey0PGRjT
 7AR7eVV4Xu9Ya3Zt2vTHt9V5ef55ZIWVSv+D4ymxRuF5LVfk/SGHhNjN3DS8cwwQgjPRAyb0eZZPz
 BWCIy3ZHBZZ/6FJf1yT95Mzg+VyPVI3Ry6MX1IoFstyEXfMNtPPcXg1skvRFLaZWgy3WFsMgNQ3ki
 7yFfHNXD3ChodFBtaDX2/vvqdDP+WeixBhJcJuvgQdpnaCFZjk704D4LzxRPcUlOpNqqJBNWQITeO
 SKQvCb/Q==
X-HAS-ATTACH: no
X-QQ-BUSINESS-ORIGIN: 2
X-Originating-IP: 14.145.223.67
In-Reply-To: <1179d31f-dcea-4a2d-b14a-59849e975d91@mail.de>
References: <tencent_2C0E70D0ECB1BC8A6559A1B9ECAD983E4607@qq.com>
 <1179d31f-dcea-4a2d-b14a-59849e975d91@mail.de>
X-QQ-STYLE: 
X-QQ-mid: webmail444t1701769367t1437270
To: "=?gb18030?B?RkZtcGVnIGRldmVsb3BtZW50IGRpc2N1c3Npb25zIGFuZCBwYXRjaGVz?="
 <ffmpeg-devel@ffmpeg.org>
Mime-Version: 1.0
Date: Tue, 5 Dec 2023 17:42:46 +0800
X-Priority: 3
Message-ID: <tencent_049E105DB6540C0DE32D7867B64A1EDCF206@qq.com>
X-QQ-MIME: TCMime 1.0 by Tencent
X-Mailer: QQMail 2.x
X-QQ-Mailer: QQMail 2.x
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
Subject: Re: [FFmpeg-devel] [PATCH] avdevice/avfoundation: replace
 AVCaptureDevice with new api
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
From: =?utf-8?b?5b6Q56aP6ZqGIHZpYSBmZm1wZWctZGV2ZWw=?=
 <ffmpeg-devel@ffmpeg.org>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: =?gb18030?B?0Oy4o8Kh?= <839789740@qq.com>,
 =?gb18030?B?dGhpbG8uYm9yZ21hbm4=?= <thilo.borgmann@mail.de>,
 =?gb18030?B?ZXBpcmF0MDc=?= <epirat07@gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/tencent_049E105DB6540C0DE32D7867B64A1EDCF206@qq.com/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

Thank you for your suggestion.
I will adapt the judgment condition, and submit again.


------------------&nbsp;Original&nbsp;------------------
From:                                                                                                                        "FFmpeg development discussions and patches"                                                                                    <ffmpeg-devel@ffmpeg.org&gt;;
Date:&nbsp;Mon, Dec 4, 2023 09:55 PM
To:&nbsp;"ffmpeg-devel"<ffmpeg-devel@ffmpeg.org&gt;;
Cc:&nbsp;"Thilo Borgmann"<thilo.borgmann@mail.de&gt;;
Subject:&nbsp;Re: [FFmpeg-devel] [PATCH] avdevice/avfoundation: replace AVCaptureDevice with new api



Am 04.12.23 um 13:47 schrieb xufuji456 via ffmpeg-devel:
&gt; Building with iOS platform, the compiler has a warning: "'devicesWithMediaType:' is deprecated: first deprecated in iOS 10.0 - Use AVCaptureDeviceDiscoverySession instead"
&gt; 
&gt; Signed-off-by: xufuji456 <839789740@qq.com&gt;
&gt; ---
&gt;&nbsp;&nbsp; libavdevice/avfoundation.m | 81 +++++++++++++++++++++++++++++++++++---
&gt;&nbsp;&nbsp; 1 file changed, 76 insertions(+), 5 deletions(-)
&gt; 
&gt; diff --git a/libavdevice/avfoundation.m b/libavdevice/avfoundation.m
&gt; index 36ad834753..668c726eb7 100644
&gt; --- a/libavdevice/avfoundation.m
&gt; +++ b/libavdevice/avfoundation.m
&gt; @@ -770,8 +770,38 @@ static int avf_read_header(AVFormatContext *s)
&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; AVCaptureDevice *video_device = nil;
&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; AVCaptureDevice *audio_device = nil;
&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; // Find capture device
&gt; -&nbsp;&nbsp;&nbsp; NSArray *devices = [AVCaptureDevice devicesWithMediaType:AVMediaTypeVideo];
&gt; -&nbsp;&nbsp;&nbsp; NSArray *devices_muxed = [AVCaptureDevice devicesWithMediaType:AVMediaTypeMuxed];
&gt; +&nbsp;&nbsp;&nbsp; NSArray *devices = nil;
&gt; +&nbsp;&nbsp;&nbsp; NSArray *devices_muxed = nil;
&gt; +


&gt; +&nbsp;&nbsp;&nbsp; if (TARGET_OS_IPHONE) {
&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if (@available(iOS 10.0, *)) {

The preprocessor directives should be more reliable especially on older machines.
See other parts of the code which are handled that way and adopt for your case.


&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; AVCaptureDeviceDiscoverySession *captureDeviceDiscoverySession =
&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; [AVCaptureDeviceDiscoverySession
&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; discoverySessionWithDeviceTypes:@[AVCaptureDeviceTypeBuiltInWideAngleCamera]
&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; mediaType:AVMediaTypeVideo
&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; position:AVCaptureDevicePositionUnspecified];
&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; devices = [captureDeviceDiscoverySession devices];

&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; } else {
&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; devices = [AVCaptureDevice devicesWithMediaType:AVMediaTypeVideo];
&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }
&gt; +&nbsp;&nbsp;&nbsp; } else {
&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; devices = [AVCaptureDevice devicesWithMediaType:AVMediaTypeVideo];
&gt; +&nbsp;&nbsp;&nbsp; }

Here and in other chunks you can join the if() conditions into one and avoid the duplication of the old code.


-Thilo
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".