From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 41E284DF6D for ; Sat, 7 Jun 2025 01:35:43 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id BE22E687D97; Sat, 7 Jun 2025 04:35:39 +0300 (EEST) Received: from out162-62-57-87.mail.qq.com (out162-62-57-87.mail.qq.com [162.62.57.87]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 09800687C9C for ; Sat, 7 Jun 2025 04:35:31 +0300 (EEST) Received: from localhost.localdomain ([2409:8a02:6072:8690:7da3:45cf:b5c9:673c]) by newxmesmtplogicsvrszb20-0.qq.com (NewEsmtp) with SMTP id 8D92DEC2; Sat, 07 Jun 2025 09:35:25 +0800 X-QQ-mid: xmsmtpt1749260125tr10pprg8 Message-ID: X-QQ-XMAILINFO: NDgMZBR9sMma/CNolzB6RADMzNs3G+7y5+dDtTJnyqxPx+Xi2WgcushinFqCFc wZQQSIU5sOioCLEMqutiyyD6xDXqxJsBngsoBOEoWKfB2sg9mKvy3VNfNNECqsBdOXRhwW/iDoo8 r7kcJQJvRHrgAcscJs8WpL564ALXAfN/8HREI01LOY14rD0oJTotbf/XYd5Y4AG72OgoIhKFJBvQ ERmdmYxzcuZ2zVcXgNR0B/YFzBsw/Uu/jrIVJjTjYzGJKJCkkRThZy6dBGZ5EpZHCpNnUpjs7qbB Lphe22xd42A9gWQ/WpiiRm2QDmneMB8C7kUh7KfEewCINsAGbqgbpGZupJjNEZ5DPmSWFauoc/Xr QfoELc4UBGNp2AfqCZqIJmNa2VqprB59Uf7LbI6YDnz4hvDAJR81MX8fllV05vVSDziDQNgAOtEI 6/Htj5uXfFMY9WTQek+MLr9s0xPeWEJno2hljJ0bCpaZUT9ib4dvIDhbN4EX5Dj5HY4fSBfvQt3o 6PdX4Ve4oBe6SEsUoMNDsku2JKejUkaM8Wz+5NKbXOffsPQobnvAlxbDq0jJEUqtHVyKQ/2C+U96 aWc3Z0qGk7peGA+BeI+d52xB1/lqyvQQ0Mf9MqGEzi1DygL+X/CzpMzInlYkKm0ZiQ/ECajpzwZx PGauvmF474h2+G7tt3FwVM968zsSdkFjtpnHZaML/kNTiLQG5pYccdywXSeFa7Zg8R0Oec9ue3Fj aTCZGCLhqChD4yQBdgHAVQgm2SzL6cCG9UXd1FHZvJ5HDZ7C47dz1FLZQoLywRk982zA84Q+6/kn nIWv5OOizmXTfUMD6JD4ECSyjmf2VlY85c+s465ZFbHUKk4xfLfRt/FNBs9gKtpddhpjOHHxet3L i7ebkwwV5mcXzXi2btTyMQk8WoDaGEi1tnNxRqtq/Y8i0zvB3X6Iik+y6MyYlSm2QTP/R4/OUZuF tIRitH8EHSGsfNIJc98D3Myn86uVjXD/ryua1VEPQ= X-QQ-XMRINFO: OWPUhxQsoeAVDbp3OJHYyFg= To: ffmpeg-devel@ffmpeg.org Date: Sat, 7 Jun 2025 09:35:23 +0800 X-OQ-MSGID: <20250607013523.74826-1-jacklau1222@qq.com> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] avformat/tls_openssl: fix warnings when openssl is lower version X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Jack Lau via ffmpeg-devel Reply-To: FFmpeg development discussions and patches Cc: Jack Lau Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: In higher versions (like openssl 1.1.1 and higher), the function signature is BIO *BIO_new_mem_buf(const void *buf, int len), so passing a const string doesn't cause an warnings. However, in lower versions of OpenSSL, the function signature becomes BIO *BIO_new_mem_buf(void *buf, int len), which leads to warnings. OpenSSL guarantees that it will not modify the string, so it's safe to cast the pem_str to (void *) to avoid this warning. Signed-off-by: Jack Lau --- libavformat/tls_openssl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index 86e8935fee..5387e21df1 100644 --- a/libavformat/tls_openssl.c +++ b/libavformat/tls_openssl.c @@ -415,7 +415,7 @@ error: */ static EVP_PKEY *pkey_from_pem_string(const char *pem_str, int is_priv) { - BIO *mem = BIO_new_mem_buf(pem_str, -1); + BIO *mem = BIO_new_mem_buf((void *)pem_str, -1); if (!mem) { av_log(NULL, AV_LOG_ERROR, "BIO_new_mem_buf failed\n"); return NULL; @@ -445,7 +445,7 @@ static EVP_PKEY *pkey_from_pem_string(const char *pem_str, int is_priv) */ static X509 *cert_from_pem_string(const char *pem_str) { - BIO *mem = BIO_new_mem_buf(pem_str, -1); + BIO *mem = BIO_new_mem_buf((void *)pem_str, -1); if (!mem) { av_log(NULL, AV_LOG_ERROR, "BIO_new_mem_buf failed\n"); return NULL; -- 2.49.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".