From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 00EBC42526 for ; Fri, 18 Mar 2022 03:07:07 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 85CB168B0E0; Fri, 18 Mar 2022 05:07:04 +0200 (EET) Received: from out203-205-221-221.mail.qq.com (out203-205-221-221.mail.qq.com [203.205.221.221]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C0BF268AE59 for ; Fri, 18 Mar 2022 05:06:57 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1647572811; bh=OPLPM9nVnjfYlwHr17n/sh0YdPeC3imY1EfpMG1OgDQ=; h=From:Subject:Date:References:To:In-Reply-To; b=vu0BBPjFpS6s0MS5avPH6XQnUfCZi3uzVHjz2AgerPl+NJn+csc4xwvHKafPWI1vr vLhdX5w1KCoC9prQ5BUXTNHENrRl7l9yjbmXg7HlsHyMi9rKPgO54Ih5+UHWoAtMgH Ubqjski6CLTTW7W6vkNfk9GKeb1lW6WyUcBHGDUg= Received: from [192.168.255.10] ([119.123.135.31]) by newxmesmtplogicsvrsza9.qq.com (NewEsmtp) with SMTP id 1B2BB838; Fri, 18 Mar 2022 11:06:50 +0800 X-QQ-mid: xmsmtpt1647572810tih7lb7jj Message-ID: X-QQ-XMAILINFO: MtZ4zLDUQmWfxQQS1Mmbz+2DRQBbOyiAStpoIwJzFsOoHJ8CROaHUvW0aOqTux X/5W4JZ4EeOftEq/vGXp4Bh0MRnCa+XcB5FprrkPQY1HGyDyF/KOSm/jqjEG/44qlJPqyl0lXR3U M6IFSIBxeSWnIfK2mcbbBYacjQanBpKM27XhQP2DafwXaftF+xxaH5aVR0Jmy82dhbJ9Gc7bQJiI idRFffGl9AM5eUQdoFG77qb//Pk3ajLCHZEP9spNO5fYM/QU7Jzr0oFaX1UXzOpEJFBgOPtSNN3r ndAC2b7T7nZFTwJ+kF911o4EdwXktrgMLl+MeUdclhwxR6DQZ0oijoA0ixxKKWVSWUsJsQJOOLad HZyg1kEYetPFC6sTWwlkRX++7n8j3ktIBtPiVZobnpRnNIqHPiUwcA8N2W2IS4mN7z6lac3oW09u II3TUo/6JkuPYEv+H7UBG3TnDPnCWFKVnPggcaO9f/8XVh3Yyk/FylKI3K8bGq6otdMz3gOH0r1R 1erobwDqImPuYATqAA3PACZZU0DEpOJ0lUs+SEYMiS1dzmVK5p1bL0mfNv/AkmKLPfpVPbQ4vZ21 SkZsPNKYxhc02w4cLyDRZgAR6OssfzsjYlPxvUCJce664pypbRDmr2DFyAaAHXOaQ/f4PN4jLMWI xNoNAG/OMryF9/TgYKIQVtOpu4kau/7gHppJ/TeW5uMDeZhN5C77iPO/qoaiLjZWkG6gTI1orchd nAwCzpHCeZHjj1Ia0NEoHZdpsE2BV2CgtAsojCGBSW7jYDPin0ahNDi/IC1bTsuLGk/XF9vanZhu ZG7TA82JE7MtCgMAwa2Ih40Dh55HuDs3uGI7eCVM8OPcH9O9d+qsE7pXnMdGBehDF4TLnqSXIiJE yoSUmsEpGSL+IXqg9cS5ZJRaJaYCRPtA1bl/OgeHQJ From: =?utf-8?B?InpoaWxpemhhbyjotbXlv5fnq4spIg==?= Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Date: Fri, 18 Mar 2022 11:06:50 +0800 References: To: FFmpeg development discussions and patches In-Reply-To: X-OQ-MSGID: <8E79F806-49CD-457A-909E-BCC38CD45968@foxmail.com> X-Mailer: Apple Mail (2.3654.60.0.2.21) Subject: Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/movenc: sidx earliest_presentation_time is applied after editlist X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Ping for review. The following is copied from ISO-14496-12 as reference: > earliest_presentation_time is the earliest presentation time of any content in the reference > stream in the first subsegment, in the timescale indicated in the timescale field; the earliest > presentation time is derived from media in access units, or parts of access units, that are not > omitted by an edit list (if any); > On Mar 5, 2022, at 1:33 AM, Zhao Zhili wrote: > > Fix #8334 > --- > Remove casual change due to clang-format plugin. > > libavformat/movenc.c | 3 ++- > tests/ref/fate/movenc | 10 +++++----- > 2 files changed, 7 insertions(+), 6 deletions(-) > > diff --git a/libavformat/movenc.c b/libavformat/movenc.c > index 4c868919ae..a2da80bc00 100644 > --- a/libavformat/movenc.c > +++ b/libavformat/movenc.c > @@ -4750,7 +4750,8 @@ static int mov_write_sidx_tag(AVIOContext *pb, > > if (track->entry) { > entries = 1; > - presentation_time = track->cluster[0].dts + track->cluster[0].cts; > + presentation_time = track->cluster[0].dts + track->cluster[0].cts - > + track->start_dts - track->start_cts; > duration = track->end_pts - > (track->cluster[0].dts + track->cluster[0].cts); > starts_with_SAP = track->cluster[0].flags & MOV_SYNC_SAMPLE; > diff --git a/tests/ref/fate/movenc b/tests/ref/fate/movenc > index 19e4e291b8..968a3d27f2 100644 > --- a/tests/ref/fate/movenc > +++ b/tests/ref/fate/movenc > @@ -101,28 +101,28 @@ write_data len 1223, time nopts, type header atom ftyp > 041ac8efc35a0d023c26d05eedb20403 1223 delay-moov-elst-signal-init > write_data len 1004, time -33333, type sync atom sidx > write_data len 996, time 966667, type sync atom sidx > -5a583d89318827d2569eecbeaa18c238 996 delay-moov-elst-signal-second-frag > +69c9025ffb10302c7b5c2ed9fde86c44 996 delay-moov-elst-signal-second-frag > write_data len 148, time nopts, type trailer atom - > write_data len 1223, time nopts, type header atom ftyp > 041ac8efc35a0d023c26d05eedb20403 1223 delay-moov-elst-signal-init-discont > write_data len 996, time 966667, type sync atom sidx > -5a583d89318827d2569eecbeaa18c238 996 delay-moov-elst-signal-second-frag-discont > +69c9025ffb10302c7b5c2ed9fde86c44 996 delay-moov-elst-signal-second-frag-discont > write_data len 110, time nopts, type trailer atom - > write_data len 1247, time nopts, type header atom ftyp > 80511a51d1ac9cde62337eed7176ae03 1247 delay-moov-elst-signal-init-discont-largets > write_data len 996, time 279621233333, type sync atom sidx > -dc695d65e8a0cdafee28acd8a5ccf81a 996 delay-moov-elst-signal-second-frag-discont-largets > +471fc64644a6bf4065c489fe4e04be7d 996 delay-moov-elst-signal-second-frag-discont-largets > write_data len 110, time nopts, type trailer atom - > write_data len 1223, time nopts, type header atom ftyp > write_data len 2572, time -333333, type sync atom sidx > write_data len 996, time 5166667, type sync atom sidx > write_data len 148, time nopts, type trailer atom - > -d37a7eda807912b9ed05ccfe003a9e4f 4939 vfr > +5c873f6e37d5af09e3c6329cf94cd6ca 4939 vfr > write_data len 1223, time nopts, type header atom ftyp > write_data len 2572, time -333333, type sync atom sidx > write_data len 996, time 5166667, type sync atom sidx > write_data len 148, time nopts, type trailer atom - > -d37a7eda807912b9ed05ccfe003a9e4f 4939 vfr-noduration > +5c873f6e37d5af09e3c6329cf94cd6ca 4939 vfr-noduration > write_data len 1231, time nopts, type header atom ftyp > write_data len 1500, time -333333, type sync atom moof > write_data len 1500, time nopts, type unknown atom - > -- > 2.31.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".