* [FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: silence warning for RGB
@ 2024-08-10 6:13 gnattu via ffmpeg-devel
2024-08-10 9:52 ` epirat07
0 siblings, 1 reply; 3+ messages in thread
From: gnattu via ffmpeg-devel @ 2024-08-10 6:13 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: gnattu
Hardware frames with RGB colorspace will not have a YCbCrMatrixKey.
Currently, it will spam the console with warning if rgb frame is
uploaded.
Signed-off-by: Gnattu OC <gnattuoc@me.com>
---
libavutil/hwcontext_videotoolbox.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavutil/hwcontext_videotoolbox.c b/libavutil/hwcontext_videotoolbox.c
index 80eaab64f08..122a61d5e78 100644
--- a/libavutil/hwcontext_videotoolbox.c
+++ b/libavutil/hwcontext_videotoolbox.c
@@ -576,7 +576,7 @@ static int vt_pixbuf_set_colorspace(void *log_ctx,
colormatrix, kCVAttachmentMode_ShouldPropagate);
else {
CVBufferRemoveAttachment(pixbuf, kCVImageBufferYCbCrMatrixKey);
- if (src->colorspace != AVCOL_SPC_UNSPECIFIED)
+ if (src->colorspace != AVCOL_SPC_UNSPECIFIED && src->colorspace != AVCOL_SPC_RGB)
av_log(log_ctx, AV_LOG_WARNING,
"Color space %s is not supported.\n",
av_color_space_name(src->colorspace));
--
2.39.3 (Apple Git-146)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: silence warning for RGB
2024-08-10 6:13 [FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: silence warning for RGB gnattu via ffmpeg-devel
@ 2024-08-10 9:52 ` epirat07
2024-08-15 12:13 ` Zhao Zhili
0 siblings, 1 reply; 3+ messages in thread
From: epirat07 @ 2024-08-10 9:52 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: gnattu
On 10 Aug 2024, at 8:13, gnattu via ffmpeg-devel wrote:
> Hardware frames with RGB colorspace will not have a YCbCrMatrixKey.
> Currently, it will spam the console with warning if rgb frame is
> uploaded.
Thanks, LGTM
>
> Signed-off-by: Gnattu OC <gnattuoc@me.com>
> ---
> libavutil/hwcontext_videotoolbox.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavutil/hwcontext_videotoolbox.c b/libavutil/hwcontext_videotoolbox.c
> index 80eaab64f08..122a61d5e78 100644
> --- a/libavutil/hwcontext_videotoolbox.c
> +++ b/libavutil/hwcontext_videotoolbox.c
> @@ -576,7 +576,7 @@ static int vt_pixbuf_set_colorspace(void *log_ctx,
> colormatrix, kCVAttachmentMode_ShouldPropagate);
> else {
> CVBufferRemoveAttachment(pixbuf, kCVImageBufferYCbCrMatrixKey);
> - if (src->colorspace != AVCOL_SPC_UNSPECIFIED)
> + if (src->colorspace != AVCOL_SPC_UNSPECIFIED && src->colorspace != AVCOL_SPC_RGB)
> av_log(log_ctx, AV_LOG_WARNING,
> "Color space %s is not supported.\n",
> av_color_space_name(src->colorspace));
> --
> 2.39.3 (Apple Git-146)
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: silence warning for RGB
2024-08-10 9:52 ` epirat07
@ 2024-08-15 12:13 ` Zhao Zhili
0 siblings, 0 replies; 3+ messages in thread
From: Zhao Zhili @ 2024-08-15 12:13 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: gnattu
> On Aug 10, 2024, at 17:52, epirat07@gmail.com wrote:
>
> On 10 Aug 2024, at 8:13, gnattu via ffmpeg-devel wrote:
>
>> Hardware frames with RGB colorspace will not have a YCbCrMatrixKey.
>> Currently, it will spam the console with warning if rgb frame is
>> uploaded.
>
> Thanks, LGTM
Applied. Thanks for the patch and review.
>
>>
>> Signed-off-by: Gnattu OC <gnattuoc@me.com>
>> ---
>> libavutil/hwcontext_videotoolbox.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libavutil/hwcontext_videotoolbox.c b/libavutil/hwcontext_videotoolbox.c
>> index 80eaab64f08..122a61d5e78 100644
>> --- a/libavutil/hwcontext_videotoolbox.c
>> +++ b/libavutil/hwcontext_videotoolbox.c
>> @@ -576,7 +576,7 @@ static int vt_pixbuf_set_colorspace(void *log_ctx,
>> colormatrix, kCVAttachmentMode_ShouldPropagate);
>> else {
>> CVBufferRemoveAttachment(pixbuf, kCVImageBufferYCbCrMatrixKey);
>> - if (src->colorspace != AVCOL_SPC_UNSPECIFIED)
>> + if (src->colorspace != AVCOL_SPC_UNSPECIFIED && src->colorspace != AVCOL_SPC_RGB)
>> av_log(log_ctx, AV_LOG_WARNING,
>> "Color space %s is not supported.\n",
>> av_color_space_name(src->colorspace));
>> --
>> 2.39.3 (Apple Git-146)
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-15 12:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-10 6:13 [FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: silence warning for RGB gnattu via ffmpeg-devel
2024-08-10 9:52 ` epirat07
2024-08-15 12:13 ` Zhao Zhili
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git