From: Zhao Zhili <quinkblack@foxmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: gnattu <gnattuoc@me.com>
Subject: Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: silence warning for RGB
Date: Thu, 15 Aug 2024 20:13:16 +0800
Message-ID: <tencent_0013EC336A15C549020EA0A5417313684005@qq.com> (raw)
In-Reply-To: <86C0D0B1-28D8-4618-9539-DB953A2A99AB@gmail.com>
> On Aug 10, 2024, at 17:52, epirat07@gmail.com wrote:
>
> On 10 Aug 2024, at 8:13, gnattu via ffmpeg-devel wrote:
>
>> Hardware frames with RGB colorspace will not have a YCbCrMatrixKey.
>> Currently, it will spam the console with warning if rgb frame is
>> uploaded.
>
> Thanks, LGTM
Applied. Thanks for the patch and review.
>
>>
>> Signed-off-by: Gnattu OC <gnattuoc@me.com>
>> ---
>> libavutil/hwcontext_videotoolbox.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libavutil/hwcontext_videotoolbox.c b/libavutil/hwcontext_videotoolbox.c
>> index 80eaab64f08..122a61d5e78 100644
>> --- a/libavutil/hwcontext_videotoolbox.c
>> +++ b/libavutil/hwcontext_videotoolbox.c
>> @@ -576,7 +576,7 @@ static int vt_pixbuf_set_colorspace(void *log_ctx,
>> colormatrix, kCVAttachmentMode_ShouldPropagate);
>> else {
>> CVBufferRemoveAttachment(pixbuf, kCVImageBufferYCbCrMatrixKey);
>> - if (src->colorspace != AVCOL_SPC_UNSPECIFIED)
>> + if (src->colorspace != AVCOL_SPC_UNSPECIFIED && src->colorspace != AVCOL_SPC_RGB)
>> av_log(log_ctx, AV_LOG_WARNING,
>> "Color space %s is not supported.\n",
>> av_color_space_name(src->colorspace));
>> --
>> 2.39.3 (Apple Git-146)
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-08-15 12:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-10 6:13 gnattu via ffmpeg-devel
2024-08-10 9:52 ` epirat07
2024-08-15 12:13 ` Zhao Zhili [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_0013EC336A15C549020EA0A5417313684005@qq.com \
--to=quinkblack@foxmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=gnattuoc@me.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git