From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id F3C7145022 for ; Wed, 28 Jun 2023 13:28:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E275268C385; Wed, 28 Jun 2023 16:28:02 +0300 (EEST) Received: from mail-40140.protonmail.ch (mail-40140.protonmail.ch [185.70.40.140]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4746C68C03F for ; Wed, 28 Jun 2023 16:27:57 +0300 (EEST) Date: Wed, 28 Jun 2023 13:27:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1687958876; x=1688218076; bh=v+fmhZXyhpazv8UJVOkSTMxVGj8FK8LlYmAvymlYnsw=; h=Date:To:From:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=i3R9QxrEGjotxZVN9jcyu4lVeQpDVAbHJAzdEXCQg+1G6e+HLBkp+5W0tnQlfPA8h 9XZMexMlYz6eKSw90qbBYxoLEnTC93R9OWalaI0JDc4IoRTk8+55MI4f03Mm5/Z52/ vGnBuHvDJzpvI3kw78skqHhDISk6ntVcoRwbEAcwJTGP9t1Z3gTSK3phYYd8fn9upU WKU9RCfNRFmixgRwgZ2eQ9fVM1d//oZzZfcWiG6DOos+GU3GdvS/81wxNtTaBYvV0E 8M9/v96j24nX5uYDdqV4QZplBnGu46pM9oBJUdbfTOdrjhJzND87IacYDyzLUU/36Y Q3aIKezy8wvNg== To: FFmpeg development discussions and patches From: asivery Message-ID: In-Reply-To: References: Feedback-ID: 33509725:user:proton MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] avformat/matroska: Add support for A_ATRAC/AT1 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hi, it's really not a problem. Thanks and please let me know if I need to change anything for this to be merged. ------- Original Message ------- On Saturday, June 17th, 2023 at 3:41 AM, Andreas Rheinhardt wrote: > asivery: > > > Hello, apologies for bothering you all with this, but if anyone could take a look at this patch it would be great. The only other container that supports ATRAC1 is AEA, and it's not that good of a format since it has no magic number, and therefore is easily detected incorrectly. > > > > Thank you in advance. > > > Sorry for having missed this. I will look at it tomorrow. > > - Andreas > > > ------- Original Message ------- > > On Monday, April 17th, 2023 at 2:27 AM, asivery asivery@protonmail.com wrote: > > > > > I'd appreciate it if someone took a look at this. > > > If there's anything I need to change to make this patch viable for merging, please let me know. > > > > > > Best regards, > > > asivery > > > ------- Original Message ------- > > > On Monday, March 6th, 2023 at 7:51 PM, asivery asivery@protonmail.com wrote: > > > > > > > It's been added recently. Here's the definition: https://github.com/ietf-wg-cellar/matroska-specification/blob/master/codec_specs.md#a_atracat1 > > > > > > > > ------- Original Message ------- > > > > On Monday, March 6th, 2023 at 7:39 PM, Paul B Mahol onemda@gmail.com wrote: > > > > > > > > > On 3/6/23, asivery asivery@protonmail.com wrote: > > > > > > > > > > > Signed-off-by: asivery asivery@protonmail.com > > > > > > --- > > > > > > libavformat/matroska.c | 1 + > > > > > > libavformat/matroskadec.c | 2 ++ > > > > > > 2 files changed, 3 insertions(+) > > > > > > > > > > where is this defined? > > > > > > > > > > > diff --git a/libavformat/matroska.c b/libavformat/matroska.c > > > > > > index 90d94b65bf..37305a523c 100644 > > > > > > --- a/libavformat/matroska.c > > > > > > +++ b/libavformat/matroska.c > > > > > > @@ -55,6 +55,7 @@ const CodecTags ff_mkv_codec_tags[]={ > > > > > > {"A_REAL/ATRC" , AV_CODEC_ID_ATRAC3}, > > > > > > {"A_REAL/COOK" , AV_CODEC_ID_COOK}, > > > > > > {"A_REAL/SIPR" , AV_CODEC_ID_SIPR}, > > > > > > + {"A_ATRAC/AT1" , AV_CODEC_ID_ATRAC1}, > > > > > > {"A_TRUEHD" , AV_CODEC_ID_TRUEHD}, > > > > > > {"A_TTA1" , AV_CODEC_ID_TTA}, > > > > > > {"A_VORBIS" , AV_CODEC_ID_VORBIS}, > > > > > > diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c > > > > > > index d582f566a2..0aa8e6f3b3 100644 > > > > > > --- a/libavformat/matroskadec.c > > > > > > +++ b/libavformat/matroskadec.c > > > > > > @@ -2795,6 +2795,8 @@ static int matroska_parse_tracks(AVFormatContext s) > > > > > > track->audio.frame_size); > > > > > > if (!track->audio.buf) > > > > > > return AVERROR(ENOMEM); > > > > > > + } else if (codec_id == AV_CODEC_ID_ATRAC1) { > > > > > > + st->codecpar->block_align = track->audio.channels * 212; / Constant ATRAC > > > > > > frame size */ > > > > > > } else if (codec_id == AV_CODEC_ID_FLAC && track->codec_priv.size) { > > > > > > ret = matroska_parse_flac(s, track, &extradata_offset); > > > > > > if (ret < 0) > > > > > > -- > > > > > > 2.34.1 > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".