From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id A2C4E4F52D for ; Tue, 17 Jun 2025 16:02:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 34B4568D31E; Tue, 17 Jun 2025 19:02:06 +0300 (EEST) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 4DF6268D2E2 for ; Tue, 17 Jun 2025 19:02:00 +0300 (EEST) Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2360ff7ac1bso41647055ad.3 for ; Tue, 17 Jun 2025 09:02:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750176118; x=1750780918; darn=ffmpeg.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=Wg8VfTyyU7/jmbmeB7zYNHV1WcJPU7/GSrTFF3A9l88=; b=Gjitll90UG8ioTVBqyH+yFgBt4BBPit2P+EJTSFLJALhL5rbOFidCRKjYLV1t6wOSC a6vYZTdTIxhuL92V81cZ05W3rN+XEBAVttRgZv3dvPTxA+j7lRxjAqlLoYAzvFLJlF1G vKVFySuxD0mLKyn9LQEB1AaErUGvdErHVgzHJ9oyJ7brXLGLcu8tsnM9NtxmcoGyPEYn MsGnSVCBAdwXTTGCZgLlcQz7FDy84CIEEXLeF7xlFXUne0oMfVGH8Pw+cmp6OIX6M1Sj vi0DxrWkUY7Lzei0qNlRSP4DiZWBwPwfB+7claDF3m8cei6gbhRsNmipzESgD+DmeIY9 RG9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750176118; x=1750780918; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Wg8VfTyyU7/jmbmeB7zYNHV1WcJPU7/GSrTFF3A9l88=; b=IYYVTf89TJ5JfE/f0U5XJBYacHBO06IWQ56B2nx7kopfUXQ/lQptFCud6e1MA6uHOU 1tuz2l3tKjeoUMHfwvBRW4cVUuypFDXWmxi90ZCDMcjj4I8544QihHfg6k7nwTJzvF5U vZNJytyPaiQsgb5LbNIpUnSR8CZLIsfVz+m8uPf9V8+zEjN95MpS6kvO6mTypQxsTIZM kOMa87lmbdzTMWnojCOHYovEHQ2UgR5q7IwCQ6UpHIq2Y5M/CniNSI3jCWRUmAqT9z44 04mSYXAQCR6tl7w2SmkPiRXOc0F0V1bWNUTOy5ZAnEFc7FkR0ynNyNblXtcOp45L4P55 5uCw== X-Gm-Message-State: AOJu0YwSEABk1cUKjiu/r+/c2zaPc070evFDBWADKMbDso1IIiRmk+Ol Mm/njRQ2Tz2MT/gViVIhPPtd9+Dlv7zb+H2c7fIStqtNQNOe7jbzn1MKErwNNA== X-Gm-Gg: ASbGncuYPhRfcQcdr+M1aXztM7dkki5t+8y2u5d8SGrFz0+U0joT3aE/YPAD0dZstEz Biu9mAj4XNX030U9vt4TeszTLJFPTOygLsPJ/leQlkFapYLlSerZJGju19C6mAKAknldLN9Nw5d PhnJxhqRMEH7XT+w/9Jb+Zid6S5DmpMKMyfQ8dt9DQYhU3gv/iaiqtGR4eTU5ILkopDbyLsyIhx Crl52iv0DMFCyFHfGHZhASftk5owwk+AtMLB6JvmjYUxXdGzBg1zUwPa4zzRWIsUquZrzecY1Ef H9ADiJknlrjDzSGaNhjF3Xr1Uqa/1LYh4oW7I7+3w3UZ6ukP3gDp4nZG2PPua4F2guOZFFsdJ0I xcSXR X-Google-Smtp-Source: AGHT+IH/zYkVyLdv0uUH3enONGIVi9hwJFoqLatRWAag0gOThMVYCTCNXUlzklexM+5lkYYzmPfd0w== X-Received: by 2002:a17:902:c943:b0:234:9375:e07c with SMTP id d9443c01a7336-2366b16d4a9mr181184295ad.46.1750176117869; Tue, 17 Jun 2025 09:01:57 -0700 (PDT) Received: from [127.0.0.1] (master.gitmailbox.com. [34.83.118.50]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2365de7839dsm81610445ad.127.2025.06.17.09.01.56 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Jun 2025 09:01:57 -0700 (PDT) Message-Id: In-Reply-To: References: From: ffmpegagent Date: Tue, 17 Jun 2025 16:01:49 +0000 Fcc: Sent MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH v6 0/2] ffbuild/commonmak: Fix rebuild check with implicit rule chains X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: softworkz Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: V2 == * Fix MSVC build (use the universal command pattern) V3 == * Skip dependency generation by clearing CC_DEPS instead (as suggested by Ramiro - thanks!) V4 == * Always keep .ptx files (as suggested by Timo - thanks) Tested all scenarios: * .ptx.c and .ptx.gz still get deleted (as intermediates) * repeated make shows "up-to-date" * removing a .ptx file does not cause a rebuild (it's still an intermediate, but an "intermediate to keep") * but changing a .ptx does (in case of dev/debugging) * changed .cu files always rebuild of course V5 == * First patch remains unchanged * Added second patch to clean up and consolidate the rules around compression V6 == * Rebased * Confirmed that it also resolves MSVC-CLang compilation (as reported by Kasper Michalow - thanks!) . softworkz (2): ffbuild/commonmak: Fix rebuild check with implicit rule chains ffbuild/commonmak: Consolidate pattern rules for compression ffbuild/common.mak | 54 ++++++++++++++++++++++------------------------ 1 file changed, 26 insertions(+), 28 deletions(-) base-commit: 93987c03ec6c14adc71e483a94dd229f7f75b7ba Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-80%2Fsoftworkz%2Fsubmit_commonmak-v6 Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-80/softworkz/submit_commonmak-v6 Pull-Request: https://github.com/ffstaging/FFmpeg/pull/80 Range-diff vs v5: 1: 20c2fb65ed ! 1: a8da0e9d17 ffbuild/commonmak: Fix rebuild check with implicit rule chains @@ ffbuild/common.mak: else + + # 1) Preprocess CSS to a minified version + %.css.min: TAG = SED %.css.min: %.css - # Must start with a tab in the real Makefile @@ ffbuild/common.mak: else # NO COMPRESSION $(BIN2C) $< $@ $(subst .,_,$(basename $(notdir $@))) endif 2: 9ff1856142 ! 2: 1781c5fc16 ffbuild/commonmak: Consolidate pattern rules for compression @@ ffbuild/common.mak: $(BIN2CEXE): ffbuild/bin2c_host.o -# 1) Preprocess CSS to a minified version +-%.css.min: TAG = SED %.css.min: %.css -- # Must start with a tab in the real Makefile -- sed 's!/\\*.*\\*/!!g' $< \ +- $(M)sed 's!/\\*.*\\*/!!g' $< \ - | tr '\n' ' ' \ - | tr -s ' ' \ - | sed 's/^ //; s/ $$//' \ @@ ffbuild/common.mak: $(BIN2CEXE): ffbuild/bin2c_host.o ifdef CONFIG_RESOURCE_COMPRESSION -# 2) Gzip the minified CSS +-%.css.min.gz: TAG = GZIP %.css.min.gz: %.css.min - $(M)gzip -nc9 $< > $@ + $(RUN_GZIP) @@ ffbuild/common.mak: $(BIN2CEXE): ffbuild/bin2c_host.o + $(RUN_BIN2C) -# 4) Gzip the HTML file (no minification needed) +-%.html.gz: TAG = GZIP %.html.gz: %.html - $(M)gzip -nc9 $< > $@ + $(RUN_GZIP) -- ffmpeg-codebot _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".