From: softworkz <ffmpegagent@gmail.com> To: ffmpeg-devel@ffmpeg.org Cc: softworkz <softworkz@hotmail.com> Subject: [FFmpeg-devel] [PATCH v2] fftools/ffmpeg: Log exit code on exit Date: Sun, 20 Apr 2025 22:08:39 +0000 Message-ID: <pull.69.v2.ffstaging.FFmpeg.1745186919807.ffmpegagent@gmail.com> (raw) In-Reply-To: <pull.69.ffstaging.FFmpeg.1745101853603.ffmpegagent@gmail.com> From: softworkz <softworkz@hotmail.com> When viewing logs, there are situations where it is not entirely clear whether ffmpeg CLI has exited gracefully. The two primary cases are - A crash/segfault has occured Windows for example doesn't output any message to the calling shell - The process has been terminated (e.g. killed externally) Printing a message on exit provides a reliable indication that the process has exited normally. Printing the exit code is useful as it usually remains invisible and unnoticed by users running FFmpeg from a shell. Signed-off-by: softworkz <softworkz@hotmail.com> --- fftools/ffmpeg: Log 'EXIT' on exit When viewing logs, there are situations where it is not entirely clear whether ffmpeg CLI has exited gracefully. The two primary cases are * A crash/segfault has occured Windows for example doesn't output any message to the calling shell * The process has been terminated (e.g. killed externally) Printing "EXIT" on exit provides a reliable indication that the process has exited normally. Signed-off-by: softworkz softworkz@hotmail.com Versions ======== V2 == * Include exit code in exit message as suggested by Marton Balint Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-69%2Fsoftworkz%2Fsubmit_exit_message-v2 Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-69/softworkz/submit_exit_message-v2 Pull-Request: https://github.com/ffstaging/FFmpeg/pull/69 Range-diff vs v1: 1: a9ea4afc19 ! 1: 2d488c126f fftools/ffmpeg: Log 'EXIT' on exit @@ Metadata Author: softworkz <softworkz@hotmail.com> ## Commit message ## - fftools/ffmpeg: Log 'EXIT' on exit + fftools/ffmpeg: Log exit code on exit When viewing logs, there are situations where it is not entirely clear whether ffmpeg CLI has exited gracefully. The two primary cases @@ Commit message Windows for example doesn't output any message to the calling shell - The process has been terminated (e.g. killed externally) - Printing "EXIT" on exit provides a reliable indication that the + Printing a message on exit provides a reliable indication that the process has exited normally. + Printing the exit code is useful as it usually remains invisible + and unnoticed by users running FFmpeg from a shell. Signed-off-by: softworkz <softworkz@hotmail.com> @@ fftools/ffmpeg.c: finish: sch_free(&sch); -+ av_log(NULL, AV_LOG_INFO, "\n"); -+ av_log(NULL, AV_LOG_INFO, "EXIT\n"); ++ av_log(NULL, AV_LOG_VERBOSE, "\n"); ++ av_log(NULL, AV_LOG_VERBOSE, "Exiting with exit code %d\n", ret); + return ret; } fftools/ffmpeg.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index dc321fb4a2..397bc1f229 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -1012,5 +1012,8 @@ finish: sch_free(&sch); + av_log(NULL, AV_LOG_VERBOSE, "\n"); + av_log(NULL, AV_LOG_VERBOSE, "Exiting with exit code %d\n", ret); + return ret; } base-commit: 853e66a0726b0a9d6d6269a22f6f9b5be7763738 -- ffmpeg-codebot _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2025-04-20 22:08 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2025-04-19 22:30 [FFmpeg-devel] [PATCH] fftools/ffmpeg: Log 'EXIT' " softworkz 2025-04-20 20:52 ` Marton Balint 2025-04-20 21:23 ` softworkz . 2025-04-20 22:08 ` softworkz [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=pull.69.v2.ffstaging.FFmpeg.1745186919807.ffmpegagent@gmail.com \ --to=ffmpegagent@gmail.com \ --cc=ffmpeg-devel@ffmpeg.org \ --cc=softworkz@hotmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git