[FFmpeg-devel] [PATCH] fftools/ffmpeg: Log 'EXIT' on exit

[FFmpeg-devel] [PATCH] fftools/ffmpeg: Log 'EXIT' on exit

[softworkz]

From: softworkz <softworkz@hotmail.com>

When viewing logs, there are situations where it is not entirely
clear whether ffmpeg CLI has exited gracefully. The two primary cases
are

- A crash/segfault has occured
  Windows for example doesn't output any message to the calling shell
- The process has been terminated (e.g. killed externally)

Printing "EXIT" on exit provides a reliable indication that the
process has exited normally.

Signed-off-by: softworkz <softworkz@hotmail.com>
---
    fftools/ffmpeg: Log 'EXIT' on exit
    
    When viewing logs, there are situations where it is not entirely clear
    whether ffmpeg CLI has exited gracefully. The two primary cases are
    
     * A crash/segfault has occured Windows for example doesn't output any
       message to the calling shell
     * The process has been terminated (e.g. killed externally)
    
    Printing "EXIT" on exit provides a reliable indication that the process
    has exited normally.
    
    Signed-off-by: softworkz softworkz@hotmail.com

Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-69%2Fsoftworkz%2Fsubmit_exit_message-v1
Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-69/softworkz/submit_exit_message-v1
Pull-Request: https://github.com/ffstaging/FFmpeg/pull/69

 fftools/ffmpeg.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
index dc321fb4a2..26746699ff 100644
--- a/fftools/ffmpeg.c
+++ b/fftools/ffmpeg.c
@@ -1012,5 +1012,8 @@ finish:
 
     sch_free(&sch);
 
+    av_log(NULL, AV_LOG_INFO, "\n");
+    av_log(NULL, AV_LOG_INFO, "EXIT\n");
+
     return ret;
 }

base-commit: 7cd1edeaa410d977a9f1ff8436f480cb45b80178
-- 
ffmpeg-codebot
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: Log 'EXIT' on exit

[Marton Balint]

On Sat, 19 Apr 2025, softworkz wrote:

> From: softworkz <softworkz@hotmail.com>
>
> When viewing logs, there are situations where it is not entirely
> clear whether ffmpeg CLI has exited gracefully. The two primary cases
> are
>
> - A crash/segfault has occured
>  Windows for example doesn't output any message to the calling shell
> - The process has been terminated (e.g. killed externally)

Relying on logs alone and not checking the exit code is a bad practice, so 
I am not super convinced this feature is worth having.

>
> Printing "EXIT" on exit provides a reliable indication that the
> process has exited normally.

Something like this should not be visible on the default loglevel. So the 
loglevel should be reduced to verbose or debug.

And if we print out something, then let's make it more useful and 
readable, e.g.:

av_log(NULL, AV_LOG_VERBOSE, "Exiting with exit code %d.\n", ret);

Regards,
Marton

>
> Signed-off-by: softworkz <softworkz@hotmail.com>
> ---
>    fftools/ffmpeg: Log 'EXIT' on exit
>
>    When viewing logs, there are situations where it is not entirely clear
>    whether ffmpeg CLI has exited gracefully. The two primary cases are
>
>     * A crash/segfault has occured Windows for example doesn't output any
>       message to the calling shell
>     * The process has been terminated (e.g. killed externally)
>
>    Printing "EXIT" on exit provides a reliable indication that the process
>    has exited normally.
>
>    Signed-off-by: softworkz softworkz@hotmail.com
>
> Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-69%2Fsoftworkz%2Fsubmit_exit_message-v1
> Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-69/softworkz/submit_exit_message-v1
> Pull-Request: https://github.com/ffstaging/FFmpeg/pull/69
>
> fftools/ffmpeg.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
> index dc321fb4a2..26746699ff 100644
> --- a/fftools/ffmpeg.c
> +++ b/fftools/ffmpeg.c
> @@ -1012,5 +1012,8 @@ finish:
>
>     sch_free(&sch);
>
> +    av_log(NULL, AV_LOG_INFO, "\n");
> +    av_log(NULL, AV_LOG_INFO, "EXIT\n");
> +
>     return ret;
> }
>
> base-commit: 7cd1edeaa410d977a9f1ff8436f480cb45b80178
> -- 
> ffmpeg-codebot
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: Log 'EXIT' on exit

[softworkz .]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> Marton Balint
> Sent: Sonntag, 20. April 2025 22:52
> To: FFmpeg development discussions and patches <ffmpeg-
> devel@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: Log 'EXIT' on exit
> 
> 
> 
> On Sat, 19 Apr 2025, softworkz wrote:
> 
> > From: softworkz <softworkz@hotmail.com>
> >
> > When viewing logs, there are situations where it is not entirely
> > clear whether ffmpeg CLI has exited gracefully. The two primary
> cases
> > are
> >
> > - A crash/segfault has occured
> >  Windows for example doesn't output any message to the calling shell
> > - The process has been terminated (e.g. killed externally)
> 
> Relying on logs alone and not checking the exit code is a bad
> practice, so
> I am not super convinced this feature is worth having.

Hi Marton,

two examples:

- When a user sends you a lot, they don't know the exit code and 
  it's tedious to explain how to acquire it - also given that it's
  a rather small number of cases where you'd be interested in it.
  That's why you practically don't do this.

- From practical experience, even though we do check exit codes
  and record them in the application log, it's still at an 
  inconvenient place. For example, when a user sends 5 ffmpeg 
  logs and the application log, I'd need to look up the exit codes
  for each log file in the application log - which you rarely do
  practically for the same reason as in the previous point

Over time, I have built some extensive tooling around FFmpeg log
file analysis plus a range of FFmpeg changes to make it more 
efficient. I'm upstreaming a number of those changes that have 
proven to be valuable over time for the benefit of the 
community. If nobody finds it useful, it's fine - I don't need 
them to be in FFmpeg.


> > Printing "EXIT" on exit provides a reliable indication that the
> > process has exited normally.
> 
> Something like this should not be visible on the default loglevel. So
> the
> loglevel should be reduced to verbose or debug.
> 
> And if we print out something, then let's make it more useful and
> readable, e.g.:
> 
> av_log(NULL, AV_LOG_VERBOSE, "Exiting with exit code %d.\n", ret);

I agree that this is even better.

Thanks
sw
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH v2] fftools/ffmpeg: Log exit code on exit

[softworkz]

From: softworkz <softworkz@hotmail.com>

When viewing logs, there are situations where it is not entirely
clear whether ffmpeg CLI has exited gracefully. The two primary cases
are

- A crash/segfault has occured
  Windows for example doesn't output any message to the calling shell
- The process has been terminated (e.g. killed externally)

Printing a message on exit provides a reliable indication that the
process has exited normally.
Printing the exit code is useful as it usually remains invisible
and unnoticed by users running FFmpeg from a shell.

Signed-off-by: softworkz <softworkz@hotmail.com>
---
    fftools/ffmpeg: Log 'EXIT' on exit
    
    When viewing logs, there are situations where it is not entirely clear
    whether ffmpeg CLI has exited gracefully. The two primary cases are
    
     * A crash/segfault has occured Windows for example doesn't output any
       message to the calling shell
     * The process has been terminated (e.g. killed externally)
    
    Printing "EXIT" on exit provides a reliable indication that the process
    has exited normally.
    
    Signed-off-by: softworkz softworkz@hotmail.com
    
    
    Versions
    ========
    
    
    V2
    ==
    
     * Include exit code in exit message as suggested by Marton Balint

Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-69%2Fsoftworkz%2Fsubmit_exit_message-v2
Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-69/softworkz/submit_exit_message-v2
Pull-Request: https://github.com/ffstaging/FFmpeg/pull/69

Range-diff vs v1:

 1:  a9ea4afc19 ! 1:  2d488c126f fftools/ffmpeg: Log 'EXIT' on exit
     @@ Metadata
      Author: softworkz <softworkz@hotmail.com>
      
       ## Commit message ##
     -    fftools/ffmpeg: Log 'EXIT' on exit
     +    fftools/ffmpeg: Log exit code on exit
      
          When viewing logs, there are situations where it is not entirely
          clear whether ffmpeg CLI has exited gracefully. The two primary cases
     @@ Commit message
            Windows for example doesn't output any message to the calling shell
          - The process has been terminated (e.g. killed externally)
      
     -    Printing "EXIT" on exit provides a reliable indication that the
     +    Printing a message on exit provides a reliable indication that the
          process has exited normally.
     +    Printing the exit code is useful as it usually remains invisible
     +    and unnoticed by users running FFmpeg from a shell.
      
          Signed-off-by: softworkz <softworkz@hotmail.com>
      
     @@ fftools/ffmpeg.c: finish:
       
           sch_free(&sch);
       
     -+    av_log(NULL, AV_LOG_INFO, "\n");
     -+    av_log(NULL, AV_LOG_INFO, "EXIT\n");
     ++    av_log(NULL, AV_LOG_VERBOSE, "\n");
     ++    av_log(NULL, AV_LOG_VERBOSE, "Exiting with exit code %d\n", ret);
      +
           return ret;
       }


 fftools/ffmpeg.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
index dc321fb4a2..397bc1f229 100644
--- a/fftools/ffmpeg.c
+++ b/fftools/ffmpeg.c
@@ -1012,5 +1012,8 @@ finish:
 
     sch_free(&sch);
 
+    av_log(NULL, AV_LOG_VERBOSE, "\n");
+    av_log(NULL, AV_LOG_VERBOSE, "Exiting with exit code %d\n", ret);
+
     return ret;
 }

base-commit: 853e66a0726b0a9d6d6269a22f6f9b5be7763738
-- 
ffmpeg-codebot
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".