From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id 3BFE54C85E
for <ffmpegdev@gitmailbox.com>; Wed, 9 Apr 2025 18:19:24 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1E19A687DEC;
Wed, 9 Apr 2025 21:19:20 +0300 (EEST)
Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com
[209.85.214.182])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 456C2687CCA
for <ffmpeg-devel@ffmpeg.org>; Wed, 9 Apr 2025 21:19:13 +0300 (EEST)
Received: by mail-pl1-f182.google.com with SMTP id
d9443c01a7336-2243803b776so102582015ad.0
for <ffmpeg-devel@ffmpeg.org>; Wed, 09 Apr 2025 11:19:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1744222751; x=1744827551; darn=ffmpeg.org;
h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from
:references:in-reply-to:message-id:from:to:cc:subject:date
:message-id:reply-to;
bh=ZllBSL2Wqe2IyLp2bjbVavUYacJoXP3u33pIzEdJRqI=;
b=HOLzXrWKA3nAWxjDDQG5KXhJd8kNiSl8aE1e4vYUqWsT6caVuYrH72hqmUva9z7hrf
LcseEBxY4x7RTMJU/3qHv9DcxLJWV/cYV3Gqwp4U8LXZ2VJFFaoDMZe/d/5OUtHkxejS
BBA/2fczEvci1sBTjaAXrPVRXpST5QAPUEFGcPYPw3V03ltxSi5aaRkx68p7qBDsfjtM
rSmc3Kbfzu5Y9S8qz30vAsKFtT+acGY/TPJ8ZWBeMjMOed7JHkyx9DuQiYGd01WTLqEv
Th1MteaPiyNOV06fZTO05LS6jYccVcxAgi62qGvzlMyvmCbvW4hE4CndaUdkhSOImtk4
WhNw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1744222751; x=1744827551;
h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from
:references:in-reply-to:message-id:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=ZllBSL2Wqe2IyLp2bjbVavUYacJoXP3u33pIzEdJRqI=;
b=BGNL6pfvrsAdPbIxgWl5MWGcm25LiYQAZzNRRkSf9nM2NOlfCoM9Dftq4Pb6k519oA
xPUnTIqpTJk4KCEvGrBpdq5d+a5dfpvglGMK7vDjVVMjA7/Ugk/Vp/8vGnPVTxhJ0q/T
Tf6bd9Szs/OPsOR+rKg+5u17jJgmH9A2LRuzmMIEBbsVflDSD3ejfECF61SdA1ytI4e9
obD+XJ6r1P+Iv416Qw9AamBc9I8Tk/fcdJ6/HfWs/SPn/JnJG16aIf9b3g4tVccK+s1D
T3yhPLwoV80XER4n3Lzff4SrRuKsUTjeq1vccSzUC7cCvnIvHNlsVl/kl+W/xLJAaOPA
pqJg==
X-Gm-Message-State: AOJu0Yxj8q/G+8HSoH7QrrU5WIojPiGsUGMxFWgslKEOuGNah+S/T1N0
JV4Is24+rcG6srrz96KwyKHKAurp6GM8S8dSFVFtjUVD6RJxbUyyRg7HxA==
X-Gm-Gg: ASbGncvJmBCLIFc7aq5oSeLkoxV1H/ekvzr1kKh8EbF+ZnvRvLiwCmEdm5+mwliEgQ0
nXwoFB7GYv4adUB1A31RH13FtU2dmR5vkWYCRO3ExILXJF2zOlsO2v7NiLYem1/PwH5oRq+RDWm
msJqLM8d/OxKKCt+nBMtLKVFbu9njcV1z+NvqhPBuYhhUHHxBnnDNr3cQKjOK9sHdiVaHewmdel
YJ6a2mQ7NOF+edQmx+P0ZoDuwxmIxRf2nsdv+H9uuVDhkGuY5DD2t4EiVfzPuR6pxa5hBIJsW7b
68tfQBzjC5ASMwAfob6BV69q7Xb+gd7oOZR3ES0pMq61nO8fMOiUhUvBeaY=
X-Google-Smtp-Source: AGHT+IHCQzz7AE7Tkaj1g239IfCreS/lqZVAR/5+nGQKmb/zAoTtWAWDcQBVx9YftPcwlrkhJcbniA==
X-Received: by 2002:a17:903:41c5:b0:21f:1549:a55a with SMTP id
d9443c01a7336-22ac297dc86mr51583595ad.1.1744222750987;
Wed, 09 Apr 2025 11:19:10 -0700 (PDT)
Received: from [127.0.0.1] (master.gitmailbox.com. [34.83.118.50])
by smtp.gmail.com with ESMTPSA id
d2e1a72fcca58-73bb1e383aesm1661531b3a.88.2025.04.09.11.19.10
(version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
Wed, 09 Apr 2025 11:19:10 -0700 (PDT)
Message-Id: <pull.59.v9.ffstaging.FFmpeg.1744222745.ffmpegagent@gmail.com>
In-Reply-To: <pull.59.v8.ffstaging.FFmpeg.1744190716.ffmpegagent@gmail.com>
References: <pull.59.v8.ffstaging.FFmpeg.1744190716.ffmpegagent@gmail.com>
From: ffmpegagent <ffmpegagent@gmail.com>
Date: Wed, 09 Apr 2025 18:19:02 +0000
Fcc: Sent
MIME-Version: 1.0
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH v9 0/3] avutil/log: Add log flag to control
printing of memory addresses
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: softworkz <softworkz@hotmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/pull.59.v9.ffstaging.FFmpeg.1744222745.ffmpegagent@gmail.com/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
--and disable by default in fftools. The benefits are:
* Smaller log file sizes
* Makes log files better readable
* Allows comparing and viewing log file diffs without almost every line
being different due to those addresses
Before
======
[hevc @ 0000018e72a89cc0] nal_unit_type:
[hevc @ 0000018e72a89cc0] Decoding PPS
[hevc @ 0000018e72a89cc0] nal_unit_type: 39(SEI_P.. [hevc @
0000018e72a89cc0] Decoding SEI
[mp4 @ 0000018e72a8e240] All [mp4 @ 0000018e72a8e240] Afte [hevc @
0000018e742f6b40] Decoded frame with POC .. detected 16 logical cores
[Parsed_scale_0 @ 0000018e74382f40] Setting 'w' t.. [Parsed_scale_0 @
0000018e74382f40] Setting 'h' t.. [Parsed_scale_1 @ 0000018e74382440]
Setting 'w' t.. [mjpeg @ 0000018e743210c0] Forcing thread count t.. [mjpeg @
0000018e743210c0] intra_quant_bias = 96
After
=====
[hevc] nal_unit_type: [hevc] Decoding PPS
[hevc] nal_unit_type: 39(SEI_P.. [hevc] Decoding SEI
[mp4] All info found
[mp4] After avformat_find_ [hevc] Decoded frame with POC 2.
[Parsed_scale_0] Setting 'w' t.. [Parsed_scale_0] Setting 'h' t..
[Parsed_scale_1] Setting 'w' t.. [mjpeg] Forcing thread count t.. [mjpeg]
intra_quant_bias = 96
Versions
========
V2
==
* Added log flag for optionally restoring the previous behavior (as
requested by Gyan)
V3
==
* Externalize the prefix formatting with a prefix_format callback
V4
==
* Implement a custom logging callback function for fftools instead of the
prefix formatting callback (as suggested by Hendrik Leppkes)
V5
==
* Remove unused var
* Add missing include to fix build error on PPC (thanks, Michael)
V6
==
* No more changes to avutil involved
* Let fftools have its own management of log level and flags (as figured to
be most likely what Nicolas George was alluding to)
V7
==
* Minimal version without "simple id" substitution
* Defaults for printing mem addresses:
* fftools: off
* avutil: on
V8
==
* Negated flag logic
* Use singular naming
* Fix flag doc text (thanks, Andreas!)
V9
==
* Rename 'memaddress' to 'mem' for CLI (as suggested by Gyan)
softworkz (3):
avutil/log: Add log flag AV_LOG_PRINT_MEMADDRESSES
fftools: add mem log flag and disable printing addresses by default
doc/fftools-common-opts: document mem log flag
doc/APIchanges | 3 +++
doc/fftools-common-opts.texi | 2 ++
fftools/ffmpeg.c | 2 +-
fftools/ffplay.c | 2 +-
fftools/ffprobe.c | 2 +-
fftools/opt_common.c | 6 ++++++
libavutil/log.c | 6 ++++--
libavutil/log.h | 5 +++++
libavutil/version.h | 2 +-
9 files changed, 24 insertions(+), 6 deletions(-)
base-commit: 02eda84bf2fcf0db7793872204b0f564a6557232
Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-59%2Fsoftworkz%2Fsubmit_logaddresses-v9
Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-59/softworkz/submit_logaddresses-v9
Pull-Request: https://github.com/ffstaging/FFmpeg/pull/59
Range-diff vs v8:
1: 0ce5bd11d7 = 1: 0ce5bd11d7 avutil/log: Add log flag AV_LOG_PRINT_MEMADDRESSES
2: 527cf5fa56 ! 2: 0780dd080c fftools: add memaddress log flag and disable printing addresses by default
@@ Metadata
Author: softworkz <softworkz@hotmail.com>
## Commit message ##
- fftools: add memaddress log flag and disable printing addresses by default
+ fftools: add mem log flag and disable printing addresses by default
- This commit adds the memaddress log flag.
+ This commit adds the mem log flag.
When specifying this flag at the command line, context prefixes will
be printed with memory addresses like in earlier ffmpeg versions.
- Example with memaddresses flag:
+ Example with mem flag:
[hevc @ 0000018e72a89cc0] .....
@@ fftools/opt_common.c: int opt_loglevel(void *optctx, const char *opt, const char
} else {
flags |= AV_LOG_PRINT_DATETIME;
}
-+ } else if (av_strstart(token, "memaddress", &arg)) {
++ } else if (av_strstart(token, "mem", &arg)) {
+ if (cmd == '-') {
+ flags |= AV_LOG_NO_PRINT_MEMADDRESS;
+ } else {
3: 22c51897c1 ! 3: bfe2e51860 doc/fftools-common-opts: document memaddress log flag
@@ Metadata
Author: softworkz <softworkz@hotmail.com>
## Commit message ##
- doc/fftools-common-opts: document memaddress log flag
+ doc/fftools-common-opts: document mem log flag
Signed-off-by: softworkz <softworkz@hotmail.com>
@@ doc/fftools-common-opts.texi: log to file.
Indicates that log lines should be prefixed with time information.
@item datetime
Indicates that log lines should be prefixed with date and time information.
-+@item memaddress
++@item mem
+Indicates that context prefixes should be printed with memory address.
@end table
Flags can also be used alone by adding a '+'/'-' prefix to set/reset a single
--
ffmpeg-codebot
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".