From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id 831104C82D
for <ffmpegdev@gitmailbox.com>; Thu, 10 Apr 2025 00:39:17 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 36257687C2E;
Thu, 10 Apr 2025 03:39:13 +0300 (EEST)
Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com
[209.85.214.169])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B0241687B5D
for <ffmpeg-devel@ffmpeg.org>; Thu, 10 Apr 2025 03:39:07 +0300 (EEST)
Received: by mail-pl1-f169.google.com with SMTP id
d9443c01a7336-22409077c06so3301995ad.1
for <ffmpeg-devel@ffmpeg.org>; Wed, 09 Apr 2025 17:39:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1744245545; x=1744850345; darn=ffmpeg.org;
h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from
:references:in-reply-to:message-id:from:to:cc:subject:date
:message-id:reply-to;
bh=jTte5qu7IXNzdyZaQRVgGhgMbdAZiNcgufhkIYwt2+U=;
b=QuWsRyXhdA9wqqk1LiIe/skR9G8BovfGLdYDHLMDPaG8OwhhJHYJhOAoI7MylTpCLF
g4so+2sRfl4pVwyHeuhP57rmzeSSK8WI4QtLzj0mcOIYaSO1WErQ5kdD+joYAsBKibb3
41bohRHijdBvDJQ1KAhCpI9FtXkZ4VRrEYKK+Ls7TbLBDmk+m9fp8GKflShX7+8Nh0iN
hDqGr4cWoqTrERb3GquaQKURuxMgUwQ6AFaulJuS7K1YaOh79/SS18IXKCJSUCvSJEa5
GfHDjOPBKRKK4Lj+m5SY/rsefMyvNV38l9DWHiaLKR/Dp9028P7onY5K1+N9XXiI3qd9
gotA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1744245545; x=1744850345;
h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from
:references:in-reply-to:message-id:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=jTte5qu7IXNzdyZaQRVgGhgMbdAZiNcgufhkIYwt2+U=;
b=I6iNsE3d5w2hzv+tiha8LIBGQ/STnipqXR47Wp6GC3oNeMSjnIg34leud/FuKD2EQa
q+hp6Rmvc5Xv8WzN3P61hpoyfCe7inWR9ie+rNMazEs5piiEmLRhAWVjQ+FTgGZ8Qbo/
W+b2aMjo3XPV9RLyJobmxN6YcVhVH7rEj6H12q0SG0L6lrcZG4zpEjA836Q6HaaUwmDM
vWUeF19Q1SwTILAqDMH4bBeB5UAU+8fsAAB5gHcpf0K9HFVlkA1ml6dIQYxGTcvpaJ0E
ve5qZGkp2xXnkWRkfqhuMXeJ6ims2SQtXNr79xzvcYZ8k3cITdGcG8IkqfznWzFNxmV0
Q7/A==
X-Gm-Message-State: AOJu0YxOxY8jEg4v9Z19S/vD8ruYVA090VdRA9aaGYMO44/QziERK2Yw
CL5thzztUUx9EZnPwqLVTavvh9yO3JPN803FU2XwaiG3/awD5i46yf6cIA==
X-Gm-Gg: ASbGncsVS7ydxwdx4QuMnhmPTueQ9F8CfVh4tzqoCbQpe8dsSI5uXwomNOyVVZ1o4cD
w8ZQKDA7LKB856Zjg/e0F7jwJUH6TsEKpPIZIoZSj+dAq+KLyoj3C9batXIVwGbgdgyPLnsOFDq
ahELkI2nsULoHPyfuQZkEeVvbELgKxKG2qcFKikVECYxRA0PKpvxJrCRDyEgjWdJJTsNNa5KDX5
cE0wAUq00wnupI1vzAyRfIqG+ejiD62YyKKpj9cHe/YH+aUGm+PIA+UnvFX6TE7TJpZRtSAWONm
Z3gm7QRNAAr3siVp+o9p+r1u+PDBoYWQXRYuEJz2hSwCerwbs09UAMZcRRE=
X-Google-Smtp-Source: AGHT+IF5c1/YIAxCXVl3BZh3VgBIcuvmzDIiyN+Jkwl23sBO60rsa0UOY/Di/vdYsczKCsS/RGa1PA==
X-Received: by 2002:a17:902:e5cd:b0:224:192a:9154 with SMTP id
d9443c01a7336-22be032104dmr3080035ad.26.1744245545473;
Wed, 09 Apr 2025 17:39:05 -0700 (PDT)
Received: from [127.0.0.1] (master.gitmailbox.com. [34.83.118.50])
by smtp.gmail.com with ESMTPSA id
d9443c01a7336-22ac7c9da97sm18552735ad.142.2025.04.09.17.39.04
(version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
Wed, 09 Apr 2025 17:39:04 -0700 (PDT)
Message-Id: <pull.59.v10.ffstaging.FFmpeg.1744245539.ffmpegagent@gmail.com>
In-Reply-To: <pull.59.v9.ffstaging.FFmpeg.1744222745.ffmpegagent@gmail.com>
References: <pull.59.v9.ffstaging.FFmpeg.1744222745.ffmpegagent@gmail.com>
From: ffmpegagent <ffmpegagent@gmail.com>
Date: Thu, 10 Apr 2025 00:38:56 +0000
Fcc: Sent
MIME-Version: 1.0
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH v10 0/3] avutil/log: Add log flag to control
printing of memory addresses
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: softworkz <softworkz@hotmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/pull.59.v10.ffstaging.FFmpeg.1744245539.ffmpegagent@gmail.com/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
--and disable by default in fftools. The benefits are:
* Smaller log file sizes
* Makes log files better readable
* Allows comparing and viewing log file diffs without almost every line
being different due to those addresses
Before
======
[hevc @ 0000018e72a89cc0] nal_unit_type:
[hevc @ 0000018e72a89cc0] Decoding PPS
[hevc @ 0000018e72a89cc0] nal_unit_type: 39(SEI_P.. [hevc @
0000018e72a89cc0] Decoding SEI
[mp4 @ 0000018e72a8e240] All [mp4 @ 0000018e72a8e240] Afte [hevc @
0000018e742f6b40] Decoded frame with POC .. detected 16 logical cores
[Parsed_scale_0 @ 0000018e74382f40] Setting 'w' t.. [Parsed_scale_0 @
0000018e74382f40] Setting 'h' t.. [Parsed_scale_1 @ 0000018e74382440]
Setting 'w' t.. [mjpeg @ 0000018e743210c0] Forcing thread count t.. [mjpeg @
0000018e743210c0] intra_quant_bias = 96
After
=====
[hevc] nal_unit_type: [hevc] Decoding PPS
[hevc] nal_unit_type: 39(SEI_P.. [hevc] Decoding SEI
[mp4] All info found
[mp4] After avformat_find_ [hevc] Decoded frame with POC 2.
[Parsed_scale_0] Setting 'w' t.. [Parsed_scale_0] Setting 'h' t..
[Parsed_scale_1] Setting 'w' t.. [mjpeg] Forcing thread count t.. [mjpeg]
intra_quant_bias = 96
Versions
========
V2
==
* Added log flag for optionally restoring the previous behavior (as
requested by Gyan)
V3
==
* Externalize the prefix formatting with a prefix_format callback
V4
==
* Implement a custom logging callback function for fftools instead of the
prefix formatting callback (as suggested by Hendrik Leppkes)
V5
==
* Remove unused var
* Add missing include to fix build error on PPC (thanks, Michael)
V6
==
* No more changes to avutil involved
* Let fftools have its own management of log level and flags (as figured to
be most likely what Nicolas George was alluding to)
V7
==
* Minimal version without "simple id" substitution
* Defaults for printing mem addresses:
* fftools: off
* avutil: on
V8
==
* Negated flag logic
* Use singular naming
* Fix flag doc text (thanks, Andreas!)
V9
==
* Rename 'memaddress' to 'mem' for CLI (as suggested by Gyan)
V10
===
* Print 'mem' flag in help outrput (thanks, Gyan)
softworkz (3):
avutil/log: Add log flag AV_LOG_PRINT_MEMADDRESSES
fftools: add mem log flag and disable printing addresses by default
doc/fftools-common-opts: document mem log flag
doc/APIchanges | 3 +++
doc/fftools-common-opts.texi | 2 ++
fftools/ffmpeg.c | 2 +-
fftools/ffplay.c | 2 +-
fftools/ffprobe.c | 2 +-
fftools/opt_common.c | 7 +++++++
libavutil/log.c | 6 ++++--
libavutil/log.h | 5 +++++
libavutil/version.h | 2 +-
9 files changed, 25 insertions(+), 6 deletions(-)
base-commit: 02eda84bf2fcf0db7793872204b0f564a6557232
Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-59%2Fsoftworkz%2Fsubmit_logaddresses-v10
Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-59/softworkz/submit_logaddresses-v10
Pull-Request: https://github.com/ffstaging/FFmpeg/pull/59
Range-diff vs v9:
1: 0ce5bd11d7 = 1: 0ce5bd11d7 avutil/log: Add log flag AV_LOG_PRINT_MEMADDRESSES
2: 0780dd080c ! 2: 207dedbff6 fftools: add mem log flag and disable printing addresses by default
@@ fftools/opt_common.c: int opt_loglevel(void *optctx, const char *opt, const char
} else {
break;
}
+@@ fftools/opt_common.c: int opt_loglevel(void *optctx, const char *opt, const char *arg)
+ av_log(NULL, AV_LOG_FATAL, "\"level\"\n");
+ av_log(NULL, AV_LOG_FATAL, "\"time\"\n");
+ av_log(NULL, AV_LOG_FATAL, "\"datetime\"\n");
++ av_log(NULL, AV_LOG_FATAL, "\"mem\"\n");
+ return AVERROR(EINVAL);
+ }
+
3: bfe2e51860 = 3: dc334f3eeb doc/fftools-common-opts: document mem log flag
--
ffmpeg-codebot
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".