From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 94B1F48D06 for ; Thu, 27 Feb 2025 16:37:21 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3661668D3AC; Thu, 27 Feb 2025 18:37:16 +0200 (EET) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9552968D2FF for ; Thu, 27 Feb 2025 18:37:04 +0200 (EET) Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-223480ea43aso29465525ad.1; Thu, 27 Feb 2025 08:37:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740674222; x=1741279022; darn=ffmpeg.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date :references:in-reply-to:message-id:from:from:to:cc:subject:date :message-id:reply-to; bh=18uRzf5CC6QC3aRZzy+ZrGaiPGJx/ukor7kOqulneUY=; b=B65Ex04P7v0IFS8Satrbk0qmiQ9mLWvB2Nvhs8wxB7KiIpbcgF8q72bAt8LBfrjkWR omEsa0w3ATXAFZ2NLqUuFKsHGUHxLCWGzq8kOd6r7YuCEBrz/wrCE5V4e+BKYO/xTe0J dU+ScjlyPFKbgmZDGOkowi0coZXsY/7hEFHvo1AqvtvVA2T0cW+kOLIi/59cxExtKRpF Ks+M6ukCjSYJfc335Dj4QYBWIyaI1uSYZ66MjgSqo6LRrXt56OAturyVlrl2lcduvWjd fMIFgf7fKpj0tirfZFHUP7dkdEcLsG+Lv+O2d2b8OUQa5aRrexlIW1wwuMZeMu/aJKI/ y/pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740674222; x=1741279022; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date :references:in-reply-to:message-id:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=18uRzf5CC6QC3aRZzy+ZrGaiPGJx/ukor7kOqulneUY=; b=pIObiSIQQHdA6zzlXrn2rXq/IOWvWxW4KSZr7HGIBQKHkF4bi5LdnXvpJp9rbKifoC jmrVk/N5vZ1+g37z+I/UzChDqMFqc6gz8+ux2UG59ejnzjp3JhpLHvZQCKdPcbITIdiM Hgrp1ySN3P2n/C2yio7S6LHBf92IUPfYMhO6XlZ8BxAgRTpswLseft8cpr49xv2Ae4Is WFp6fMuC+MTf2RQ5GVDY1P4SWDaK56ecI7qG/VhJzMRGmG4MbhofgZrUD2mWt/5Dxl+f tZsEc1GvwF8p43EKhz3iwN5cVHu1eFBYDP+/uRnjhsSjB8B6MEQXlv72j8U7u6yrpfW/ hbqA== X-Gm-Message-State: AOJu0YzMu0dpPkuVsgbXhv0g90T13qyaiSOMbwbsGwc35n9gKyDjfdJU TOIs1oh2hMOr8QceGnLV+5YMdMivXAw8fVnAtaZLp1xIaia74N2liw03fQ== X-Gm-Gg: ASbGncuRtkDtosMzICsGSKqLNK/xBinja0METwQpOgQERx++g95zot5PRNqlwteXea0 tHeR3Hj1RtJO3hI+OEBaUPcA2f5l2nYLRCyFXcHJZYCXGXmN9lzy2L7KeQ65V5UgyVn9M4i3C7e Qd7qrVTK6qLtN59mQAISjUKUFrE0fxCAIbcqfclOhvKh6BcBCkspj/or9bEIWZyhwsdUX00Nhcq Sha1RoCcGpXGIQTJ8fFJNjXencf9WZih0tQ76lEXNs6yuySw0PySxCFAudB9yZCPqAY15CSIsw+ ZNOVJpKvcuYQe1kUo2h+97TZIM4ljq+FWGaO758qDSpB X-Google-Smtp-Source: AGHT+IFkrXpTgB5UkVZoD9EKX39ijsAc85kvsGFTc3Tp/vbdbJQRAcqdqqiJAjiyFJj4ZgCqagB9mA== X-Received: by 2002:a05:6a20:4394:b0:1f2:ed39:13f5 with SMTP id adf61e73a8af0-1f2ed3914e5mr2865645637.20.1740674222267; Thu, 27 Feb 2025 08:37:02 -0800 (PST) Received: from [127.0.0.1] (master.gitmailbox.com. [34.83.118.50]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-aee7de3c4d4sm1477214a12.46.2025.02.27.08.37.01 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Feb 2025 08:37:01 -0800 (PST) From: softworkz X-Google-Original-From: softworkz Message-Id: In-Reply-To: References: Date: Thu, 27 Feb 2025 16:36:56 +0000 Fcc: Sent MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH v2] avformat/hls: Partially revert "reduce default max reload to 3" X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Michael Niedermayer , Steven Liu , Soft Works , softworkz Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: From: softworkz (setting to 100 as a reasonable compromise) The change has caused regressions for many users and consumers. Playlist reloads only happen when a playlist doesn't indicate that it has ended (via #EXT-X-ENDLIST), which means that the addition of future segments is still expected. It is well possible that an HLS server is temporarily unable to serve further segments but resumes after some time, either indicating a discontinuity or even by fully catching up. With a segment length of 3s, a max_reload value of 1000 corresponds to a duration of 50 minutes which appears to be a reasonable default. --- avformat/hls: Partially revert "reduce default max reload to 3" This change has caused regressions for many users and consumers. Playlist reloads only happen when a playlist doesn't indicate that it has ended (via #EXT-X-ENDLIST), which means that the addition of future segments is still expected. It is well possible that an HLS server is temporarily unable to serve further segments but resumes after some time, either indicating a discontinuity or even by fully catching up. With a segment length of 3s, a max_reload value of 1000 corresponds to a duration of 50 minutes which appears to be a reasonable default. V2 * reduced from 1000 to 100 (halfway) according to Michael's calcularion :-) Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-51%2Fsoftworkz%2Fsubmit_hls_reload-v2 Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-51/softworkz/submit_hls_reload-v2 Pull-Request: https://github.com/ffstaging/FFmpeg/pull/51 Range-diff vs v1: 1: cc92f8691b ! 1: e960ffab23 avformat/hls: Revert "reduce default max reload to 3" @@ Metadata Author: softworkz ## Commit message ## - avformat/hls: Revert "reduce default max reload to 3" + avformat/hls: Partially revert "reduce default max reload to 3" - This change has caused regressions for many users and consumers. + (setting to 100 as a reasonable compromise) + + The change has caused regressions for many users and consumers. Playlist reloads only happen when a playlist doesn't indicate that it has ended (via #EXT-X-ENDLIST), which means that the addition of future segments is still expected. @@ libavformat/hls.c: static const AVOption hls_options[] = { INT_MIN, INT_MAX, FLAGS}, {"max_reload", "Maximum number of times a insufficient list is attempted to be reloaded", - OFFSET(max_reload), AV_OPT_TYPE_INT, {.i64 = 3}, 0, INT_MAX, FLAGS}, -+ OFFSET(max_reload), AV_OPT_TYPE_INT, {.i64 = 1000}, 0, INT_MAX, FLAGS}, ++ OFFSET(max_reload), AV_OPT_TYPE_INT, {.i64 = 100}, 0, INT_MAX, FLAGS}, {"m3u8_hold_counters", "The maximum number of times to load m3u8 when it refreshes without new segments", OFFSET(m3u8_hold_counters), AV_OPT_TYPE_INT, {.i64 = 1000}, 0, INT_MAX, FLAGS}, {"http_persistent", "Use persistent HTTP connections", libavformat/hls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 045741c3b4..116dfcae95 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -2577,7 +2577,7 @@ static const AVOption hls_options[] = { {.str = "3gp,aac,avi,ac3,eac3,flac,mkv,m3u8,m4a,m4s,m4v,mpg,mov,mp2,mp3,mp4,mpeg,mpegts,ogg,ogv,oga,ts,vob,wav"}, INT_MIN, INT_MAX, FLAGS}, {"max_reload", "Maximum number of times a insufficient list is attempted to be reloaded", - OFFSET(max_reload), AV_OPT_TYPE_INT, {.i64 = 3}, 0, INT_MAX, FLAGS}, + OFFSET(max_reload), AV_OPT_TYPE_INT, {.i64 = 100}, 0, INT_MAX, FLAGS}, {"m3u8_hold_counters", "The maximum number of times to load m3u8 when it refreshes without new segments", OFFSET(m3u8_hold_counters), AV_OPT_TYPE_INT, {.i64 = 1000}, 0, INT_MAX, FLAGS}, {"http_persistent", "Use persistent HTTP connections", base-commit: ced9fddec0e45e1ce1b3425a1fed66af971e934c -- ffmpeg-codebot _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".