From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 7A0D14572E for ; Sun, 19 Jan 2025 08:52:51 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A971668B1A1; Sun, 19 Jan 2025 10:52:47 +0200 (EET) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 645D968B056 for ; Sun, 19 Jan 2025 10:52:41 +0200 (EET) Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2163dc5155fso64299015ad.0 for ; Sun, 19 Jan 2025 00:52:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737276759; x=1737881559; darn=ffmpeg.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date :message-id:from:from:to:cc:subject:date:message-id:reply-to; bh=fapqJsf7NuRf6gON/NXxiw4lkhNGF/mu2cQuoiVcae0=; b=Tcf6fr6KG7SI6V/lDBYa3nT/ECkSAh9a4r4O2t6OGORUAeJRqwIzu0B8j51CYTz15f jTQwr6eQP8EezWSimr6gCPimlY4kEWGcTvZb/72it6BzTQo4euP0LP2cewnqRBQ4yIx1 Akwv295FJHbf+bhVnDdegD39o7e/beq0bgDuep1qUYliiiyQGYTfX6yx2cC/WauOe1Ze pYMVRg2VRwnmWj5/xGqKseju9iiG1P50uhahM6pfSkBOzkRInWxJqQ/w2SCF4Euy3mzR H80sXMF1Ov8ImHMBmRcMmEF5Reash6BhzSaBAL0vQgj9IFEsN2chL3TfYccl+2Ku+/7F 3BIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737276759; x=1737881559; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date :message-id:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fapqJsf7NuRf6gON/NXxiw4lkhNGF/mu2cQuoiVcae0=; b=SF2ZG5el3Us5mwE9tLPlQJimPfU9KWxLojXNJXJboqpOpjfiaE2I9CLqysF96dNdVn 217CPowjoy/jipuroxB+cUPIwJmKjUaMzSkq8UaKnTpGV2WrlT3e1OQFOBxtFcRhNfh1 Ewj8a+xoW020m2peb8A/7d/B8UUlYl3dypWB+0MSDXDZs+P60h9hRxgx2IiLLeLt2idB nFYEnrGGDCq992KMMby3DSU8QZedPlY34e/Nj1R0vzwGPzHV+zfRcVggB149SjRANSkj 0ScypscyDpSPQRUCBlX2MP/6WcjNJGmEpBJfEJkA7YISvZMvc8MYOO70mXhZLm+459EP uI/A== X-Gm-Message-State: AOJu0Yzdmp3JBRt6wTYw5QesSXfiM5mlMTbOmqlvpuaj+iJgha1HX42p cwNVvvUbUuco6AjbVO/heEv79g+YwYK8nOm6QZ3nI9/WgMwMWe75UNtVUg== X-Gm-Gg: ASbGncs83wMW7BzRGvCFA4PuZF3RJdIHIRsyAWkK0gOpgmw/5wZo7Ch1DLnEd36GgQ4 Zsic7+mx3H0lLDsKtQpDTndQ+LIkEBmmtE4bY2CnyIS1a7EisgGVED8Y03qL6XNTmVn+Q/HqMoo F0sjJOvDNqY20VYUaHx+kS43NPPmBUNFmm/UhuphGdRi+Qv8j96V3z+GAt/az2Whpz74wJySq6i gsshz5LEyCP8VQS+Q4XDxCJls5SuLihp1ylCxhgznrkVUAS7yrfGTydETTuWVtnA2cfBU448ehM 2B75yFMMoog8 X-Google-Smtp-Source: AGHT+IF8Kl0pkPyJBWbC5AXn9sw3iueH82EyHEgEdjFYjYmSQuyAbuABoLTFG00kBE55VsqAQThwHQ== X-Received: by 2002:a05:6a21:32a3:b0:1e1:ac71:2b6a with SMTP id adf61e73a8af0-1eb21568540mr12261355637.28.1737276759418; Sun, 19 Jan 2025 00:52:39 -0800 (PST) Received: from [127.0.0.1] (master.gitmailbox.com. [34.83.118.50]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72dab9c8ed3sm4816599b3a.113.2025.01.19.00.52.38 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 19 Jan 2025 00:52:39 -0800 (PST) From: softworkz X-Google-Original-From: softworkz Message-Id: Date: Sun, 19 Jan 2025 08:52:38 +0000 Fcc: Sent MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH] avformat/hls: Revert "reduce default max reload to 3" X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: softworkz Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: From: softworkz This change has caused regressions for many users and consumers. Playlist reloads only happen when a playlist doesn't indicate that it has ended (via #EXT-X-ENDLIST), which means that the addition of future segments is still expected. It is well possible that an HLS server is temporarily unable to serve further segments but resumes after some time, either indicating a discontinuity or even by fully catching up. With a segment length of 3s, a max_reload value of 1000 corresponds to a duration of 50 minutes which appears to be a reasonable default. --- avformat/hls: Revert "reduce default max reload to 3" This change has caused regressions for many users and consumers. Playlist reloads only happen when a playlist doesn't indicate that it has ended (via #EXT-X-ENDLIST), which means that the addition of future segments is still expected. It is well possible that an HLS server is temporarily unable to serve further segments but resumes after some time, either indicating a discontinuity or even by fully catching up. With a segment length of 3s, a max_reload value of 1000 corresponds to a duration of 50 minutes which appears to be a reasonable default. Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-51%2Fsoftworkz%2Fsubmit_hls_reload-v1 Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-51/softworkz/submit_hls_reload-v1 Pull-Request: https://github.com/ffstaging/FFmpeg/pull/51 libavformat/hls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 045741c3b4..426cf30f70 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -2577,7 +2577,7 @@ static const AVOption hls_options[] = { {.str = "3gp,aac,avi,ac3,eac3,flac,mkv,m3u8,m4a,m4s,m4v,mpg,mov,mp2,mp3,mp4,mpeg,mpegts,ogg,ogv,oga,ts,vob,wav"}, INT_MIN, INT_MAX, FLAGS}, {"max_reload", "Maximum number of times a insufficient list is attempted to be reloaded", - OFFSET(max_reload), AV_OPT_TYPE_INT, {.i64 = 3}, 0, INT_MAX, FLAGS}, + OFFSET(max_reload), AV_OPT_TYPE_INT, {.i64 = 1000}, 0, INT_MAX, FLAGS}, {"m3u8_hold_counters", "The maximum number of times to load m3u8 when it refreshes without new segments", OFFSET(m3u8_hold_counters), AV_OPT_TYPE_INT, {.i64 = 1000}, 0, INT_MAX, FLAGS}, {"http_persistent", "Use persistent HTTP connections", base-commit: ced9fddec0e45e1ce1b3425a1fed66af971e934c -- ffmpeg-codebot _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".