From: Aman Karmani <ffmpegagent@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Aman Karmani <aman@tmm1.net>,
Andriy Gelman <andriy.gelman@gmail.com>,
Ming Qian <ming.qian@nxp.com>, John Cox <jc@kynesim.co.uk>
Subject: [FFmpeg-devel] [PATCH] avcodec/v4l2_m2m: log both v4l2 and av pixel formats during negotiation
Date: Mon, 09 Jan 2023 20:30:06 +0000
Message-ID: <pull.47.ffstaging.FFmpeg.1673296206887.ffmpegagent@gmail.com> (raw)
From: Aman Karmani <aman@tmm1.net>
Signed-off-by: Aman Karmani <aman@tmm1.net>
---
avcodec/v4l2_m2m: log both v4l2 and av pixel formats during negotiation
Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-47%2Ftmm1%2Fv4l2-dbg-v1
Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-47/tmm1/v4l2-dbg-v1
Pull-Request: https://github.com/ffstaging/FFmpeg/pull/47
libavcodec/v4l2_m2m.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/libavcodec/v4l2_m2m.c b/libavcodec/v4l2_m2m.c
index 984936004d..602efb7a16 100644
--- a/libavcodec/v4l2_m2m.c
+++ b/libavcodec/v4l2_m2m.c
@@ -148,13 +148,15 @@ static int v4l2_configure_contexts(V4L2m2mContext *s)
ofmt = s->output.format;
cfmt = s->capture.format;
- av_log(log_ctx, AV_LOG_INFO, "requesting formats: output=%s capture=%s\n",
+ av_log(log_ctx, AV_LOG_INFO, "requesting formats: output=%s/%s capture=%s/%s\n",
av_fourcc2str(V4L2_TYPE_IS_MULTIPLANAR(ofmt.type) ?
ofmt.fmt.pix_mp.pixelformat :
ofmt.fmt.pix.pixelformat),
+ av_get_pix_fmt_name(s->output.av_pix_fmt) ?: "none",
av_fourcc2str(V4L2_TYPE_IS_MULTIPLANAR(cfmt.type) ?
cfmt.fmt.pix_mp.pixelformat :
- cfmt.fmt.pix.pixelformat));
+ cfmt.fmt.pix.pixelformat),
+ av_get_pix_fmt_name(s->capture.av_pix_fmt) ?: "none");
ret = ff_v4l2_context_set_format(&s->output);
if (ret) {
base-commit: 94aa70d757af6b0e0919250f9def2a819aa00358
--
ffmpeg-codebot
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
reply other threads:[~2023-01-09 20:30 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.47.ffstaging.FFmpeg.1673296206887.ffmpegagent@gmail.com \
--to=ffmpegagent@gmail.com \
--cc=aman@tmm1.net \
--cc=andriy.gelman@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=jc@kynesim.co.uk \
--cc=ming.qian@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git