From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0138D43235 for ; Wed, 25 May 2022 09:31:20 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 06AFF68B4E7; Wed, 25 May 2022 12:31:18 +0300 (EEST) Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1B3CD68B34E for ; Wed, 25 May 2022 12:31:12 +0300 (EEST) Received: by mail-pj1-f50.google.com with SMTP id q92-20020a17090a17e500b001e0817e77f6so1153603pja.5 for ; Wed, 25 May 2022 02:31:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:message-id:in-reply-to:references:date:subject:fcc :content-transfer-encoding:mime-version:to:cc; bh=/AFsWv6kT+LqwvSwr+XBbUytIPL5Jn++VehJfnqiw28=; b=TYM9dNN0WtPOWDpXu5i1GhrduztvUn7XLk4QJ8BpZ+e71SMxUJJvxEcxQLkY/+PjPe VRR+P9X0lYdYT5chiy8Jv3XYJgDMsTfxRa9q3sSLQTwRSRmss+dR8IUqrFxFGX2uQUeJ t9ZYFM7m0tf9DqPOvCEWkk0wwrnirJHmmoPzbYAHnfIlXYWTte3vgVs4yjXkvx8uRK7d hyiQOqENEsf1BTqy2k3o134a6bgFODBdyB9BVrF+13+qIQsB/WLHUYsT1MPIRaS03ugl jH/LjJ/m0M9b4BIrVIv+mudU9UKaoQRqYs23j8b9sHuVs7FG1QlBEaiZYCZ5rxgR+gN5 4NuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:message-id:in-reply-to:references:date :subject:fcc:content-transfer-encoding:mime-version:to:cc; bh=/AFsWv6kT+LqwvSwr+XBbUytIPL5Jn++VehJfnqiw28=; b=NzhUsL5zzqHoFz1SUOhHaeHj7Uk9Eax0XcUp43hpYsMOHPOYlbgGcoz1L6bFAol16b JpugNypA7V1DZt39uujM4LSDfqSW9DfebxfC9EavGnd4nU7u6gWhbKtY1leUzrYP7M3G y4OKyAVqQxlYVSaoDUu8DP5zrAzz2irwWjarA+YIqVLdvBdCkXcKforN/zBPlc9iB/hm b0tudeqUkJOwzgZtlDQQgRfX7GJABNfGmFMNuXxh42DDTlK1zRojqAZ3KKFGzeHfundT ZPnOU4mMWDjB06ci6AHm9dSaQNBBZ8CK+RkZIZuHNyrU4hB9Hgiaf+Bfjbd7FGxTCYOz mv/g== X-Gm-Message-State: AOAM530i6Cf/oBBLmOq5KQmoOo/4UFuRzHaOv8U1pyvzSSfr7/aI/F5j kkI5XHmbOYQtj7pCq+fr+tx7Pvd8Upxn9Q== X-Google-Smtp-Source: ABdhPJxk6vKH70pg498xRSemEMUlt8rJ+najHwa5eD/aXrkq0OH54EiF0f843v1GwA8sDk0QhT0DzQ== X-Received: by 2002:a17:902:d2c8:b0:161:bc97:2805 with SMTP id n8-20020a170902d2c800b00161bc972805mr32625548plc.4.1653471069512; Wed, 25 May 2022 02:31:09 -0700 (PDT) Received: from [127.0.0.1] (master.gitmailbox.com. [34.83.118.50]) by smtp.gmail.com with ESMTPSA id f12-20020a170902e98c00b001614cd997a8sm1786356plb.236.2022.05.25.02.31.08 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 May 2022 02:31:09 -0700 (PDT) From: softworkz X-Google-Original-From: softworkz Message-Id: In-Reply-To: References: Date: Wed, 25 May 2022 09:31:07 +0000 Fcc: Sent MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH v2] libx264: Set min build version to 158 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: softworkz Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: From: softworkz Was "[PATCH] libx264: Do not explicitly set X264_API_IMPORTS" Setting X264_API_IMPORTS only affects msvc builds and it breaks linking to static builds (although is required for shared builds). This flag is set by x264 in its pkgconfig as required since build 158 (a615f027ed172e2dd5380e736d487aa858a0c4ff) from July 2019. So this patch updates configure to require a newer x264 build that correctly sets the imports flag. The requirement for 158 is applied for msvc builds only, no change is made for all other cases. Co-authored-by: softworkz Signed-off-by: softworkz Signed-off-by: Matt Oliver --- libx264: Set min build version to 158 I'm submitting this patch on behalf of Matt with his permission. There was agreement that the >= 158 version requirement should be applied to MSVC builds only. v2: restrict the version requirement to msvc builds Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-30%2Fsoftworkz%2Fsubmit_x264_api_imports_matt-v2 Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-30/softworkz/submit_x264_api_imports_matt-v2 Pull-Request: https://github.com/ffstaging/FFmpeg/pull/30 Range-diff vs v1: 1: bbe97f5e1b ! 1: 1696684de3 libx264: Set min build version to 158 @@ ## Metadata ## -Author: Matt Oliver +Author: softworkz ## Commit message ## libx264: Set min build version to 158 @@ Commit message So this patch updates configure to require a newer x264 build that correctly sets the imports flag. - Alternatively we can detect the x264 build version in configure - and keep the fallback of manually setting the flag on older x264 - builds that arent using pkgconfig (to keep the old behaviour) but - that requires some complex configure changes. + The requirement for 158 is applied for msvc builds only, + no change is made for all other cases. - Submitted-by: softworkz + Co-authored-by: softworkz + Signed-off-by: softworkz Signed-off-by: Matt Oliver ## configure ## @@ configure: enabled libvpx && { - require_cpp_condition libx264 x264.h "X264_BUILD >= 118" && - check_cpp_condition libx262 x264.h "X264_MPEG2" +enabled libx264 && check_pkg_config libx264 x264 "stdint.h x264.h" x264_encoder_encode && -+ require_cpp_condition libx264 x264.h "X264_BUILD >= 158" ++ require_cpp_condition libx264 x264.h "X264_BUILD >= 158" || ++ { "$toolchain" != msvc && require_cpp_condition libx264 x264.h "X264_BUILD >= 118"; } enabled libx265 && require_pkg_config libx265 x265 x265.h x265_api_get && require_cpp_condition libx265 x265.h "X265_BUILD >= 70" enabled libxavs && require libxavs "stdint.h xavs.h" xavs_encoder_encode "-lxavs $pthreads_extralibs $libm_extralibs" configure | 8 +++----- libavcodec/libx264.c | 4 ---- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/configure b/configure index f115b21064..9de9b7763a 100755 --- a/configure +++ b/configure @@ -6656,11 +6656,9 @@ enabled libvpx && { enabled libwebp && { enabled libwebp_encoder && require_pkg_config libwebp "libwebp >= 0.2.0" webp/encode.h WebPGetEncoderVersion enabled libwebp_anim_encoder && check_pkg_config libwebp_anim_encoder "libwebpmux >= 0.4.0" webp/mux.h WebPAnimEncoderOptionsInit; } -enabled libx264 && { check_pkg_config libx264 x264 "stdint.h x264.h" x264_encoder_encode || - { require libx264 "stdint.h x264.h" x264_encoder_encode "-lx264 $pthreads_extralibs $libm_extralibs" && - warn "using libx264 without pkg-config"; } } && - require_cpp_condition libx264 x264.h "X264_BUILD >= 118" && - check_cpp_condition libx262 x264.h "X264_MPEG2" +enabled libx264 && check_pkg_config libx264 x264 "stdint.h x264.h" x264_encoder_encode && + require_cpp_condition libx264 x264.h "X264_BUILD >= 158" || + { "$toolchain" != msvc && require_cpp_condition libx264 x264.h "X264_BUILD >= 118"; } enabled libx265 && require_pkg_config libx265 x265 x265.h x265_api_get && require_cpp_condition libx265 x265.h "X265_BUILD >= 70" enabled libxavs && require libxavs "stdint.h xavs.h" xavs_encoder_encode "-lxavs $pthreads_extralibs $libm_extralibs" diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index 4ce3791ae8..14177b3016 100644 --- a/libavcodec/libx264.c +++ b/libavcodec/libx264.c @@ -37,10 +37,6 @@ #include "atsc_a53.h" #include "sei.h" -#if defined(_MSC_VER) -#define X264_API_IMPORTS 1 -#endif - #include #include #include base-commit: b033913d1c5998a29dfd13e9906dd707ff6eff12 -- ffmpeg-codebot _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".