From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3EB7F403E3 for ; Sat, 23 Jul 2022 14:03:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EFDF568B701; Sat, 23 Jul 2022 17:03:33 +0300 (EEST) Received: from a3.inai.de (a3.inai.de [88.198.85.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9367B68B5F2 for ; Sat, 23 Jul 2022 17:03:27 +0300 (EEST) Received: by a3.inai.de (Postfix, from userid 25121) id B4650588946B7; Sat, 23 Jul 2022 16:03:26 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by a3.inai.de (Postfix) with ESMTP id B32A9610478BD for ; Sat, 23 Jul 2022 16:03:26 +0200 (CEST) Date: Sat, 23 Jul 2022 16:03:26 +0200 (CEST) From: Jan Engelhardt To: FFmpeg development discussions and patches In-Reply-To: Message-ID: References: <32p7s1q2-7prs-1189-49p4-30n507437p2@vanv.qr> User-Agent: Alpine 2.25 (LSU 592 2021-09-18) MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] ABI break in 5.1 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Saturday 2022-07-23 15:28, Nicolas George wrote: >Jan Engelhardt (12022-07-23): >> >> This is a follow-up to a topic that was already raised earlier, >> http://ffmpeg.org/pipermail/ffmpeg-devel/2020-July/265694.html >> >> The same has now happened to 5.0->5.1. > >I do not see an issue. What issue do you see? As I have previously explained, [ http://ffmpeg.org/pipermail/ffmpeg-devel/2020-July/265705.html ] >"""A program may have been built with 4.3 but is combined >with 4.2.3 at runtime, then this can happen:""" (Or, in today's terms, a program built with 5.1 but which is combined with 5.0 at runtime, then this can happen: $ ./a.out ./a.out: symbol lookup error: ./a.out: undefined symbol: avio_vprintf, version LIBAVFORMAT_59 Now, it was clear that >"""Running against an older version then the build version is never >supported > >A distribution should never allow this to happen.""" This is exactly what we're trying to do. ELF symbol version definitions are *the* tool to do this, but we keep getting screwed over by terrible symbol version management in ffmpeg. libavformat.v advertises a verdef (that one being "LIBAVUTIL_59" currently), but you keep modifying the set of symbols, such as dropping avio_vprintf. Minus that bug, libavformat.v is but used to do symbol visibility. For which you don't need a verdef, for starters. diff --git a/libavutil/libavutil.v b/libavutil/libavutil.v index fb17058df5..54dbc84e9a 100644 --- a/libavutil/libavutil.v +++ b/libavutil/libavutil.v @@ -1,4 +1,4 @@ -LIBAVUTIL_MAJOR { +{ global: av*; local: _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".