Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Jan Engelhardt <jengelh@inai.de>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] ABI break in 5.1
Date: Sat, 23 Jul 2022 16:03:26 +0200 (CEST)
Message-ID: <o5roo936-3124-4169-12q2-n881n2138np@vanv.qr> (raw)
In-Reply-To: <Ytv3kBWu2XSvGMKU@phare.normalesup.org>

On Saturday 2022-07-23 15:28, Nicolas George wrote:

>Jan Engelhardt (12022-07-23):
>> 
>> This is a follow-up to a topic that was already raised earlier,
>> http://ffmpeg.org/pipermail/ffmpeg-devel/2020-July/265694.html 
>> 
>> The same has now happened to 5.0->5.1.
>
>I do not see an issue. What issue do you see?

As I have previously explained,
[ http://ffmpeg.org/pipermail/ffmpeg-devel/2020-July/265705.html ]

>"""A program may have been built with 4.3 but is combined
>with 4.2.3 at runtime, then this can happen:"""

(Or, in today's terms, a program built with 5.1 but which is
combined with 5.0 at runtime, then this can happen:

$ ./a.out 
./a.out: symbol lookup error: ./a.out: undefined symbol: avio_vprintf, 
version LIBAVFORMAT_59

Now, it was clear that

>"""Running against an older version then the build version is never
>supported
>
>A distribution should never allow this to happen."""

This is exactly what we're trying to do. ELF symbol version definitions 
are *the* tool to do this, but we keep getting screwed over by terrible 
symbol version management in ffmpeg.

libavformat.v advertises a verdef (that one being "LIBAVUTIL_59" 
currently), but you keep modifying the set of symbols, such as dropping 
avio_vprintf.

Minus that bug, libavformat.v is but used to do symbol 
visibility. For which you don't need a verdef, for starters.

diff --git a/libavutil/libavutil.v b/libavutil/libavutil.v
index fb17058df5..54dbc84e9a 100644
--- a/libavutil/libavutil.v
+++ b/libavutil/libavutil.v
@@ -1,4 +1,4 @@
-LIBAVUTIL_MAJOR {
+{
     global:
         av*;
     local:

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2022-07-23 14:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-23 13:23 Jan Engelhardt
2022-07-23 13:28 ` Nicolas George
2022-07-23 14:03   ` Jan Engelhardt [this message]
2022-07-23 14:32     ` Nicolas George
2022-07-23 17:36       ` Jan Engelhardt
2022-07-23 17:39         ` Nicolas George
2022-07-23 20:36     ` Jean-Baptiste Kempf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=o5roo936-3124-4169-12q2-n881n2138np@vanv.qr \
    --to=jengelh@inai.de \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git