From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id A9A465017F for ; Tue, 8 Jul 2025 18:33:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 8BB9F68F19A; Tue, 8 Jul 2025 21:33:45 +0300 (EEST) References: <20250708181532.60440-1-epirat07@gmail.com> In-Reply-To: <20250708181532.60440-1-epirat07@gmail.com> Date: Tue, 8 Jul 2025 19:33:29 +0100 To: FFmpeg development discussions and patches MIME-Version: 1.0 Message-ID: List-Id: FFmpeg development discussions and patches List-Post: From: Kieran Kunhya via ffmpeg-devel Precedence: list Cc: Kieran Kunhya X-Mailman-Version: 2.1.29 X-BeenThere: ffmpeg-devel@ffmpeg.org List-Subscribe: , List-Unsubscribe: , List-Archive: Reply-To: FFmpeg development discussions and patches List-Help: Subject: Re: [FFmpeg-devel] [PATCH] avformat/rtsp: fix leak of options dict on error Content-Type: multipart/mixed; boundary="===============2328028797251686266==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2328028797251686266== Content-Type: message/rfc822 Content-Disposition: inline Return-Path: X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-yw1-f176.google.com (mail-yw1-f176.google.com [209.85.128.176]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 1CC9C68EF2D for ; Tue, 8 Jul 2025 21:33:41 +0300 (EEST) Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-710e344bbf9so43196267b3.2 for ; Tue, 08 Jul 2025 11:33:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20230601; t=1751999620; x=1752604420; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=wtXoS6oY/eMVnl0gFsB74qsDGPSe96HeXqRa0xoIwk4=; b=jjH9oCdFDk00pbefD17s5yByj+3Mz6TmL5llYkU93iFEaOwAP0BXoxkAY1qrA6J0ta vLa4/QypwEVNT8jLXw3OwD7fUWZOU5u5WxKix78CRkSGrvxDsij5jZrxr2xvcodgI+ZU vrciG+L80dvurCKYaGAkOP47ok6F7KjnIvi5RLPSibm2rCZ13SntPlQnZmqsZzPQQWxD C8tF/lIWTAGb7mPURDokFrl39utLkG2Yr8K35l6aFQtK0wImQ5XdZvEI6nsu3CXrm9gc nzEl7p0VxZQs1TrABxxAhBqBH82/wDn9w5lk6TRhWkLDlhL76eHXRmz/moW0nDTYCOQD yVoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751999620; x=1752604420; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wtXoS6oY/eMVnl0gFsB74qsDGPSe96HeXqRa0xoIwk4=; b=C8zw9UsdBj1jIBaCJ2uvij8/J9EIaJ1oOiFUoun6Dk2r9N0VMFrHoaURGSm90SQfCL 8R9fzIJX/MogVNERBGS2UW6YO6/DfsJtpvtYmA8zT37dBJ506LQiyS3u6P3TC2MNAnmZ 9TVk1x/oP7swf7WR/2btE5Tv2ctLjaB8D9BJofO8BNvmPafQhRsvVjd1YMbeehr4ckc2 V5DWarhv98ER9b7noa89v2PZ2aeEJy1UmlmKuCYFqkFn1igQqH4kxTSVrs65JKbsoicD 1SOfqE3qD32y02vYoyt70mnwwWNtwSN78OdLZm1Yvk4kiWBaImYPOzP4SOpNhf7AG61D gM7Q== X-Gm-Message-State: AOJu0Yzyp9SsqjjWVn2ur5rZl40kISiatGVH2EImwgsityK1zwnfcKYP R7ePXvYdnZQW0o5mAkFs1/cxthX9Gcl88WidzlxIb+u20c4+mf1nPtv149LKpX2Inamzk345xXH b53ZtSUFL4hs3jiafktVfDt80oiKk4LVX5A== X-Gm-Gg: ASbGncvZmstAvVGMuJxu90VrIvG75Nu5tRrvnsuPBHfb7LcgOy9OBNWfLO0oZTc5xY1 j+EZy8rBESekalChrH8VVDCkvNz+TAQ1RMybzQUUbQMy3+r8KbBpE69kNmkui9On2ZbooSWz9sC g5qoo5UBwEhoPuDabCWLMWIaWmQ9kO8POhtlWQi5Y5gIE= X-Google-Smtp-Source: AGHT+IG1qUomBrYd0RwNBuBScKVwey4KemRGGP32zwvGvzr7mh3at8w0qYy6ILipxIIZAUkc+kKOUvz4AqmkKerd1Mg= X-Received: by 2002:a05:690c:640d:b0:70c:a57c:94a3 with SMTP id 00721157ae682-7166b6cd964mr239313917b3.19.1751999620283; Tue, 08 Jul 2025 11:33:40 -0700 (PDT) MIME-Version: 1.0 References: <20250708181532.60440-1-epirat07@gmail.com> In-Reply-To: <20250708181532.60440-1-epirat07@gmail.com> From: Kieran Kunhya Date: Tue, 8 Jul 2025 19:33:29 +0100 X-Gm-Features: Ac12FXxIOYz1W0rnL5PnxlH_gK1Xfd_lSYY9J0pGZCRwRrTqIPyH1IZHdlbLL48 Message-ID: Subject: Re: [FFmpeg-devel] [PATCH] avformat/rtsp: fix leak of options dict on error To: FFmpeg development discussions and patches Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 On Tue, 8 Jul 2025, 19:15 Marvin Scholz, wrote: > Fix CID 1655306 > --- > libavformat/rtsp.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c > index 8d360b375f..0810c56a8b 100644 > --- a/libavformat/rtsp.c > +++ b/libavformat/rtsp.c > @@ -1847,6 +1847,7 @@ redirect: > /* GET requests */ > if (ffurl_alloc(&rt->rtsp_hd, httpname, AVIO_FLAG_READ, > &s->interrupt_callback) < 0) { > + av_dict_free(&options); > err = AVERROR(EIO); > goto fail; > } > @@ -1863,6 +1864,7 @@ redirect: > if (!rt->rtsp_hd->protocol_whitelist && s->protocol_whitelist) { > rt->rtsp_hd->protocol_whitelist = > av_strdup(s->protocol_whitelist); > if (!rt->rtsp_hd->protocol_whitelist) { > + av_dict_free(&options); > err = AVERROR(ENOMEM); > goto fail; > } > @@ -1878,6 +1880,7 @@ redirect: > /* POST requests */ > if (ffurl_alloc(&rt->rtsp_hd_out, httpname, AVIO_FLAG_WRITE, > &s->interrupt_callback) < 0 ) { > + av_dict_free(&options); > err = AVERROR(EIO); > goto fail; > } > -- > 2.39.5 (Apple Git-154) > Lgtm > --===============2328028797251686266== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2328028797251686266==--