Re: [FFmpeg-devel] [PATCH] checkasm/h264dsp: Fix stack-buffer-overflow, effective-type violations

[Tristan Matthews via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>]

[-- Attachment #1: Type: message/rfc822, Size: 2702 bytes --]

From: Tristan Matthews <httamt@protonmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] checkasm/h264dsp: Fix stack-buffer-overflow, effective-type violations
Date: Wed, 25 Jun 2025 21:39:16 +0000
Message-ID: <iUgU0TkNbWLQMfIep31TmYmqcEGE4DWMFdck_621kUSsr9aA0xcPOeWwGkpa-OXGC7nmdo_CqfLUqLiwFwGN5Gre3M6inMpU8u4HwChfk7E=@protonmail.com>

On Monday, June 16th, 2025 at 2:22 PM, Andreas Rheinhardt <andreas.rheinhardt@outlook.com> wrote:

> Tristan Matthews via ffmpeg-devel:
> 
> > On Monday, June 16th, 2025 at 6:53 AM, Andreas Rheinhardt andreas.rheinhardt@outlook.com wrote:
> > 
> > > Patch attached.
> > 
> > LGTM, and sorry about that, for future reference did you do anything in particular (instrumentation wise) to catch the stack overflow? I tried make fate on a few different machines and didn't hit that.
> > 
> > Best,
> > Tristan
> 
> 
> I used (Clang) ASAN. Presumably Zhao Zhili (who first reported the stack
> buffer overflow) did so, too.
> 
> - Andreas
> 

It'd be good to merge either this or Zhao Zhili's patch to get checkasm back to being ASAN clean.

Best,
Tristan

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".