From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id BCA7F4BD34 for ; Sat, 21 Jun 2025 17:18:17 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id EBA8168CF41; Sat, 21 Jun 2025 20:18:12 +0300 (EEST) Date: Sat, 21 Jun 2025 19:18:03 +0200 To: FFmpeg development discussions and patches References: <20250613140555.121374-1-martin@martin.st> <87E28D26-5CF3-4230-9B3A-C13055D379DA@martin.st> In-Reply-To: <87E28D26-5CF3-4230-9B3A-C13055D379DA@martin.st> MIME-Version: 1.0 Message-ID: List-Id: FFmpeg development discussions and patches List-Post: From: Alexander Strasser via ffmpeg-devel Precedence: list Cc: Alexander Strasser X-Mailman-Version: 2.1.29 X-BeenThere: ffmpeg-devel@ffmpeg.org List-Subscribe: , List-Unsubscribe: , List-Archive: Reply-To: FFmpeg development discussions and patches List-Help: Subject: Re: [FFmpeg-devel] [PATCH] configure: Make MSVC version grabbing more robust Content-Type: multipart/mixed; boundary="===============3514442390665002778==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============3514442390665002778== Content-Type: message/rfc822 Content-Disposition: inline Return-Path: X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 9D36D68C683 for ; Sat, 21 Jun 2025 20:18:05 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1750526285; x=1751131085; i=eclipse7@gmx.net; bh=z5XemNIhHFXw3UJayZreY1fGdAGHjS3StXwFuJgaiZk=; h=X-UI-Sender-Class:Date:From:To:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=VH3BhgJBu7ZFwgubsUwR8ZMLc5vKQl/JEL5RuxyVICMPPeAEsW2JliXY9h8Khco+ i6tDqTS95nNRKHFr3dcBxwXBzbZ1QKw2oZLxh459BvseQTYaYWf8tGU1VzL5Pas6I 0OwkyKmp5ER9qBdwzIEp011kd4gKnpAqy39MpZHJ1bxttS5O4IaMf6Pq7cStqeQHi 8Gxcv9DSWgSU5iA/GdLp7BozX61MEecy4QKErOm7bjHdehtDjMAEi2vKHPKGgrPOC uq4ZmWv1Fw0WR8OX/rADtcXgT7xpQLvmWmTFGGDWFGk8kgtk9wmJ0Z+pTzZ6MIZtO X4J8S4xp4Ue9PBD+8g== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from metallschleim.local ([91.4.236.20]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M5QFB-1uSCu938Wz-00D367 for ; Sat, 21 Jun 2025 19:18:04 +0200 Date: Sat, 21 Jun 2025 19:18:03 +0200 From: Alexander Strasser To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] configure: Make MSVC version grabbing more robust Message-ID: References: <20250613140555.121374-1-martin@martin.st> <87E28D26-5CF3-4230-9B3A-C13055D379DA@martin.st> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="i4p4cKD5BHaROUR6" Content-Disposition: inline In-Reply-To: <87E28D26-5CF3-4230-9B3A-C13055D379DA@martin.st> X-Provags-ID: V03:K1:53PfzTannFdipLwqbVexDLdwA4tqN8mWJpW7ymy3QoPNP1yQybg hhKlXUmDlwc32+DhxoZ3N8HCVvMpgFtXu8XpOgne8UMNPBP4PNBQSoNtQQe/DYSUduHX+JZ 2QHfdrXqt45GD7Y2B1UPGJl9ot7gCLGNLbt4C735gZzOouNXJrTQmQ7kgBujxHSg0J6YaEL wDqT/kzuBSlHYIthnOb9g== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:lgSLU+KEqO8=;hn97t9AJIm0vLUUxSMdqQ1VkIDW scuscaZSTeBgWj281V4s8xloP2K4DITL4tyx+/OtaDWkyE5kL0qfLl7QzSV7ui0A3zIWFLaqS U09yH2h7dan/t2Ail6XE5XuAlWSKJkfodFU2Nb4wjkRlT8HPO58601N4N9Xzc+aU00FkH6ly9 73P+HmDnM38XSel8ZVnF5NkwS8a4oKhTqWPlowunBnZgSGTkHHQoJ+c6Jqig6d1yA9blx2GFW dFrYbJOZZsveOV1QswhfKftr6TzHFSARjj+0eB85oV2czAYa6e5eE2vZYTGPvC3NvChUSZ04F XUr45YbjeYGyas8cWc019HZ1Epw6fktSeHx0J3xW/FxybMWFc7dvWt01Sf8eML+CZ5Sxq3ica dFY+Ch9ju20uhReVU+m7qusCj4/9cXCsfZaK5Wx+IvktGHeEmP7PxreDE5q4AxQ7K4VeqJeQn XWVq3PHHZU0YWBKXwRzNUa6Vdn2lyfXliDakHmq7fxlX3l4P56MVWNAjIG6cxIJOvJaPmISRB 9JvPiphd1CQB4kmQXQFjBTJyaerXcctdd/ibn4OvTD+vQzeZcPtJKe7/QdyUSadVVS9alD3hx kSdSSOxhF7hgZuefVL6cyILh/bej4yvVme7yjlnECJsTpgJ48RrVR4lx1XYxaQwaRheOV88z5 YtygfxIxVev2mq9jZHHzx8TIsSMLyrznQis8BDrQNrE1vQygMSqXJWgRq3iHjM/VgLUUX1CJR UrmgEfiAEAiAkLKS1LknwTTTCzyCd9Vs8k/INuqJ6Q0UJfInPHDh0r89dyaFoSRtDrWJsfH1d 5F9a9c7R8l4NWGkALlsbjdCbYFLRxzeSpALYPfwOiZEdPvTnLnDCMUf3GKXZ0CHeBLaATbNpt L2E1rEr6GOOUy68h7ThS4WY8QFDxi9OJd3ZEvlDPrvs5ZlYhHBYskMBbdCmoEL5V7EwKAdEPy vkgrxUi+xKfU5UiJlO/z6Zq04Nnw8KCZHjigoOFmGGsl+5+u1leq6Vz8H3N2GeiYJjuEE22Lv CSp4p/F6am4nqPLzC7n6C2ziehH6ANntGOk9poepUIGy/qlk4Tg5uSILe2bwPrdGG6B0n++0o nQbwsjbPNPQcBaB0CRaXfwarzf73E4FAyukwohINlcgF/Tc4B7mwIl/3h+BZslv2/I0CdqYit +dcO92K5IDmbQY5K+/TRlUvHyZp1B/mtN7QL+QBIJgikYQKuncJuAJe3HrE/JgLFAkuEHRmwF AW84gmrrxmmSiUnrLXoAm6BpKPiRR96UcGR4uOTdz7fiMdaRcVRa5l3hoqaOZW0sE4uGrJ78W kpTyJmHck9eMI9QkAPfKsO8CKFYe2DpGM4uJLLlkaab+NFT0Tsmwi04ak9YmEjP7Wr0UBs/WX CO1lg8sA/WUpaNNBcIhS7IY7dxSVpGb/+YcRqRfNOM+pzvTA27yE34i6+q4RP2QDePhdHvj3P 76SweyxPShgppUW1HnuqlFxD/W0ujhYhwrcdxSvCenFnMXmeWzvFE63Xn/TXcy3GpmIfiXq7j 3aYRKO9AIBr0+Q/mjmkcVbd8pWVq76bFqBOeGPGG44MAhgA+iqUDRsU6v4ZlrvYxZDODmdMGh Hl01PLSta43ediLMS3eVOZiSs9kWW4fz65Ng7+L9omAvp0Uu+sEmSifEDQEER4wdfDzV23zYD wFcF9EFdiHr5zg1pJs3dpCR+2AuCo9e6iq9TGS8nc/iSZVI2GLt7Ys2wnFgkc0TLsYbc7xwMp lP217wwoEc5KiUfqrpImSQk3/jL9PTDB/pv9Ro0H7OMzXU2DIcu88JztcaeoRdlwYItb4CYtK QQ45uN+Zl6kaSciIPaVNjxvidZff05234URNGLCnwdt/7rd7WroqWAxcEyqR2AMc/c1W780Lv HHf0qugMLYlknNdmVMTM0D0ZURA8Aceua8QKGMHzl/TvqmihCCWMGlv6gQvmy41VpVt3O0mkJ VFeWb3aawTFw6wa650nXU9X92fC6n9iLriMAzfunMPs0nWkzAppI3Evca3vJQ8YpJudvebs10 vKXXYcDGtf6Nnwnns72XRYz/tyy+FgAXmcBpId1T2yMNxFbjTu5f4uW40x/9qnRT5woa8iM8W 4qfas4ebpEHR3NLjvDKkXsp//ZFGY8vNpMoFLKXwAippS6tLviT7XMCeEGr/SOjmSO8jZM2B2 RBBq8h3S8Hu1hjQxT+DxQLIIhj2lOKdqY8ksx4fFbw6z1UBigHR7jCybjqPNlBJpYwJ0V2j3B E5sAUqKdlfR+EtiP54aKgLi1f3lRrCnWWMyqoEc+lBx6zxnkKJDxv+kUyBRtMi7xo0nqQS6uO /pX/BhTmt2iY+jIGunLMA79BSoiOw02aIb/LtLHmno0k6VdnyWJvTpKONrfXddd/Z5S7Wm3sB CS+R8A5SvdRsW7FzJ5I5pAQQyI8M1/Y7ke5Fy69QDG1YcWvOSAAH3L2U/feJ6USh8j1FNH4jh HMB+1js5Mp29j71Kf2TJvBVafQuhYuOu9tmfSdKkEvtzZbt8FriQ0aHSTOLQsv7i46GTuBcvi hDbUT1b6c822uTXF0mzLnbDGalkAOB6x9Xwl46ioCojS37Cya3NRwmzI4tooI6TvgcW3MDAv+ ZZQyh+igd5Nu6kZe75XgEHQX1qGepYVjvBrKyR7OSC3vLCSXHWpqWk+mD7rCcN7YiuyylOkA+ oZcOvprnXFTKRZaBeF94EaBdHCZHKKvlIDA8k27v/rE5DAPpGMd8YbVaeZPIxLWDOQB6+f3jD 4HFF21N5Nc/8LWn0eIum6PDU/A08McmZORnQQSCs5kV4Dc1+rKv/iureEkqwhneBuBs3b69nY 0eQM6/HHAnjQ+fSkegvnM2sEC8BzIoUAUh1du4So8mwfgnRFRy/VdynQXQJJydcfIkuO38gt7 JGzOvkG/6DrPt2MJF0aQBk6/IinDjQ1eJsAmno09I6dAJYAbYmIxu4MQLEBR3W519slYLAvF+ tMlw8i6to16P1JHjZSWWSaXHk66vznp/V7x7Vn3CygllJ6HrKXDdIhTgu3HPnRdOgDY6nwb+V cVxcieRRycJcIBgrSJ3g0vcCDYxbMYHNuW5Ke0yvB56QZWXryCFnDXDc4uV0vvn6fI7vo+UTJ 5ecU4hOgZsFTnO0QUFao7qvhJo7apkCXKVRljA/6vMpUhOeENA3zG5v4zc0hc2y1XKrHYURwY /92wiZEAtljU7ClFLnBHqECTw5TA2YoK6lUv6QAvEp+hc3TN2m4u3Ib82w/76Y+y9ZMn/7DMb 1zVjijpw9KMvHTCty8oFbkp/maaVmITBR3KjMDVM+KehyfVCsjlkUl/Vd0TW0s4NjUOFOE/7+ HBUe7MB9N/9Tnuo/oEIMdyh4PXGdKWwMrkpgaJ6b9nsItTNwVo= --i4p4cKD5BHaROUR6 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Martin! On 2025-06-21 13:37 +0300, Martin Storsj=C3=B6 wrote: > > On 21. Jun 2025, at 12.20, Alexander Strasser via ffmpeg-devel wrote: > >=20 > >=20 > > On 2025-06-21 00:03 +0200, Kacper Michajlow wrote: > >> On Fri, 20 Jun 2025 at 22:26, Hendrik Leppkes > >> wrote: > >>>=20 > >>> On Fri, Jun 20, 2025 at 9:25=E2=80=AFPM Timo Rothenpieler wrote: > >>>>=20 > >>>> Likely this patch broke multiple fate runners in a silent way. > >>>> On mine, configure simply never returns, and just sits there > >>>> indefinitely, with no CPU usage or any activity whatsoever. > >>>>=20 > >>>> =EF=BB=BFnevcairiel confirmed seeing the same behaviour on IRC. > >>>>=20 > >>>> The msys+clang builds from within the same environment work fine. > >>>>=20 > >>>>=20 > >>>> Didn't verify completely if it's caused by this patch, but nothing = else > >>>> happened with configure since the last successful run. > >>>=20 > >>> I did some digging, and it happens when probe_cc probes link.exe > >>>=20 > >>> link.exe has an interactive help output (its paginated) - previously > >>> piping stdout disabled the pagination automatically - but redirectin= g > >>> it to devnull does not, and it gets stuck waiting for input. > >>> Additionally, link.exe outputs the ident on stdout, so there is no > >>> result on stderr (not super bad, as LD_IDENT is never used - yet) > >>=20 > >> Instead of redirecting to devnull, we could use the same condition as > >> in if. We already look for specific ident line, so no need to head. > >> _ident=3D$($_cc -nologo- 2>&1 | grep ^Microsoft | tr -d '\r') > >> should work, no? I would be happy to see a better solution, though. > >=20 > > I think making sure to only use the first line that starts with > > Microsoft is more robust; there could be (in the future) more lines > > that start with Microsoft. > >=20 > >> btw. running cl.exe 3 times to just get its name is interesting :) > >=20 > > Yes, so that as well. Could be optimized, but is probably not so > > relevant in total. > >=20 > > I propose the attached patch. > >=20 > >=20 > > Alexander > > <0001-configure-Fix-a-regression-when-probing-link.exe.patch> >=20 > Thanks, this patch looks good to me, feel free to push! (And I can push = it later today if nobody else does it before that.) >=20 > If you want to, one can also extend the commit message further to say mo= re explicitly, that 45a30e03613a3c63d74a40f7ac86ce28dce14ff8 caused config= ure to hang in some configurations, which this fixes. I have attached an updated version. Hope you like the commit message better. I can push it tomorrow or you can do earlier. Thanks, Alexander --i4p4cKD5BHaROUR6 Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename=0001-v2-configure-Fix-a-regression-when-probing-link.exe.patch Content-Transfer-Encoding: quoted-printable =46rom d71f2bd07a9a723158fb1ec59ec7398fe7aee577 Mon Sep 17 00:00:00 2001 From: Alexander Strasser Date: Sat, 21 Jun 2025 11:13:22 +0200 Subject: [PATCH] configure: Fix a regression when probing link.exe The version ident is printed on stdout for link.exe and redirecting stdout to /dev/null will cause the output of link.exe to be paged. This caused configure to hang for some configurations and by extension some FATE clients. You might want to check if you run affected configurations automated in FATE clients or similar setups. Fixes: 45a30e03613a3c63d74a40f7ac86ce28dce14ff8 =2D-- configure | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 708ecd9025..ce027d3845 100755 =2D-- a/configure +++ b/configure @@ -5130,10 +5130,9 @@ probe_cc(){ elif $_cc -nologo- 2>&1 | grep -q ^Microsoft || { $_cc -v 2>&1 | grep= -q clang && $_cc -? > /dev/null 2>&1; }; then _type=3Dmsvc if $_cc -nologo- 2>&1 | grep -q ^Microsoft; then - # The version number is printed on the first line on stderr, = stdout - # gets the usage instructions. Only include stderr, to avoid - # potential ordering race conditions. - _ident=3D$($_cc 2>&1 >/dev/null | head -n1 | tr -d '\r') + # Depending on the tool (cl.exe or link.exe), the version num= ber + # is printed on the first line of stderr or stdout + _ident=3D$($_cc 2>&1 | grep ^Microsoft | head -n1 | tr -d '\r= ') else _ident=3D$($_cc --version 2>/dev/null | head -n1 | tr -d '\r'= ) fi =2D-=20 --i4p4cKD5BHaROUR6-- --===============3514442390665002778== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============3514442390665002778==--