From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id AFF30401DE for ; Tue, 18 Feb 2025 01:00:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2AF3868BF7C; Tue, 18 Feb 2025 03:00:28 +0200 (EET) Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C206268BB7C for ; Tue, 18 Feb 2025 03:00:21 +0200 (EET) Received: from localhost (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id 6091EEB6B0 for ; Tue, 18 Feb 2025 02:01:17 +0100 (CET) X-Virus-Scanned: amavisd-new at passwd.hu Received: from iq.passwd.hu ([127.0.0.1]) by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yB43XEeWy8d9 for ; Tue, 18 Feb 2025 02:01:15 +0100 (CET) Received: from iq (iq [217.27.212.140]) by iq.passwd.hu (Postfix) with ESMTPS id 029E9EB6AF for ; Tue, 18 Feb 2025 02:01:14 +0100 (CET) Date: Tue, 18 Feb 2025 02:01:14 +0100 (CET) From: Marton Balint To: FFmpeg development discussions and patches In-Reply-To: <20250217132522.829177-2-manuel.lauss@gmail.com> Message-ID: References: <20250217132522.829177-1-manuel.lauss@gmail.com> <20250217132522.829177-2-manuel.lauss@gmail.com> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v3 2/3] avcodec/sanm: fobj left/top are signed X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 17 Feb 2025, Manuel Lauss wrote: > The left and top parameters of an FOBJ are signed values. > > Signed-off-by: Manuel Lauss > --- > v3: change the bytestream accessor to signed too get_xxxu means "unchecked" here (as in not checking for buffer overread), not unsigned. Bytestream API always returns unsigned. So v2 of the patch is fine as is. Regards, Marton > v2: no changes > > libavcodec/sanm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/sanm.c b/libavcodec/sanm.c > index a4f0a28c7c..5ea742c997 100644 > --- a/libavcodec/sanm.c > +++ b/libavcodec/sanm.c > @@ -1238,8 +1238,8 @@ static int old_codec48(SANMVideoContext *ctx, int width, int height) > static int process_frame_obj(SANMVideoContext *ctx) > { > uint16_t codec = bytestream2_get_le16u(&ctx->gb); > - uint16_t left = bytestream2_get_le16u(&ctx->gb); > - uint16_t top = bytestream2_get_le16u(&ctx->gb); > + int16_t left = bytestream2_get_le16(&ctx->gb); > + int16_t top = bytestream2_get_le16(&ctx->gb); > uint16_t w = bytestream2_get_le16u(&ctx->gb); > uint16_t h = bytestream2_get_le16u(&ctx->gb); > > -- > 2.48.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".