Re: [FFmpeg-devel] [PATCH v3 2/3] avcodec/sanm: fobj left/top are signed

[Marton Balint <cus@passwd.hu>]

On Mon, 17 Feb 2025, Manuel Lauss wrote:

> The left and top parameters of an FOBJ are signed values.
>
> Signed-off-by: Manuel Lauss <manuel.lauss@gmail.com>
> ---
> v3: change the bytestream accessor to signed too

get_xxxu means "unchecked" here (as in not checking for buffer overread), 
not unsigned. Bytestream API always returns unsigned. So v2 of the patch 
is fine as is.

Regards,
Marton

> v2: no changes
>
> libavcodec/sanm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavcodec/sanm.c b/libavcodec/sanm.c
> index a4f0a28c7c..5ea742c997 100644
> --- a/libavcodec/sanm.c
> +++ b/libavcodec/sanm.c
> @@ -1238,8 +1238,8 @@ static int old_codec48(SANMVideoContext *ctx, int width, int height)
> static int process_frame_obj(SANMVideoContext *ctx)
> {
>     uint16_t codec = bytestream2_get_le16u(&ctx->gb);
> -    uint16_t left  = bytestream2_get_le16u(&ctx->gb);
> -    uint16_t top   = bytestream2_get_le16u(&ctx->gb);
> +    int16_t  left  = bytestream2_get_le16(&ctx->gb);
> +    int16_t  top   = bytestream2_get_le16(&ctx->gb);
>     uint16_t w     = bytestream2_get_le16u(&ctx->gb);
>     uint16_t h     = bytestream2_get_le16u(&ctx->gb);
>
> -- 
> 2.48.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".