From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 13CD74649D for ; Fri, 19 May 2023 12:11:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id ADC5268C18F; Fri, 19 May 2023 15:11:09 +0300 (EEST) Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com [209.85.219.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 31CEA68BB8E for ; Fri, 19 May 2023 15:11:03 +0300 (EEST) Received: by mail-yb1-f171.google.com with SMTP id 3f1490d57ef6-ba81e7269a2so464558276.1 for ; Fri, 19 May 2023 05:11:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684498261; x=1687090261; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=XHEWF6vlZ7xWXwvlgsbBMJLJIDzlvp1HfIYUhIOQt+0=; b=WUnYXYC/sa8XziaOIi4ENc9rNMa1IjHoY1rBZfCQ2OLik+OX9D6emzhiqDnEEUlcNd BWQGY7yJ+2L8uq2OEFt2rKU3yvogh5UtQh9u+yWbvCmFtOsxHL4jVSr0lYchh5DEAbhI E9ZC2U55MZ0Tn9QJpaiaH7DfNpVtWgNoo/aznWTVn1mZL3OafIH7QUEXvA2792ke6HjJ 4465QMp8K5Sudfrrz6UzOs3+DJ93FQHHo/S+c31CeAvoVo+QiK4aJ6R4DJ6QzFHEuiPM PaViMZPY2WkHtihvD8Y3DJZzzyPdpidZuEdMMjcZ1pmVyUmAid9NCua6XvMzqkDva+Ki rfmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684498261; x=1687090261; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XHEWF6vlZ7xWXwvlgsbBMJLJIDzlvp1HfIYUhIOQt+0=; b=RX59vFZNlVSSOhr+l0wk7/dRccz9yiTk9IrOF0ygI8xNmrQF5gh0B1FndMMx2mZ3Jc 4jiWMXFZ4nvN4RIVNH85UoQXm5PoUJQriF/MsqKC2Jb+zr+vSnkTNQFQY+9qW8mj9ux8 fJCZeSFDBv1ARUCNWMHFNBvZY5Mrctc/X8CGIGJ3RoOa8BfODFiPA9u9E6mZIooozpRR NjG7bZBR3S/bKePszTh6Kh5TO5M9ZYJFTyrIdS06Cd8j1D7JWcysqYhGDj3JKUv8E472 CrNr3Zod3WqfYLprRvZFs+s6XU/MiUsBzzaqAJGWJu4hfGi4aEsa5g6V3MYBcRixTTmz O52Q== X-Gm-Message-State: AC+VfDzhEKLNz+4mGO/NiUF9TzSwj26l7d1hHw3nM565viXKcrYMWnoy Ml41E/DuQjsvNNXpnYdvqY9SKtHUlFQ= X-Google-Smtp-Source: ACHHUZ4CraB9pTV7EHzRR6iFU1hkHPqYe2K9VtQbGLVEBhymTjxHNlZ3AaYHBPW0cY5CjgqsoD9qZA== X-Received: by 2002:a25:aa21:0:b0:ba7:918d:bf3f with SMTP id s30-20020a25aa21000000b00ba7918dbf3fmr1828609ybi.1.1684498261476; Fri, 19 May 2023 05:11:01 -0700 (PDT) Received: from [192.168.1.35] (c-98-224-219-15.hsd1.mi.comcast.net. [98.224.219.15]) by smtp.gmail.com with ESMTPSA id d203-20020a25e6d4000000b00ba63c25add6sm1000826ybh.38.2023.05.19.05.11.00 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 May 2023 05:11:01 -0700 (PDT) Message-ID: Date: Fri, 19 May 2023 08:11:00 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US-large From: Leo Izen In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 55/97] Vulkan patchset part 2 - hwcontext rewrite and filtering X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 4/24/23 11:56, Lynne wrote: > This is part two of the vulkan patchset, which contains all the > hwcontext and vulkan.c rewrites, and filtering changes. > > 55 patches attached. > > [PATCH 21/97] lavu: add 12-bit 2-plane 422 and 444 pixel formats iirc new pixel formats need an APIChanges entry, a lavu micro bump, or both. I'm not really sure what the policy is but I remember being told something like that when I added a NE macro a few months ago. [various] > static int vulkan_device_create_internal(AVHWDeviceContext *ctx, > ... > p->device_features_1_3.foo = dev_features_1_3.foo; There's a lot of these in various patches, why do these need to be done manually? [PATCH 26/97] hwcontext_vulkan: support threadsafe queue and frame > p->qf_mutex = av_mallocz(qf_num*sizeof(*p->qf_mutex)); av_calloc + for (int i = 0; i < qf_num; i++) { + p->qf_mutex[i] = av_mallocz(qf[i].queueCount*sizeof(**p->qf_mutex)); + if (!p->qf_mutex[i]) + return AVERROR(ENOMEM); + for (int j = 0; j < qf[i].queueCount; j++) + pthread_mutex_init(&p->qf_mutex[i][j], NULL); + } If the allocation fails for i > 0, you end up with some initialized mutexes, is this going to be an issue ever? @@ -1732,9 +1778,6 @@ static void vulkan_free_internal(AVVkFrame *f) { AVVkFrameInternal *internal = f->internal; - if (!internal) - return; - #if CONFIG_CUDA if (internal->cuda_fc_ref) { AVHWFramesContext *cuda_fc = (AVHWFramesContext *)internal->cuda_fc_ref->data; What happens if (!internal) and #defined(CONFIG_CUDA), do we just segfault? - Leo Izen _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".