Re: [FFmpeg-devel] [PATCH] avcodec/ffv1dec: set the FF_CODEC_CAP_SKIP_FRAME_FILL_PARAM capability

From: Lynne <dev@lynne.ee>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/ffv1dec: set the FF_CODEC_CAP_SKIP_FRAME_FILL_PARAM capability
Date: Sat, 15 Mar 2025 20:21:25 +0100
Message-ID: <fee3d09e-0340-465b-b3df-b77685bf2607@lynne.ee> (raw)
In-Reply-To: <20250315191003.4226-1-jamrial@gmail.com>

[-- Attachment #1.1.1.1: Type: text/plain, Size: 1255 bytes --]

On 15/03/2025 20:10, James Almer wrote:
> Will prevent decoding frame data during probing.
> 
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>   libavcodec/ffv1dec.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/libavcodec/ffv1dec.c b/libavcodec/ffv1dec.c
> index b731f11297..998b981a33 100644
> --- a/libavcodec/ffv1dec.c
> +++ b/libavcodec/ffv1dec.c
> @@ -697,6 +697,9 @@ static int decode_frame(AVCodecContext *avctx, AVFrame *rframe,
>       if (ret < 0)
>           return ret;
>   
> +    if (avctx->skip_frame >= AVDISCARD_ALL)
> +        return avpkt->size;
> +
>       ret = ff_progress_frame_get_buffer(avctx, &f->picture,
>                                          AV_GET_BUFFER_FLAG_REF);
>       if (ret < 0)
> @@ -821,5 +824,6 @@ const FFCodec ff_ffv1_decoder = {
>       .p.capabilities = AV_CODEC_CAP_DR1 |
>                         AV_CODEC_CAP_FRAME_THREADS | AV_CODEC_CAP_SLICE_THREADS,
>       .caps_internal  = FF_CODEC_CAP_INIT_CLEANUP |
> +                      FF_CODEC_CAP_SKIP_FRAME_FILL_PARAM |
>                         FF_CODEC_CAP_USES_PROGRESSFRAMES,
>   };

LGTM, been running this locally for days now. Speeds up opening high 
resolution files by seconds.
Thanks.

[-- Attachment #1.1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 637 bytes --]

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".