From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 61715411F9 for ; Sun, 24 Apr 2022 22:13:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C114168B281; Mon, 25 Apr 2022 01:13:01 +0300 (EEST) Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com [209.85.167.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DE29968AD12 for ; Mon, 25 Apr 2022 01:12:55 +0300 (EEST) Received: by mail-oi1-f181.google.com with SMTP id r8so15280411oib.5 for ; Sun, 24 Apr 2022 15:12:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=22qi4Jr1HPptxFPD7FYsfpY3u5woXp3YoRX5hmH6pYI=; b=cMC+UDV2Gtv2giGq1w6vkPP2weUY8S8n/I8ydVCZe2hpMapxC3SMCol0UNSVrsheqt Q2TjXmITAazl43SG2IHoTRxiDyJWahi+kVQHnuZ1zN+4skbqhndPx60Z4Xx66HG3eokH XDA9Ui3Rowrh9CyKDwL4z4/hE8YHdMWcY6sqASvyN1vrfWLTzrEr8xuQHdjVl63/MkrO YfGD+pldZk/5Mf+GBmPvluitBL2iZA+FS34xllAxOGbuQxorIk/2rJQOdTvDFWmFZdJZ kaXYj7R3xYmNLfx8IpCaNAfIjDomxlKHP9eVMueM1X1Oqw7Qq5BNVA6umOUOnmbagvax Vl5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=22qi4Jr1HPptxFPD7FYsfpY3u5woXp3YoRX5hmH6pYI=; b=lSVawdXo7Aijrb0irkZYkQAXweEXYYh7p4ooureFjI+hN3l21R42Xr/LeTofbFfkV7 Mz/+EBsLZebxxz1oyObI1rUKRPKJ1n9PC9ycCFWNGkKgjmYdv2Po1hY4KElDeDy3gkDL 9vj9F7Acv9vMbVqM07kWqb+Dtoeo2AKU5My9YAcZTeBEUyssE1Nr2aY2N+IXq2pPH4I5 eAjALwXTw66I4Y9AEY8a//eYp0uuv7HHPDn8tB3nx+Roy3giRQfR7IjB0QdpUfCxyBRM kGloM3zDrsrMNekJLue6DN+vDI9O5zV3knqD5YIsjwfvkCfBtQr4PJwebFYkiyE4YGTy ouWw== X-Gm-Message-State: AOAM530jyQ2nXn4FL3wGZWou3pO9NtbH90sCSiW2fzrsgsLq33DVgdpc DA6JWXiu4Q9ZEGR/jlFKc5o2BS/huWE= X-Google-Smtp-Source: ABdhPJxlpHHP0uVS9ikA06IgvA3vr8hnU6gDoBPCK3p5I6hIl+KGDb6MbuWKxMvrRNDHj5iAyL+nsQ== X-Received: by 2002:aca:aad2:0:b0:324:ed34:aad4 with SMTP id t201-20020acaaad2000000b00324ed34aad4mr5677721oie.158.1650838374179; Sun, 24 Apr 2022 15:12:54 -0700 (PDT) Received: from [192.168.0.13] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id e22-20020a9d5616000000b005ceb68be2f6sm3154296oti.63.2022.04.24.15.12.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 24 Apr 2022 15:12:53 -0700 (PDT) Message-ID: Date: Sun, 24 Apr 2022 19:12:53 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20211231052309.42415-1-kode54@gmail.com> From: James Almer In-Reply-To: <20211231052309.42415-1-kode54@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/audiotoolboxdec: Properly fill out_format X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 12/31/2021 2:23 AM, Christopher Snowhill wrote: > Monterey needs mBytesPerFrame and mBytesPerPacket to be set, and I'm > surprised this didn't break any previous system versions. > > Fixes bug #9564: Cannot decode xHE-AAC with audiotoolbox (aac_at) on > Mac OS Monterey. Fixes likely bug that none of the AudioToolbox > decoders work on Monterey. > > Signed-off-by: Christopher Snowhill > --- > libavcodec/audiotoolboxdec.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/libavcodec/audiotoolboxdec.c b/libavcodec/audiotoolboxdec.c > index 9939fef218..4abcb63a03 100644 > --- a/libavcodec/audiotoolboxdec.c > +++ b/libavcodec/audiotoolboxdec.c > @@ -370,6 +370,11 @@ static av_cold int ffat_create_decoder(AVCodecContext *avctx, > avctx->sample_rate = out_format.mSampleRate = in_format.mSampleRate; > avctx->channels = out_format.mChannelsPerFrame = in_format.mChannelsPerFrame; > > + out_format.mBytesPerFrame = > + out_format.mChannelsPerFrame * (out_format.mBitsPerChannel / 8); > + out_format.mBytesPerPacket = > + out_format.mBytesPerFrame * out_format.mFramesPerPacket; > + > if (avctx->codec_id == AV_CODEC_ID_ADPCM_IMA_QT) > in_format.mFramesPerPacket = 64; Applied. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".