Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Timo Rothenpieler <timo@rothenpieler.org>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] cuda: add support for yuv420p10
Date: Fri, 25 Apr 2025 19:16:50 +0200
Message-ID: <fe2f61a0-c18e-4737-bb4b-98e2c8bdfc4b@rothenpieler.org> (raw)
In-Reply-To: <20250425110303.100424-1-dev@lynne.ee>

On 25.04.2025 13:02, Lynne wrote:
> This patch adds support for accepting yuv420p10 in encoders and cuda.
> ---
>   libavcodec/nvenc.c         | 2 ++
>   libavutil/hwcontext_cuda.c | 7 +++++--
>   2 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c
> index 41a4dc55f4..ccf8cc6d39 100644
> --- a/libavcodec/nvenc.c
> +++ b/libavcodec/nvenc.c
> @@ -57,6 +57,7 @@
>   
>   const enum AVPixelFormat ff_nvenc_pix_fmts[] = {
>       AV_PIX_FMT_YUV420P,
> +    AV_PIX_FMT_YUV420P10,
>       AV_PIX_FMT_NV12,
>       AV_PIX_FMT_P010,
>       AV_PIX_FMT_YUV444P,
> @@ -99,6 +100,7 @@ const AVCodecHWConfigInternal *const ff_nvenc_hw_configs[] = {
>                               pix_fmt == AV_PIX_FMT_YUV444P16 || \
>                               pix_fmt == AV_PIX_FMT_X2RGB10   || \
>                               pix_fmt == AV_PIX_FMT_X2BGR10   || \
> +                            pix_fmt == AV_PIX_FMT_YUV420P10 || \
>                               pix_fmt == AV_PIX_FMT_GBRP16)
>   
>   #define IS_RGB(pix_fmt)    (pix_fmt == AV_PIX_FMT_0RGB32  || \

Appears to be missing the entry in nvenc_map_buffer_format().

> diff --git a/libavutil/hwcontext_cuda.c b/libavutil/hwcontext_cuda.c
> index 5721612225..495d3687c2 100644
> --- a/libavutil/hwcontext_cuda.c
> +++ b/libavutil/hwcontext_cuda.c
> @@ -44,6 +44,7 @@ static const enum AVPixelFormat supported_formats[] = {
>       AV_PIX_FMT_NV12,
>       AV_PIX_FMT_NV16,
>       AV_PIX_FMT_YUV420P,
> +    AV_PIX_FMT_YUV420P10,
>       AV_PIX_FMT_YUVA420P,
>       AV_PIX_FMT_YUV444P,
>       AV_PIX_FMT_P010,
> @@ -162,7 +163,8 @@ static int cuda_frames_init(AVHWFramesContext *ctx)
>       // YUV420P is a special case.
>       // Since nvenc expects the U/V planes to have half the linesize of the Y plane
>       // alignment has to be doubled to ensure the U/V planes still end up aligned.
> -    if (ctx->sw_format == AV_PIX_FMT_YUV420P)
> +    if (ctx->sw_format == AV_PIX_FMT_YUV420P ||
> +        ctx->sw_format == AV_PIX_FMT_YUV420P10)
>           priv->tex_alignment *= 2;
>   
>       av_pix_fmt_get_chroma_sub_sample(ctx->sw_format, &priv->shift_width, &priv->shift_height);
> @@ -197,7 +199,8 @@ static int cuda_get_buffer(AVHWFramesContext *ctx, AVFrame *frame)
>   
>       // YUV420P is a special case.
>       // Nvenc expects the U/V planes in swapped order from how ffmpeg expects them, also chroma is half-aligned
> -    if (ctx->sw_format == AV_PIX_FMT_YUV420P) {
> +    if (ctx->sw_format == AV_PIX_FMT_YUV420P ||
> +        ctx->sw_format == AV_PIX_FMT_YUV420P10) {
>           frame->linesize[1] = frame->linesize[2] = frame->linesize[0] / 2;
>           frame->data[2]     = frame->data[1];
>           frame->data[1]     = frame->data[2] + frame->linesize[2] * (ctx->height / 2);

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2025-04-25 17:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-25 11:02 Lynne
2025-04-25 17:16 ` Timo Rothenpieler [this message]
2025-04-25 18:09   ` Diego de Souza via ffmpeg-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe2f61a0-c18e-4737-bb4b-98e2c8bdfc4b@rothenpieler.org \
    --to=timo@rothenpieler.org \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git