From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 80C794228C for ; Tue, 31 May 2022 08:59:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2F9FD68B632; Tue, 31 May 2022 11:59:02 +0300 (EEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4267668B5C0 for ; Tue, 31 May 2022 11:58:55 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653987540; x=1685523540; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=c8dygA0PiMdVFT3NAH7swnTiymBXf7YqCZ4IJ8b07cc=; b=bjsMyfRjLNGbV0IbkpkE3nGXqOYm34sbaxB0KCrHgLhZQLlOgzRiLf5T J6NVO8jIxvg4cy/d6h1l71tFGPKYh6CLxWiBUwsdiI6vAnadwRsy7/oBd LF5eQKADsZ2LES/F8fisz1wbxKk3ht1j49rK+R/FYlKcr6qPsPc9adzA7 1imim9pzs4Q5ZRrqIiED3skUp4ZJzk8Pst4CJwuvorNTHF7eR9tY7cEmx npNx0ylpesNVWHiYcWipJdW0E1VkU3BRCx2wk9xMQeoM1igagY+yvnDjE rWXmKD+LD9CQ7QpfYYBtxnW/rjV5JTjsg6YQ3ccWMgzfhV1EiDnyk8Up0 Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10363"; a="273998813" X-IronPort-AV: E=Sophos;i="5.91,264,1647327600"; d="scan'208";a="273998813" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 May 2022 01:58:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,264,1647327600"; d="scan'208";a="529491162" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga003.jf.intel.com with ESMTP; 31 May 2022 01:58:40 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 31 May 2022 01:58:39 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 31 May 2022 01:58:39 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.172) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 31 May 2022 01:58:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m8DXiMfPUDsHsXLV7zp/eVAKg40WgPDLpetoKrxbwJWfJZWz0wtZpbyylEBlFA71eWxCSj7jsuX7RPuTRPkw9cOU3Ud0gjhpE+xYxv84bP3xzMQxwjv6iQjmDA6xekujMo6cFH3ycK9/u+Y2A251TP2ryYtmZyqfT6udRkUlYDQIXsytJmi6qxdzuqcPusbcTY0svpsLKYKUD1qRT9OjHkxE9LXGPwuEnHK8eoQvkuNK7SX7LajQj62NJPMmGwitoeFTWCJRHOrEZZgMDy6fdtggOmv0FEPAHbtx0nVaJB1f7Y2SDo5mHMg3lbd0q2wudSqWarFZ5bz+GkYLQfB7Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c8dygA0PiMdVFT3NAH7swnTiymBXf7YqCZ4IJ8b07cc=; b=ln+C1r7RcFmBWWZfZ4+FHONMe2L/mBsQfEhznA5B8meANQd/KdKcH2qrAxzZ4zUsL7MPxOiLbf8FARZ1FF0cwfoUB8mobaWRSsZlhLjxB+yi+QiXQerpT/KSuPK5WfSkghldVBtbt3THe3QBKa51CnOXT5Cxu6gM89rv8Q7vYyJvqSIlFVtqC2/gK+GrIwGRLXuPx77HxH15EzU13LvL8Dxj6wCsRFpHUBdZk0wJI4QfR6OKAsK4mjdFKKNk9R2Tr1JBYiNxmPGZxiN1gL6JwhTaby3lt1o/irERCmHzlGfRcdMYIH4P8rGFEPtW8ddIeiJtjQGUbfD6/wSOZVao0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by BN8PR11MB3652.namprd11.prod.outlook.com (2603:10b6:408:87::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Tue, 31 May 2022 08:58:37 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::2d06:ec38:937a:da73]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::2d06:ec38:937a:da73%6]) with mapi id 15.20.5293.019; Tue, 31 May 2022 08:58:37 +0000 From: "Xiang, Haihao" To: "anton@khirnov.net" , "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v7 05/10] qsv: build audio related code when MFX_VERSION < 2.0 Thread-Index: AQHYNSBkBvoiSbR4nEyekphDyYl7/6zhXE4AgAEI5wCAJpWKgIAAnd8AgAAPGICAABwZgIAABmaAgC9kwQA= Date: Tue, 31 May 2022 08:58:37 +0000 Message-ID: References: <20220311081630.21927-1-haihao.xiang@intel.com> <20220311081630.21927-6-haihao.xiang@intel.com> <164915940053.21047.6940981970361137655@lain.red.khirnov.net> <1d8c77d974f4efc794b02362bc21d557025abad8.camel@intel.com> <99d97f51de78fdbe99a309272be81cce2efafd16.camel@intel.com> In-Reply-To: Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: aed886a2-2580-484d-8a75-08da42e3c02b x-ms-traffictypediagnostic: BN8PR11MB3652:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: RErvoCW22uJaI+w1SbUTL1m2VTqI5w9ZPKXLiNLxXN2+P3/ksxCTnR1e2WHQ/DaxkXsOorOwt9rppWQkP5ZDPVUBeT/p0A0pByhhfEWNOTOpMM4j3Ym87YZmTj5E6Us1M66uJz+JQ+ldDUzo1GSUyy2ojkyZ6QgIjDwj9BUWoh47K7Lnqab0Jp8NryL+/oV2MwBvDUf74YhTcwG6S2vJbFavONqklEVx5U9EMXM999RYWzmBLDrkbRafWEAFbf3f8WF0m+1f7+RHl30xSuAB4JCX6wsaJrDKNdYBbibp+pYJGplVWmBWXEn1/vy9Jc4RIdyOAM/EaYTRDP190bMxvK3BU4ndoyq+cEvlicrN9EuCmmBlZkH7VNiBnV5TCYK9bHo2x81ijGP7iFcQI7T/iwhCQTVbH/vqHj2YDXWfkZqL/3sPdA7Z5TFA7rZ9UcV85JxzVRlioHN+wDEEZMljEFpNtPWhKxq6+2XC7REgMQrhFpZWU6347LfAAdPdJDF7lP5QWMXl57zxgBzhAodE4Ghf3/V8ive1elMUSYwvPd18r5OyYBD+//XTC4yhJZDF8DpBA0m2lCYqNc+r+cuEql2kADfr4IaBaxY2taxV1YY880C6Yl7sRqiIH0N3EVg529o8oQVDVDMlwgKhW74j2qwq+wwQJTYRzpkLfhkwY6mEZKEON7OPZRkFPvXopsELOZt4CvxJt4qWd1enJpPSd1Lv/tzn4u8RRfa+q+q5j2RI/uu4ITUKQKsPrVWPL7V0QRzkWaCIPATYCc4uV8AcqHZGCfWq58aQ7ztpAGfdDz8k06ujrsTEn/qjyqBT8mfv5ph0cqOywo/+Y6y5UR2PPN5BxlI3z7fd5RVHPDFunxU= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(8676002)(2906002)(110136005)(2616005)(26005)(53546011)(6512007)(6506007)(316002)(38070700005)(966005)(508600001)(6486002)(82960400001)(71200400001)(122000001)(86362001)(186003)(38100700002)(83380400001)(36756003)(8936002)(64756008)(91956017)(76116006)(66476007)(66946007)(66446008)(5660300002)(66556008)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?b2VVWnV0RHgzTVpQazZ3NkJCV1JBZDlmbE1nV25nbEFVd2xQUXRLbTJCRnVs?= =?utf-8?B?eXNHZG5WaFgvQ2llSEhzdTVWQkVxeUdEMTVJQmRadWU3NFFzNUFqaVBwWExS?= =?utf-8?B?MTZ5dXJDbkRrcEd2Q2ZxZFE1T3FSQlVUM0tVcTVlaFlmNDJVdk9CNmY0dFc5?= =?utf-8?B?V2hDUHQ0SEY3dlBuM2VFZWJHbmlNa0dHUHhFa3FQNEhNbmlRU0FnREkzV1Ja?= =?utf-8?B?MEI3djFHRkZGSitPc0NONC9BWGJXanRBUDZZTUo0OWozNlNkTitSaHVqeXMy?= =?utf-8?B?MWdQaWRWK1c2dDJaWEtrbWhDMWJRMGxXMlVpM3h3eDUzeGZXWk9uQnlycG9R?= =?utf-8?B?N1FaRmhKd2ZEQVJnSkxscnRhV2pteXdzQ0ovS0xJSDRpUEc2cWNUMGNjcjM2?= =?utf-8?B?WTlNaHd6VFp4WGFPR0x4cGJxd2ZReThaajVrRnF1dFBhVmh5QnJtaHltY3lC?= =?utf-8?B?RVVDelJHVTBsditUeG54cHhQbVRFektDTUlJQUcxQ05GczFoaU1TekFidXlU?= =?utf-8?B?M1YrWjVpdXVKRzNVWmVDdmNnaytjeDZQL3RGYzVZYVN6bGdtMElLbnIzZ0RV?= =?utf-8?B?Q0V0eUFrTDJ6M3ExTHROSjlFVFVhMGUzbWFWQXpFaG9BNXpOUDkwMnhnWTVj?= =?utf-8?B?WWUzbkUxdDdqZzFRWXgzejdIZTFnUkhxZEhrV2JSZDJMWDRySzB6eVR4VFlW?= =?utf-8?B?cmdRUmxwZ0RrUnMyd21IREFrWVIrNlArQ0owMFkyaEJrVUtDZXN3ODhiWWJw?= =?utf-8?B?L1JTRnNEaEw0OEhGVlhGS3h5MEZSL0lvWnRPUFY1dDlKZUw5MFFDQnRMWVoz?= =?utf-8?B?b1pqRGo1NnhlRlZqM1hjZEorQ1BEZmNTajlwdnRGa0hubW12dHRGZ2htZSs5?= =?utf-8?B?RHNzelJZVGNBVVNKUnBCVDh6dGVDdWdlK2FueHJYQ0N4T1JlUlVCYUZtYmVs?= =?utf-8?B?dlVmWWRIbmJYcTVsR2xKcCtYUkwrQThuY2FWMDBoeWpCYkM1U1loOVVlUWJ3?= =?utf-8?B?aXRLUkc4VmlUcWxVdVE4MTArNFd4NDRSSFFQUTdCUVpzYXN1WWNkZjJHTFpv?= =?utf-8?B?bFplY0ZJeUtkcHpsSzhBNDMyOWcrMXJ1TmZSVXRQcXBReEFEQXdsL3pSOVo0?= =?utf-8?B?TWtYMjdqcTJIeDVEV244VS82NDlLdGlvd3FrZCtIeVUwM3ZSVmlPRTY1ZEt5?= =?utf-8?B?TG0xSmpXRHlObEUvSVEyWmE4aEFhaWIzYitIR2VRaktMaVpEdTJSMHozdlo4?= =?utf-8?B?dm93QzY2WjVJMGd1NVY5UTZDZzRwemEveHZ4QzhhRVdEcklkTDZPT3M2ZnhW?= =?utf-8?B?am9ZODk0dXlaVXFoalBsSzBwcDYrZGZGY3hYQ3NTejRqZm5qWG5BazdRcnh1?= =?utf-8?B?OHVJUU15alNadUIxYjl6VHVTTmRXWGRrOGo5RzFPNHlJdXkwOUtoVFhnWjVj?= =?utf-8?B?aXoyMmZOQUZ2SlRrNXcwN3pSaDk0UVNTcXlKTVVoYzBQdHFrOXU1VEx0cXRX?= =?utf-8?B?WWxPSDRRZHJxT2N5emF1OHFGcXhaVWhWYmlXcm5wbFNDNlpHNUtxMXJtMmlk?= =?utf-8?B?TVNYdWJubVVCZ3BnVXl0Znp2eWlPUDU5NVc5N0NxRlYxQmZ6T1BwbG9mZzZW?= =?utf-8?B?VlVDblQ0SllneE8xR3EzV3RqcjZlaWpmcVg4ODRicmJua3lyVHp5R2pNejlv?= =?utf-8?B?OE5OQWg0VU9oQzBFNkNPOGRteGxtZ3dlMEJNcDQ4VFJnTWp4SmpodGI2UHEv?= =?utf-8?B?MVVhMVNnVWpWWTRkUnlEK3hONTJyWlp3RFRQbkNaelVXSWF1Z3dvOUFmYVRX?= =?utf-8?B?WmMyZ0VXNEd0T1F6WGRjYlJrd0FOQW9HMC9Wa3JJeFBGYjg4dlRxc2lNVS9B?= =?utf-8?B?dFVWZWxuSk5YQjlIN01HVXQ2N1NvdmhOK3N6Sk04UFArOWJoVDF1bnAzK3Fy?= =?utf-8?B?VzVNZStHRGxyaWM3NlpKaUY5STlsU3o4WTdBcENYd0hWbVVmMTZEVDZvQ0pJ?= =?utf-8?B?dnJXUGhuamtQV3ErT3VUQ0Y1L3AvNDhNOWlwY1FBaXpVcXFwSERMR3Z1Y1lD?= =?utf-8?B?UzBYQzk4K3FWTGk3Rk5oZW83dnRhRVF5VUxvZVNLU3gvbU1IMjJoNWx6emZF?= =?utf-8?B?c2NCbER1d2dIYS9yTndBSnFtM0pIb2Y5ZHhwYS81dHBQb0t4eW4zTThvVTBw?= =?utf-8?B?K3p3anhoZjBrTDd0RU00RVI5akJ5ZlRjTTcxQ1BjMmhFY21ySjE2S2QxL3Ix?= =?utf-8?B?bzNPU0VWZFpjRUVMQ3dBbjVmMkZMdkJxYXNwZi9MazVuTnRZcGpyZ00rVEhL?= =?utf-8?B?alFFYnhuaTJVL3RGczNTelJBcGtqMzc2U2thd1BSVytTeTNrcEZDdFFsSmNT?= =?utf-8?Q?rpzicXlnijnQUVPY=3D?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: aed886a2-2580-484d-8a75-08da42e3c02b X-MS-Exchange-CrossTenant-originalarrivaltime: 31 May 2022 08:58:37.4809 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rDbl52y6jRT+Xq0HQ8y1zsigqi/L6TwNkFFxzdozzLmVfUZAYlwVDdVk4XxqB9n1R1ZOx5RlbSz9Y8qg8hazAw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3652 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v7 05/10] qsv: build audio related code when MFX_VERSION < 2.0 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sun, 2022-05-01 at 05:13 +0000, Soft Works wrote: > > -----Original Message----- > > From: ffmpeg-devel On Behalf Of > > Xiang, Haihao > > Sent: Sunday, May 1, 2022 6:52 AM > > To: anton@khirnov.net; ffmpeg-devel@ffmpeg.org > > Subject: Re: [FFmpeg-devel] [PATCH v7 05/10] qsv: build audio related > > code when MFX_VERSION < 2.0 > > > > On Sun, 2022-05-01 at 03:10 +0000, Soft Works wrote: > > > > -----Original Message----- > > > > From: ffmpeg-devel On Behalf Of > > > > Xiang, Haihao > > > > Sent: Sunday, May 1, 2022 4:16 AM > > > > To: anton@khirnov.net; ffmpeg-devel@ffmpeg.org > > > > Subject: Re: [FFmpeg-devel] [PATCH v7 05/10] qsv: build audio > > > > related > > > > code when MFX_VERSION < 2.0 > > > > > > > > On Sat, 2022-04-30 at 16:51 +0000, Soft Works wrote: > > > > > > -----Original Message----- > > > > > > From: ffmpeg-devel On Behalf > > > > Of > > > > > > Xiang, Haihao > > > > > > Sent: Wednesday, April 6, 2022 5:38 AM > > > > > > To: anton@khirnov.net; ffmpeg-devel@ffmpeg.org > > > > > > Subject: Re: [FFmpeg-devel] [PATCH v7 05/10] qsv: build audio > > > > > > > > related > > > > > > code when MFX_VERSION < 2.0 > > > > > > > > > > > > On Tue, 2022-04-05 at 13:50 +0200, Anton Khirnov wrote: > > > > > > > Quoting Xiang, Haihao (2022-03-11 09:16:25) > > > > > > > > From: Haihao Xiang > > > > > > > > > > > > > > > > Audio isn't supported for MFX_VERSION >= 2.0[1][2]. This > > > > is in > > > > > > > > preparation for oneVPL support > > > > > > > > > > > > > > > > [1]: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://spec.oneapi.io/versions/latest/elements/oneVPL/source/VPL_inte > > > > > > l_media_sdk.html#msdk-full-name-feature-removals > > > > > > > > [2]: https://github.com/oneapi-src/oneVPL > > > > > > > > --- > > > > > > > > libavcodec/qsv.c | 5 +++++ > > > > > > > > libavfilter/qsvvpp.c | 6 ++++++ > > > > > > > > libavfilter/qsvvpp.h | 2 ++ > > > > > > > > 3 files changed, 13 insertions(+) > > > > > > > > > > > > > > Why not just remove this completely? > > > > > > > None of our QSV code does anything with audio. > > > > > > > > > > > > It was removed in an older version, however someone objected > > > > the > > > > > > removal of > > > > > > this. See > > > > > > > > > > > > > > > > > > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20200819061023.44330 > > > > > > 4-2-haihao.xiang@intel.com/ > > > > > > > > > > I think this was a misunderstanding. I see not objection. One > > > > was > > > > > just asking "why" and the other one had missed the point that > > > > audio > > > > > has never been functional. > > > > > > > > Please find the comment below in the original thread > > > > > > > > "This seems like a generic translation from the library errors to > > > > FF > > > > error > > > > codes. So even if we'll never touch the audio functionality of it, > > > > I'd > > > > prefer > > > > to have that struct complete already" > > > > > > > > So my understanding was that the reviewer preferred to keep the > > > > audio > > > > stuff > > > > unchanged for libmfx. > > > > > > Hm, I hadn't see that here: > > > > > > > > > > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20200819061023.44330 > > 4-2-haihao.xiang@intel.com/ > > > > > > Considering the text again: > > > > > > > "This seems like a generic translation from the library errors to > > > > FF > > > > error > > > > codes. So even if we'll never touch the audio functionality of it, > > > > I'd > > > > prefer > > > > to have that struct complete already" > > > > > > I understand the idea. Normally those lines wouldn't hurt. But now, > > > > that > > > we're facing some kind of "#ifdef hell" anyway, I think it would be > > > > much > > > better to minimize this as much as possible, and there's really no > > > > point > > > in translating audio error codes. > > > Also, the struct has never been really complete. Instead of > > > > retaining > > > unused audio error codes, we should better add those that are > > > > missing > > > (like -21, -22 and others) and relevant. > > > > > > @Thilo - can we get you warm with that? > > > > > > As an alternative, we could simply replace the two audio definitions > > > > with > > > plain integer values (MFX_ERR_INVALID_AUDIO_PARAM >> -19) > > > > > > > > > This is a small bit only, but before adding the oneVPL stuff, I > > > > think > > > we should consolidate the conditional stuff as much as possible. > > > > > > As discussed before, we also need to settle for a minimum libmfx SDK > > > version (compile-time, not runtime!). This will allow to drop quite > > > an amount of conditional code, and this cleanup should be done > > > > before > > > getting to oneVPL. > > > > Sure, I'll submit a patch for it. > > > > > > > > Another thing that is a bit unfortunate is that we are duplicating > > > > this > > > error mapping struct in qsv.c and qsvvpp.c. > > > I don't mean that it should be linked as an external between > > > > avfilter > > > and avcodec, but it should come (be included) from a single file. > > > > We moved the static error table to a .h in the past however it > > resulted in link > > error when building FFmpeg with static libraries. > > That's why I said that it doesn't need to be exported - just a > single file that can be included/inlined in both cases where it > is used (lavcodec, lavfilter). Thanks for your comment, I'll consider to change it later. BTW we don't get response from Thilo, I'll keep this patch unchanged in the new version. I think we may update it in the future if there are more comments. Thanks Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".