Re: [FFmpeg-devel] [PATCH 2/7] avutil/vulkan: automatically enable shader device address usage bit

From: Lynne <dev@lynne.ee>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 2/7] avutil/vulkan: automatically enable shader device address usage bit
Date: Thu, 22 May 2025 06:32:18 +0900
Message-ID: <fded9425-5381-4138-b8d7-cd98f333999b@lynne.ee> (raw)
In-Reply-To: <20250518121152.94947-2-ffmpeg@haasn.xyz>

[-- Attachment #1.1.1.1: Type: text/plain, Size: 1057 bytes --]

On 18/05/2025 21:11, Niklas Haas wrote:
> From: Niklas Haas <git@haasn.dev>
> 
> We require this internally when using descriptor buffers, so it makes sense
> to enable it internally, also.
> ---
>   libavutil/vulkan.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/libavutil/vulkan.c b/libavutil/vulkan.c
> index 5f2ac6267d..97c008c809 100644
> --- a/libavutil/vulkan.c
> +++ b/libavutil/vulkan.c
> @@ -989,6 +989,9 @@ int ff_vk_create_buf(FFVulkanContext *s, FFVkBuffer *buf, size_t size,
>       int use_ded_mem;
>       FFVulkanFunctions *vk = &s->vkfn;
>   
> +    if (s->extensions & FF_VK_EXT_DESCRIPTOR_BUFFER)
> +        usage |= VK_BUFFER_USAGE_SHADER_DEVICE_ADDRESS_BIT;

You should omit the flag if the usage contains
VK_BUFFER_USAGE_VIDEO_DECODE_SRC_BIT_KHR or 
VK_BUFFER_USAGE_VIDEO_ENCODE_DST_BIT_KHR, since its not used there.

> +
>       VkBufferCreateInfo buf_spawn = {
>           .sType       = VK_STRUCTURE_TYPE_BUFFER_CREATE_INFO,
>           .pNext       = pNext,

Apart from that, okay.

[-- Attachment #1.1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 637 bytes --]

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".