From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3B5A4433DC for ; Thu, 9 Jun 2022 21:24:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 63F0D68B7D1; Fri, 10 Jun 2022 00:24:16 +0300 (EEST) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 91A5768B763 for ; Fri, 10 Jun 2022 00:24:09 +0300 (EEST) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 259LO8Ba006241-259LO8Bb006241 for ; Fri, 10 Jun 2022 00:24:08 +0300 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id AF9C3A142E for ; Fri, 10 Jun 2022 00:24:08 +0300 (EEST) Date: Fri, 10 Jun 2022 00:24:08 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: Message-ID: References: MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH v12 1/4] libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and utf8toansi X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, 9 Jun 2022, nil-admirari@mailo.com wrote: >> Right, I wasn't aware that the -A version would return a >> guaranteed-ansi-compatible version of the filename. If that's really the >> case, this patch would indeed be a minor step backwards. > > Two options are available: > 1. fopen() is replaced with avpriv_fopen_utf8(), getenv() is made Unicode-aware > on Windows, and wide version of get_module_filename() is used as it is now. > 2. A wrapper around GetModuleFilenameA() created specifically for this case, > only to be replaced later by option one, when avpriv_fopen_utf8() gets merged. > > If option one is chosen, the patch will have to wait for avpriv_fopen_utf8() patches. For that, the first option sounds better - that sounds to me more like a direction forward, not backwards. The patches for *_fopen_utf8 have already been merged - within the libraries, you can use avpriv_fopen_utf8, and fftools has got a separate "fopen_utf8" function it can use. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".