From: "Martin Storsjö" <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v12 1/4] libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and utf8toansi
Date: Fri, 10 Jun 2022 00:24:08 +0300 (EEST)
Message-ID: <fddacb3-e98-9484-5f80-d7548020a86a@martin.st> (raw)
In-Reply-To: <ea-mime-62a2622b-149-1823660d@www-7.mailo.com>
On Thu, 9 Jun 2022, nil-admirari@mailo.com wrote:
>> Right, I wasn't aware that the -A version would return a
>> guaranteed-ansi-compatible version of the filename. If that's really the
>> case, this patch would indeed be a minor step backwards.
>
> Two options are available:
> 1. fopen() is replaced with avpriv_fopen_utf8(), getenv() is made Unicode-aware
> on Windows, and wide version of get_module_filename() is used as it is now.
> 2. A wrapper around GetModuleFilenameA() created specifically for this case,
> only to be replaced later by option one, when avpriv_fopen_utf8() gets merged.
>
> If option one is chosen, the patch will have to wait for avpriv_fopen_utf8() patches.
For that, the first option sounds better - that sounds to me more like a
direction forward, not backwards.
The patches for *_fopen_utf8 have already been merged - within the
libraries, you can use avpriv_fopen_utf8, and fftools has got a separate
"fopen_utf8" function it can use.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-06-09 21:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-05 11:35 Nil Admirari
2022-06-05 11:35 ` [FFmpeg-devel] [PATCH v12 2/4] libavformat/avisynth.c: Remove MAX_PATH limit Nil Admirari
2022-06-05 11:35 ` [FFmpeg-devel] [PATCH v12 3/4] compat/w32dlfcn.h: Remove MAX_PATH limit and replace LoadLibraryExA with LoadLibraryExW Nil Admirari
2022-06-05 11:35 ` [FFmpeg-devel] [PATCH v12 4/4] fftools/cmdutils.c: Remove MAX_PATH limit Nil Admirari
2022-06-09 10:10 ` [FFmpeg-devel] [PATCH v12 1/4] libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and utf8toansi Martin Storsjö
2022-06-09 16:47 ` Soft Works
2022-06-09 16:48 ` Soft Works
2022-06-09 19:09 ` Martin Storsjö
2022-06-09 19:19 ` nil-admirari
2022-06-09 19:50 ` Soft Works
2022-06-09 20:23 ` Martin Storsjö
2022-06-09 21:12 ` nil-admirari
2022-06-09 21:24 ` Martin Storsjö [this message]
2022-06-13 16:36 ` nil-admirari
-- strict thread matches above, loose matches on Subject: below --
2022-06-05 11:34 Nil Admirari
2022-06-05 11:32 Nil Admirari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fddacb3-e98-9484-5f80-d7548020a86a@martin.st \
--to=martin@martin.st \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git