From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A02DE44E43 for ; Fri, 25 Nov 2022 23:57:15 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B396868ADF2; Sat, 26 Nov 2022 01:57:12 +0200 (EET) Received: from mail-oa1-f51.google.com (mail-oa1-f51.google.com [209.85.160.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 679B5689BD5 for ; Sat, 26 Nov 2022 01:57:06 +0200 (EET) Received: by mail-oa1-f51.google.com with SMTP id 586e51a60fabf-142faa7a207so6749606fac.13 for ; Fri, 25 Nov 2022 15:57:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=aqaRjoHZWRwVViSI2eyFse99Y6jsapRMMd8qFN1ndio=; b=jGKt75hUK0ocGhwvek8v1nbNOXqBr2hKGCMJjJpBFfN72Dve9ouoXetY7w8td0jxnM FDXSEj+DnPOcas2+mJZiFWxnQLCiOIKosF1oqzbnGRiGoWNHxYTMDuRNvRp6vYSSyr7n YHwXnXQTv1s2yRg12d8oKMEU/9+LxM+69LoSmM+valPHGrbz3bHYFfqirvK0kpnMEx3Z dCCaSc4XvK+Xl7kFIAu4f8dQEAlj2UQgFdJJ3MEDla+3AgaITjXC2HU+OkuMx9dtgeT+ zdAWua0FtDOgj8Nr9kNLID/Cnz926O4bLJVizcVdcjew6T6ytHaYUTJYBsFEiKUHoVba xe4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aqaRjoHZWRwVViSI2eyFse99Y6jsapRMMd8qFN1ndio=; b=Wcx+CM7d4E9t6zbnxz3a/vbd572Wwg9pYN8OMimLq8Usnpp0MJwNZZ0a6VCtFkZT1Y Mf36raUOIm+AtpJoKpQnUe1WbYiGqLIYIeFwlq6m9Vi444hrZkVIqCaH0uPq6pnNT/+f JPP0zgx2YHImLXyx2QnC7/P9xXC66FP0uNGtT7LcLaLYuyrhW/eHB1zyqmEW3DWq/iS7 +hShVBnJNrgO1z38tchj9j799acTKhKJv3hRln5FbiCB3eYqu1wVBnbDRoX7ioajVFkT JW/ixj6HTt9FUmemGALppoxiYmXSPqhHsQpAGADNFRJI1kGxImfRCEQU1EFUTuRQwwqa Ex2g== X-Gm-Message-State: ANoB5pm35KT5jL+ghKPNCsu0ARvzeCG3uhYai01AEdv8FfTduVsf3Bm3 k+0fwj7PiAI6y7h1ccbKQDKvyBXYZP0= X-Google-Smtp-Source: AA0mqf7jsKajGBQqnTLcKr20rUWQJ7ys5wnCyFVdh9SwWPaP06iFJkmdkBt5mSxm7zm0QG1JXWj29Q== X-Received: by 2002:a05:6870:b3a6:b0:13b:7e32:2dd5 with SMTP id w38-20020a056870b3a600b0013b7e322dd5mr22532486oap.242.1669420624700; Fri, 25 Nov 2022 15:57:04 -0800 (PST) Received: from [192.168.0.15] ([181.85.72.69]) by smtp.gmail.com with ESMTPSA id f15-20020a056870c10f00b0011bde9f5745sm2791727oad.23.2022.11.25.15.57.03 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Nov 2022 15:57:04 -0800 (PST) Message-ID: Date: Fri, 25 Nov 2022 20:57:48 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20221124052209.520239-1-haihao.xiang@intel.com> <166938393779.4503.7930861168279237996@lain.khirnov.net> <12d8e532-f236-83b8-61cf-6c9ee72b10ee@gmail.com> <4bcec8d4-8593-9a23-3130-8aa52b1f3c11@gmail.com> From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support P010 format X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 11/25/2022 8:51 PM, Soft Works wrote: > > >> -----Original Message----- >> From: ffmpeg-devel On Behalf Of >> James Almer >> Sent: Saturday, November 26, 2022 12:35 AM >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support >> P010 format >> >> On 11/25/2022 8:26 PM, Dong, Ruijing wrote: >>> [AMD Official Use Only - General] >>> >>> Will it make sense to accept P010 input, however encode to h264 >> 8bit? >> >> If it works (the encoder accepts the 10 bit input even if it encodes >> it >> as 8bit), then i don't see why not. I assume it would also be faster >> than using swscale to convert said 10bit input to nv12 before passing >> that to the encoder. >> >> Removing support for a pixel format as input in an encoder needs a >> reason other than "It's rarely used", more so when it's a single >> line. >> It either needs to not work, or somehow get in the way of further >> improvements. > > Oh sorry, I noticed that there was a misunderstanding. > > When I said "It's rarely used", I didn't mean that as a justification > for the removal, it was meant as an explanation why none of the > hwaccels has implemented it. > > softworkz Alright, then i'll repeat my question: Does it work? And I don't mean the encoder outputting a 10bit h264 stream, since you made it clear it doesn't, i mean accepting 10bit input in p010 pixel format and outputting a valid stream and not garbage. If it does, then there's no reason to remove this line. If it does not, then that should have been mentioned in the patch as the reason why this is being done. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".