From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 66A4540453 for ; Mon, 20 Dec 2021 23:49:59 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9D16068AEE9; Tue, 21 Dec 2021 01:49:56 +0200 (EET) Received: from atvie01s.evermeet.cx (evermeet.cx [92.42.139.5]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0512A68A61A for ; Tue, 21 Dec 2021 01:49:49 +0200 (EET) Received: from epsilon3.local (cpe40623114f2db-cm9050ca186c30.cpe.net.cable.rogers.com [99.238.64.16]) (authenticated bits=0) by atvie01s.evermeet.cx (8.17.1/8.16.1) with ESMTPSA id 1BKNnlQg2404417 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 21 Dec 2021 00:49:48 +0100 DKIM-Filter: OpenDKIM Filter v2.11.0 atvie01s.evermeet.cx 1BKNnlQg2404417 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=evermeet.cx; s=d202110; t=1640044189; bh=2Z5YYANxiQa0SBGbnA9yH5IB/0pbOHAIQgZzCsPjShM=; h=Subject:To:References:From:Date:In-Reply-To:From; b=XLMdk9eX3Q2kk+OVXJDMk0FPtdTBHAwoFuUflKh4p/iqO5i95DyJDYP7Ak2XbKbHR cig15+8Ge76dCSdRhTwR4qjV3Avfkz1aHGDRHVJzz1JRXyeloq2wwZH380csn/dX8D MR9VToVKWTF41xQohVgd4xQMVKrkNbfanSIMAXXyOK2AsotpCm6qPbt7HwegAFX37Z 5mdrwP2KYIIOSNt4OTweR6GTh49infwsEw2bVcg2VPau6nEFtTjroKI5z8+g9tw1uG kAzdJAuEvuYoBNeXlkNTbNkKBFBRv0NNfgYbI+hxJCPuGMmUZmmHnFvNzhDhQ+GZJG lcKujQMLnNX4g== To: Ridley Combs , ffmpeg-devel References: <5fb60616-5ded-1b3a-255c-14deb44924d9@evermeet.cx> From: "Helmut K. C. Tessarek" Openpgp: id=8A5570C1BD85D34EADBC386C172380A011EF4944 Message-ID: Date: Mon, 20 Dec 2021 18:49:47 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Subject: Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Thanks for the rwply. On 2021-12-20 18:25, Ridley Combs wrote: > Could you try with this patch and let me know if it works for you then? > https://gist.github.com/7362df8a689c41b9174ac50fdeda3e43 I've applied your patch and get the following now: CC libavfilter/scale_eval.o CC libavfilter/scene_sad.o libavfilter/metal/vf_yadif_videotoolbox.metal:47:1: error: constant sampler must be declared constexpr const sampler s(coord::pixel); ^ constexpr libavfilter/metal/vf_yadif_videotoolbox.metal:122:14: error: use of undeclared identifier 'max3' T diff = max3(tdiff0, tdiff1, tdiff2); ^ libavfilter/metal/vf_yadif_videotoolbox.metal:152:9: note: in instantiation of function template specialization 'temporal_predictor' requested here temporal_predictor(A.x, B.x, C.x, D.x, E.x, F.x, ^ libavfilter/metal/vf_yadif_videotoolbox.metal:125:18: error: use of undeclared identifier 'max3' T maxi = max3(p2 - p3, p2 - p1, min(p0 - p1, p4 - p3)); ^ libavfilter/metal/vf_yadif_videotoolbox.metal:126:18: error: use of undeclared identifier 'min3' T mini = min3(p2 - p3, p2 - p1, max(p0 - p1, p4 - p3)); ^ libavfilter/metal/vf_yadif_videotoolbox.metal:217:12: error: no matching function for call to 'temporal_predictor' return temporal_predictor(A, B, C, D, E, F, G, H, I, J, K, L, ^~~~~~~~~~~~~~~~~~ libavfilter/metal/vf_yadif_videotoolbox.metal:233:16: note: in instantiation of function template specialization 'yadif_compute_temporal' requested here return yadif_compute_temporal(cur, prev, cur, next, next, spatial_pred, params.skip_spatial_check, pos); ^ libavfilter/metal/vf_yadif_videotoolbox.metal:265:23: note: in instantiation of function template specialization 'yadif' requested here pred = float2(yadif(dst, prev, cur, next, params, pos)); ^ libavfilter/metal/vf_yadif_videotoolbox.metal:108:3: note: candidate template ignored: substitution failure [with T = float] T temporal_predictor(T A, T B, T C, T D, T E, T F, ^ 5 errors generated. make: *** [libavfilter/metal/vf_yadif_videotoolbox.metal.air] Error 1 make: *** Waiting for unfinished jobs.... libavfilter/metal/utils.m:33:21: warning: instance method '-supportsFamily:' not found (return type defaults to 'id') [-Wobjc-method-access] if ([device supportsFamily:MTLGPUFamilyCommon3]) { ^~~~~~~~~~~~~~ libavfilter/metal/utils.m:33:36: error: use of undeclared identifier 'MTLGPUFamilyCommon3' if ([device supportsFamily:MTLGPUFamilyCommon3]) { ^ 1 warning and 1 error generated. make: *** [libavfilter/metal/utils.o] Error 1 Error compiling ffmpeg... > If you can test actual deployment on a 10.9 or 10.10 system that'd be > great. Unfortunately I don't have a 10.9 or 10.10 system. I compile on macOS 1.14 with export MACOSX_DEPLOYMENT_TARGET=10.9 Cheers, K. C. - -- regards Helmut K. C. Tessarek KeyID 0x172380A011EF4944 Key fingerprint = 8A55 70C1 BD85 D34E ADBC 386C 1723 80A0 11EF 4944 /* Thou shalt not follow the NULL pointer for chaos and madness await thee at its end. */ -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE191csiqpm8f5Ln9WvgmFNJ1E3QAFAmHBFpsACgkQvgmFNJ1E 3QDapA//WmxnoAqIGCqliaSIUpRkL/KxhSpj9ULJzL1h9yw6Ls0DIYT39Pa66hTk IABKgLiTNxe1hNTC9kbXf6HdNqJw7KGGUlCGu777RHhh7wySq355g7b89f1wrSJa 1RwCkb9EoyC/DzeSnayDk6oOO7duJxCibkdTXEsYW9VgA9QGSriTHIRSG666UgXO NC6EyjiOfGqlVkTr9Ott+r2t30H/0faihttbIhLwV6y/Dd/vx4mdG4y61B0PXLX1 rAQwDP9GYkAa302XLeLSTTJ/IHzsV7xD1eE+I3QcB63gbzKlujfbSBiOf9Czv6Vs M1xoRbcqYkTi7zK45t7w+FuAMn/her/P5cCjmXbEQIHBZEfX3r2MKtkdIAhHsUPl vDvR7Zmi90gRorQnyQ1fy/LaIcZt6E6CFPKQrIVkBsOnIuXvnrx4fxsvo4rYO32p goyhtmBMyg9zIZy4eSUn/3M5NKMifgSQrYdUIIKrJZr4ENesKTGB/EZXS30v5VF4 7GrObWDT1oR+VoUiMSYrGPSBlF8R/NHJGU/BL7iVFtF7CfFRnHmfgzyII8RlS6G+ V5stD8eKNr/8fzI3sjQfiROEMtLFKJz4Zkf6qmBT7zeDizNJp/xaGc2egsC7LMzX or7vCtN6YKPXhQimhsrxDvIXLdvt2ZsCwcbNpq5ZzEMi8mDgwCs= =DJOy -----END PGP SIGNATURE----- _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".