From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BB91049147 for ; Sun, 4 Feb 2024 13:24:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D0EC268D124; Sun, 4 Feb 2024 15:24:16 +0200 (EET) Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 29DFE68C15D for ; Sun, 4 Feb 2024 15:24:11 +0200 (EET) Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-40fd446d520so6504515e9.3 for ; Sun, 04 Feb 2024 05:24:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jkqxz-net.20230601.gappssmtp.com; s=20230601; t=1707053050; x=1707657850; darn=ffmpeg.org; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=I+Wuzqk/mHbYZpWrkmzU3NToQPsDL4L8tzJpE6MWGbA=; b=gKmlKUpYypn0RfEvuOzHnIVNPHsjagDcp9yJlEVVfy63do47QadXfrZ6YhqEurPSqi wMqZDm/Vyt0vtOXPKglClvx4BIWnvn7xgcX9soF3CU2AJLkYP7JSE7WD40DybGOAcP+W nVfp6abdRK65BgxxTu2wIgE+1wef8QT+9x2Z7vicNcDMRIG3A8fZd/bmT73pe+GwmWPj Jvt7eqqBw1w+4HDajpYLWGEEUUzrsiQCUuoEeFtOtpotxQLADBC5HlnSyHL27q4j1Crp XmJq31wsqxEZRZPM41Lw0xSVeFggHs6LusU/XpoQRXsZTYWxV1gRTHgY2Pe510avldDk sG1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707053050; x=1707657850; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=I+Wuzqk/mHbYZpWrkmzU3NToQPsDL4L8tzJpE6MWGbA=; b=unEATh10J5vNa3zvo411OyhY6P9SenIjlb6/yjfETq73wOoQasye6yxESLI/l1qzjB /bPPKYd5wOaMokpLull3z/YqXq7GiX/VSBAmRq1KuosDjGDBhDmzhYq2YFASs+bl5U3e XRld/HSlMe/9H7WBKTTcHI9vt/MpAQJBaNL34TEzZAQ4k8b/O5VCqm9HABv2+eok7Y9h L6mfUEiN2FpFTCOps20owk7IuHkqkXfuB/wgXDOrHtmuf8ZlE53JZALXeUlO+2f3JN14 IdpqnbDtBFv05F71CFRU/Umn3kmX5gapwvwptdQZ+Wi8PjUHsTRR0UfWzA1XhB4/n+lc us8Q== X-Gm-Message-State: AOJu0Yzsrqn6qKSTSjY3qRqo3Pa/J4qckrq9o6qcICerwGwRDMjJoV1R +ZRQ2kkiaDg3keIklBuznzZBl9foRlufmUQNr/6T5rmyRcnw81GepV/NJCHGuYTTcra8XZKmn1B c X-Google-Smtp-Source: AGHT+IEfEdnGiWD+f5ao1kYFgVnIgf8mo7DN5qgiWRr7NJxoCiaVlvwEgzIQ4V70Qc6guenb8ZItWw== X-Received: by 2002:a05:600c:4687:b0:40f:e40:b53d with SMTP id p7-20020a05600c468700b0040f0e40b53dmr2558436wmo.1.1707053050216; Sun, 04 Feb 2024 05:24:10 -0800 (PST) Received: from [192.168.0.15] (cpc92302-cmbg19-2-0-cust1183.5-4.cable.virginm.net. [82.1.212.160]) by smtp.gmail.com with ESMTPSA id f15-20020a05600c154f00b0040ee51f1025sm5670445wmg.43.2024.02.04.05.24.09 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 04 Feb 2024 05:24:09 -0800 (PST) Message-ID: Date: Sun, 4 Feb 2024 13:24:33 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: FFmpeg development discussions and patches From: Mark Thompson Subject: [FFmpeg-devel] [PATCH] lavc/d3d12va: Improve behaviour on missing decoder support X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Distinguish between a decoder being entirely missing and a decoder which requires features which are not present in the incomplete implementation in libavcodec and therefore can't be used. --- libavcodec/d3d12va_decode.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/libavcodec/d3d12va_decode.c b/libavcodec/d3d12va_decode.c index f678b6f483..9bb8db1690 100644 --- a/libavcodec/d3d12va_decode.c +++ b/libavcodec/d3d12va_decode.c @@ -239,10 +239,14 @@ static int d3d12va_create_decoder(AVCodecContext *avctx) DX_CHECK(ID3D12VideoDevice_CheckFeatureSupport(device_hwctx->video_device, D3D12_FEATURE_VIDEO_DECODE_SUPPORT, &feature, sizeof(feature))); - if (!(feature.SupportFlags & D3D12_VIDEO_DECODE_SUPPORT_FLAG_SUPPORTED) || - !(feature.DecodeTier >= D3D12_VIDEO_DECODE_TIER_2)) { - av_log(avctx, AV_LOG_ERROR, "D3D12 decoder doesn't support on this device\n"); - return AVERROR(EINVAL); + if (!(feature.SupportFlags & D3D12_VIDEO_DECODE_SUPPORT_FLAG_SUPPORTED)) { + av_log(avctx, AV_LOG_ERROR, "D3D12 video decode is not supported on this device.\n"); + return AVERROR(ENOSYS); + } + if (!(feature.DecodeTier >= D3D12_VIDEO_DECODE_TIER_2)) { + av_log(avctx, AV_LOG_ERROR, "D3D12 video decode on this device requires tier %d support, " + "but it is not implemented.\n", feature.DecodeTier); + return AVERROR_PATCHWELCOME; } desc = (D3D12_VIDEO_DECODER_DESC) { -- 2.43.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".