* [FFmpeg-devel] 答复: [PATCH] avformat/wavdec: fix the ID3 metadata obtained in WAV format's missing
@ 2022-08-20 10:23 Wujian(Chin)
0 siblings, 0 replies; 6+ messages in thread
From: Wujian(Chin) @ 2022-08-20 10:23 UTC (permalink / raw)
To: ffmpeg-devel
Please review it!
Thx!
-----邮件原件-----
发件人: Wujian(Chin)
发送时间: 2022年8月15日 19:32
收件人: 'ffmpeg-devel@ffmpeg.org' <ffmpeg-devel@ffmpeg.org>
主题: 答复: [PATCH] avformat/wavdec: fix the ID3 metadata obtained in WAV format's missing
Please review it!
Thx!
-----邮件原件-----
发件人: Wujian(Chin)
发送时间: 2022年8月9日 20:03
收件人: 'ffmpeg-devel@ffmpeg.org' <ffmpeg-devel@ffmpeg.org>
主题: [PATCH] avformat/wavdec: fix the ID3 metadata obtained in WAV format's missing
Fixes ticket #9848.
Signed-off-by: wujian_nanjing <wujian2@huawei.com>
---
libavformat/wavdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c index ca61b84..e3f790f 100644
--- a/libavformat/wavdec.c
+++ b/libavformat/wavdec.c
@@ -555,7 +555,7 @@ static int wav_read_header(AVFormatContext *s)
case MKTAG('I', 'D', '3', ' '):
case MKTAG('i', 'd', '3', ' '): {
ID3v2ExtraMeta *id3v2_extra_meta;
- ff_id3v2_read_dict(pb, &ffformatcontext(s)->id3v2_meta, ID3v2_DEFAULT_MAGIC, &id3v2_extra_meta);
+ ff_id3v2_read(s, ID3v2_DEFAULT_MAGIC, &id3v2_extra_meta,
+ 0);
if (id3v2_extra_meta) {
ff_id3v2_parse_apic(s, id3v2_extra_meta);
ff_id3v2_parse_chapters(s, id3v2_extra_meta);
--
2.7.4
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avformat/wavdec: fix the ID3 metadata obtained in WAV format's missing
2022-08-23 1:59 ` Steven Liu
@ 2022-08-24 2:46 ` Steven Liu
0 siblings, 0 replies; 6+ messages in thread
From: Steven Liu @ 2022-08-24 2:46 UTC (permalink / raw)
To: FFmpeg development discussions and patches
Steven Liu <lingjiujianke@gmail.com> 于2022年8月23日周二 09:59写道：
>
> Wujian(Chin) <wujian2@huawei.com> 于2022年8月22日周一 22:00写道：
> >
> > Fixes ticket #9848.
> >
> > Signed-off-by: wujian_nanjing <wujian2@huawei.com>
> > ---
> > libavformat/wavdec.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c
> > index ca61b84..e3f790f 100644
> > --- a/libavformat/wavdec.c
> > +++ b/libavformat/wavdec.c
> > @@ -555,7 +555,7 @@ static int wav_read_header(AVFormatContext *s)
> > case MKTAG('I', 'D', '3', ' '):
> > case MKTAG('i', 'd', '3', ' '): {
> > ID3v2ExtraMeta *id3v2_extra_meta;
> > - ff_id3v2_read_dict(pb, &ffformatcontext(s)->id3v2_meta, ID3v2_DEFAULT_MAGIC, &id3v2_extra_meta);
> > + ff_id3v2_read(s, ID3v2_DEFAULT_MAGIC, &id3v2_extra_meta, 0);
> > if (id3v2_extra_meta) {
> > ff_id3v2_parse_apic(s, id3v2_extra_meta);
> > ff_id3v2_parse_chapters(s, id3v2_extra_meta);
> > --
> > 2.7.4
> >
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
> Tested ok to me, will push this patch after 24 hours if there have no
> objections.
Pushed.
Thanks
Steven
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avformat/wavdec: fix the ID3 metadata obtained in WAV format's missing
2022-08-22 13:59 [FFmpeg-devel] " Wujian(Chin)
@ 2022-08-23 1:59 ` Steven Liu
2022-08-24 2:46 ` Steven Liu
0 siblings, 1 reply; 6+ messages in thread
From: Steven Liu @ 2022-08-23 1:59 UTC (permalink / raw)
To: FFmpeg development discussions and patches
Wujian(Chin) <wujian2@huawei.com> 于2022年8月22日周一 22:00写道：
>
> Fixes ticket #9848.
>
> Signed-off-by: wujian_nanjing <wujian2@huawei.com>
> ---
> libavformat/wavdec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c
> index ca61b84..e3f790f 100644
> --- a/libavformat/wavdec.c
> +++ b/libavformat/wavdec.c
> @@ -555,7 +555,7 @@ static int wav_read_header(AVFormatContext *s)
> case MKTAG('I', 'D', '3', ' '):
> case MKTAG('i', 'd', '3', ' '): {
> ID3v2ExtraMeta *id3v2_extra_meta;
> - ff_id3v2_read_dict(pb, &ffformatcontext(s)->id3v2_meta, ID3v2_DEFAULT_MAGIC, &id3v2_extra_meta);
> + ff_id3v2_read(s, ID3v2_DEFAULT_MAGIC, &id3v2_extra_meta, 0);
> if (id3v2_extra_meta) {
> ff_id3v2_parse_apic(s, id3v2_extra_meta);
> ff_id3v2_parse_chapters(s, id3v2_extra_meta);
> --
> 2.7.4
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Tested ok to me, will push this patch after 24 hours if there have no
objections.
Thanks
Steven
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
* [FFmpeg-devel] [PATCH] avformat/wavdec: fix the ID3 metadata obtained in WAV format's missing
@ 2022-08-22 13:59 Wujian(Chin)
2022-08-23 1:59 ` Steven Liu
0 siblings, 1 reply; 6+ messages in thread
From: Wujian(Chin) @ 2022-08-22 13:59 UTC (permalink / raw)
To: ffmpeg-devel
Fixes ticket #9848.
Signed-off-by: wujian_nanjing <wujian2@huawei.com>
---
libavformat/wavdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c
index ca61b84..e3f790f 100644
--- a/libavformat/wavdec.c
+++ b/libavformat/wavdec.c
@@ -555,7 +555,7 @@ static int wav_read_header(AVFormatContext *s)
case MKTAG('I', 'D', '3', ' '):
case MKTAG('i', 'd', '3', ' '): {
ID3v2ExtraMeta *id3v2_extra_meta;
- ff_id3v2_read_dict(pb, &ffformatcontext(s)->id3v2_meta, ID3v2_DEFAULT_MAGIC, &id3v2_extra_meta);
+ ff_id3v2_read(s, ID3v2_DEFAULT_MAGIC, &id3v2_extra_meta, 0);
if (id3v2_extra_meta) {
ff_id3v2_parse_apic(s, id3v2_extra_meta);
ff_id3v2_parse_chapters(s, id3v2_extra_meta);
--
2.7.4
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
* [FFmpeg-devel] 答复: [PATCH] avformat/wavdec: fix the ID3 metadata obtained in WAV format's missing
@ 2022-08-15 11:32 Wujian(Chin)
0 siblings, 0 replies; 6+ messages in thread
From: Wujian(Chin) @ 2022-08-15 11:32 UTC (permalink / raw)
To: ffmpeg-devel
Please review it!
Thx!
-----邮件原件-----
发件人: Wujian(Chin)
发送时间: 2022年8月9日 20:03
收件人: 'ffmpeg-devel@ffmpeg.org' <ffmpeg-devel@ffmpeg.org>
主题: [PATCH] avformat/wavdec: fix the ID3 metadata obtained in WAV format's missing
Fixes ticket #9848.
Signed-off-by: wujian_nanjing <wujian2@huawei.com>
---
libavformat/wavdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c index ca61b84..e3f790f 100644
--- a/libavformat/wavdec.c
+++ b/libavformat/wavdec.c
@@ -555,7 +555,7 @@ static int wav_read_header(AVFormatContext *s)
case MKTAG('I', 'D', '3', ' '):
case MKTAG('i', 'd', '3', ' '): {
ID3v2ExtraMeta *id3v2_extra_meta;
- ff_id3v2_read_dict(pb, &ffformatcontext(s)->id3v2_meta, ID3v2_DEFAULT_MAGIC, &id3v2_extra_meta);
+ ff_id3v2_read(s, ID3v2_DEFAULT_MAGIC, &id3v2_extra_meta,
+ 0);
if (id3v2_extra_meta) {
ff_id3v2_parse_apic(s, id3v2_extra_meta);
ff_id3v2_parse_chapters(s, id3v2_extra_meta);
--
2.7.4
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
* [FFmpeg-devel] [PATCH] avformat/wavdec: fix the ID3 metadata obtained in WAV format's missing
@ 2022-08-09 12:02 Wujian(Chin)
0 siblings, 0 replies; 6+ messages in thread
From: Wujian(Chin) @ 2022-08-09 12:02 UTC (permalink / raw)
To: ffmpeg-devel
Fixes ticket #9848.
Signed-off-by: wujian_nanjing <wujian2@huawei.com>
---
libavformat/wavdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c
index ca61b84..e3f790f 100644
--- a/libavformat/wavdec.c
+++ b/libavformat/wavdec.c
@@ -555,7 +555,7 @@ static int wav_read_header(AVFormatContext *s)
case MKTAG('I', 'D', '3', ' '):
case MKTAG('i', 'd', '3', ' '): {
ID3v2ExtraMeta *id3v2_extra_meta;
- ff_id3v2_read_dict(pb, &ffformatcontext(s)->id3v2_meta, ID3v2_DEFAULT_MAGIC, &id3v2_extra_meta);
+ ff_id3v2_read(s, ID3v2_DEFAULT_MAGIC, &id3v2_extra_meta, 0);
if (id3v2_extra_meta) {
ff_id3v2_parse_apic(s, id3v2_extra_meta);
ff_id3v2_parse_chapters(s, id3v2_extra_meta);
--
2.7.4
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-08-24 2:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-20 10:23 [FFmpeg-devel] 答复: [PATCH] avformat/wavdec: fix the ID3 metadata obtained in WAV format's missing Wujian(Chin)
-- strict thread matches above, loose matches on Subject: below --
2022-08-22 13:59 [FFmpeg-devel] " Wujian(Chin)
2022-08-23 1:59 ` Steven Liu
2022-08-24 2:46 ` Steven Liu
2022-08-15 11:32 [FFmpeg-devel] 答复: " Wujian(Chin)
2022-08-09 12:02 [FFmpeg-devel] " Wujian(Chin)
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git