From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1043D4428D for ; Sun, 4 Sep 2022 19:14:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 478DD68B85C; Sun, 4 Sep 2022 22:14:10 +0300 (EEST) Received: from mail-vk1-f173.google.com (mail-vk1-f173.google.com [209.85.221.173]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E733868B405 for ; Sun, 4 Sep 2022 22:14:03 +0300 (EEST) Received: by mail-vk1-f173.google.com with SMTP id b81so3306386vkf.1 for ; Sun, 04 Sep 2022 12:14:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=JU9EuNEH5dNj3h859tjtl8SeCsCPUHPYpuGGis8xwAg=; b=WoaRYu+1/71MYXDtbzLefuFAsVqWkBkW4DECbcM9EFWqWOcrg2uz/+9xEyaUuI7AOC k/TT3DUg8jiBBeCHuvU+elv7xpXqJNU+a+vDonk1C9t0163wbzt/e5ijmRplC+2JRqTZ LgRdP0yMAXhDupEzJwvawwgVoFm/wUHcinG/QE65xTeGcHwWLkkto2L25/02Io4hdVp+ lFM1fviRNIXPNWSzX1neTbbiRFwBXKTILTwYrF7xvfwz1raBVK5/tAYYJtr6D3vcVK0e y6E5kHvEGs01K8B3X2Q9/HEoxKXOV7T7KCXSAeMob2/c0GiQoVRlwQdUbb7Z+CsVM0cB 3Lng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=JU9EuNEH5dNj3h859tjtl8SeCsCPUHPYpuGGis8xwAg=; b=X+4W5zrk8XfSOwRy1LjoCzWf2tLO+caSbjhgMKmABnT+7G0afhCIqyxEd/PGqRFbSI cxRUuuILqJQLbOMVkz5lVZs067K8v0UkXwN7xQqccGm4XXw2IVMNiksaFIdp9v6FeHYL zHHh+RVlVPime3RCbpqEV0/CTBYJ+zJWMe8+ZO1QH4T8F6qq50UVQs01dOQvAoe5sGo1 PLwgIk/wPH1WGOx/BBt8FrcpfL+fwxydGxR75aoenbAii9HgLRFJ81qFfjGYb/5IpMmJ h9LQqHHjhNEYpbqyPBgYcyYtLpRTrLv7bj6pizpZP2xnvjFa0P+fKQy3UThCzBjiel8h VVwA== X-Gm-Message-State: ACgBeo37a87Zm+aNtQOSqq6Vr5m8JNEe4tw1kcPahUD45q/BOTcTl3B/ LPZidKS9sQwqmpNrt+7ivbQ7oNi4W7CF9w== X-Google-Smtp-Source: AA6agR6eOO9gE1L7ovyTcLC10DPSBSKvIi981n7Cq9KQeWGFlQOrf9mRdfFY5WkynhZZO6Ra1wliaA== X-Received: by 2002:a1f:22c5:0:b0:394:e2da:730f with SMTP id i188-20020a1f22c5000000b00394e2da730fmr5103817vki.27.1662318842237; Sun, 04 Sep 2022 12:14:02 -0700 (PDT) Received: from [192.168.1.15] (075-115-109-114.inf.spectrum.com. [75.115.109.114]) by smtp.gmail.com with ESMTPSA id b124-20020a1fb282000000b00382d5e1b95esm1128809vkf.35.2022.09.04.12.14.01 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 04 Sep 2022 12:14:01 -0700 (PDT) Message-ID: Date: Sun, 4 Sep 2022 15:14:00 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220208110240.4179-1-qyot27@gmail.com> <20220208110240.4179-3-qyot27@gmail.com> <8a7161a1-ef76-0958-ba9e-8ecf7b7fa998@gmail.com> From: Stephen Hutchinson In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 2/3] avisynth: use AviSynth+'s frame properties to set various fields X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 8/25/22 3:46 AM, Steinar Apalnes wrote: > tor. 25. aug. 2022 kl. 02:11 skrev Stephen Hutchinson : > >> On 8/24/22 1:04 PM, Steinar Apalnes wrote: >>> tir. 8. feb. 2022 kl. 12:03 skrev Stephen Hutchinson : >>> >>>> * Field Order >>>> * Chroma Location >>>> * Color Transfer Characteristics >>>> * Color Range >>>> * Color Primaries >>>> * Matrix Coefficients >>>> >>>> The existing TFF/BFF detection is retained as a fallback for >>>> older versions of AviSynth that can't access frame properties. >>>> The other properties have no legacy equivalent to detect them. >>>> >>>> Signed-off-by: Stephen Hutchinson >>>> >>> ....... >>> Hi Stephen, >>> >>> Would it be possible to add support for "_SARum" and "_SARDen" so that >>> ffmpeg could also recognize the sample aspect ratio in avs scripts? >>> >> >> I'm a bit hesitant to do so, namely because the _SARNum/Den properties >> are much more likely to need to have been changed due to operations >> in-script, and unless the user is studious about updating those >> properties after even just a basic resizing operation, then _SARNum/Den >> will still be set to the original values populated by the source filter, >> and will be wrong, leading to encodes ending up wrong and potentially >> bug reports to Trac which aren't actually the fault of the demuxer. >> >> This is partially coming from the fact that even the color-based >> properties that were already added have experienced some level of >> backlash because of the requirement for users to ensure the properties >> are correctly updated if they've done any changes to those factors >> (as best as I'm aware, the filters in the AviSynth+ core still only pass >> through the existing properties, but they don't update them if they >> pertain to that property's functionality; I believe some external >> filters do update them, however). I would be fairly confident in >> betting that users resizing video is far more common than them doing >> color correction ops that would require updating the frameprops FFmpeg >> can currently read. >> >> One mitigation to that, IMO, would be to flag that as an experimental >> feature, making it to where FFmpeg won't read _SARNum/Den unless >> the -strict option has been used. >> _______________________________________________ >> >> > If you think cherry picking what props to support under normal operation is > the way to go > then a -strict option to support *all* "scary" avs props would be very > welcome indeed. > Because as it is now we have nothing at all in regards to the SAR. > > Thanks for your efforts :-) > > -steinar SAR frameprops implemented in commit c49beead, and a more fine-grained, flags-based way to toggle any of the frameprops on and off added in commit adead1cc. Pushed a few minutes ago. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".