From: "Martin Storsjö" <martin@martin.st> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Subject: Re: [FFmpeg-devel] [PATCH 2/2] lavu/riscv: add hwprobe() for CPU detection Date: Mon, 6 May 2024 23:37:02 +0300 (EEST) Message-ID: <fcd4664-3ad4-39fa-2b7c-2e9f6067aa73@martin.st> (raw) In-Reply-To: <20240503171520.27795-2-remi@remlab.net> On Fri, 3 May 2024, Rémi Denis-Courmont wrote: > This adds the Linux-specific function call to detect CPU features. Unlike > the more portable auxillary vector, this supports extensions other than > single lettered ones. At this point, FFmpeg already needs this to detect > Zba and Zbb at run-time, and probably will need it for Zvbb in the near > future. > > Support will be available in glibc 2.40 onward. > --- > configure | 3 +++ > libavutil/riscv/cpu.c | 25 +++++++++++++++++++++++++ > 2 files changed, 28 insertions(+) > @@ -27,10 +29,33 @@ > #include <sys/auxv.h> > #define HWCAP_RV(letter) (1ul << ((letter) - 'A')) > #endif > +#ifdef HAVE_SYS_HWPROBE_H Aren't these kind of config.h macros always defined, but with the values 0/1? I.e., shouldn't this use #if instead of #ifdef? // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-05-06 20:37 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-05-03 17:15 Rémi Denis-Courmont 2024-05-06 20:37 ` Martin Storsjö [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=fcd4664-3ad4-39fa-2b7c-2e9f6067aa73@martin.st \ --to=martin@martin.st \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git